| J1m | You might be able to get buildout to use yours, but it feels error prone. | 00:00 |
|---|---|---|
| * J1m would be slightly (and pleasently) surprised if Fredrick was actually taking an interest. | 00:01 | |
| aclark | J1m: Right, just wanted to confirm that. I'm not sure what I'll do but at least I know I can't rely on buildout to do what I want. (IOW, it'd be nice if there were an equivalent in buildout to do easy_install http://dist.plone.org/thirdparty/PIL-1.1.7.tar.gz, i.e. install this egg from this location) | 00:01 |
| *** danielblackburn is now known as danielb_afk | 00:02 | |
| J1m | aclark, yeah, although it's not a use case I'd want to put a lot of effort into. | 00:03 |
| aclark | J1m: If I didn't have enough to do already, I might consider forking PIL ;-) | 00:03 |
| aclark | J1m: Understood, np | 00:03 |
| J1m | It sounds like already forked at least the release. The fact that it's a fork should be reflected in the project name. | 00:05 |
| *** benji has quit IRC | 00:05 | |
| J1m | This PILwoTK :) | 00:05 |
| aclark | Right | 00:05 |
| J1m | That was such an evil release, I'm actually proud of it. ;) | 00:05 |
| aclark | J1m: Perhaps a PILwoTk 1.1.7 is in order then ;-) | 00:05 |
| *** hathawsh has quit IRC | 00:06 | |
| * aclark ponders PILwNS for "PIL with name spaces" :-) | 00:06 | |
| *** allisterb has quit IRC | 00:10 | |
| *** andreypopp has joined #zope3-dev | 00:11 | |
| *** allisterb has joined #zope3-dev | 00:24 | |
| *** andreypopp has quit IRC | 00:35 | |
| *** afd___ has joined #zope3-dev | 00:46 | |
| *** afd__ has quit IRC | 00:49 | |
| *** andreypopp has joined #zope3-dev | 00:53 | |
| *** andreypopp has quit IRC | 00:55 | |
| *** JaRoel|4D has joined #zope3-dev | 01:02 | |
| *** JaRoel|4D has joined #zope3-dev | 01:03 | |
| *** aaronv has quit IRC | 01:05 | |
| *** mcdonc has quit IRC | 01:08 | |
| *** tarek has joined #zope3-dev | 01:09 | |
| *** gary_poster has quit IRC | 01:16 | |
| *** J1m has quit IRC | 01:33 | |
| *** aaronv has joined #zope3-dev | 01:42 | |
| *** aaronv has quit IRC | 01:49 | |
| *** aaronv has joined #zope3-dev | 01:57 | |
| *** dunny has joined #zope3-dev | 02:01 | |
| *** runyaga has quit IRC | 02:13 | |
| *** aaronv has quit IRC | 02:14 | |
| *** tarek has quit IRC | 02:33 | |
| *** fcorrea has quit IRC | 02:35 | |
| *** mcdonc has joined #zope3-dev | 02:38 | |
| *** aaronv has joined #zope3-dev | 02:54 | |
| *** matthal has joined #zope3-dev | 03:02 | |
| *** ccomb has quit IRC | 03:16 | |
| *** jan_s has joined #zope3-dev | 03:31 | |
| *** aclark has left #zope3-dev | 03:33 | |
| *** r0ver has left #zope3-dev | 04:13 | |
| *** aaronv has quit IRC | 05:06 | |
| *** cbcunc has quit IRC | 05:12 | |
| *** romanofski has joined #zope3-dev | 05:43 | |
| *** redir has quit IRC | 05:48 | |
| *** huajie has joined #zope3-dev | 06:01 | |
| *** TresEquis has joined #zope3-dev | 06:35 | |
| TresEquis | http://wiki.zope.org/bluebream/BugDay20100424 | 06:39 |
| *** kursor has joined #zope3-dev | 06:47 | |
| *** jfkw has quit IRC | 06:55 | |
| *** davisagli has joined #zope3-dev | 07:30 | |
| *** romanofski has quit IRC | 07:46 | |
| *** redir has joined #zope3-dev | 07:46 | |
| *** redir has quit IRC | 07:46 | |
| *** redir has joined #zope3-dev | 07:47 | |
| *** davisagli has quit IRC | 07:49 | |
| *** kursor has quit IRC | 08:23 | |
| *** afd_ has joined #zope3-dev | 08:53 | |
| *** afd___ has quit IRC | 08:57 | |
| *** romanofski has joined #zope3-dev | 08:59 | |
| *** agroszer has joined #zope3-dev | 09:26 | |
| *** matthal has quit IRC | 09:38 | |
| *** matthal has joined #zope3-dev | 09:45 | |
| *** matthal has quit IRC | 09:59 | |
| *** Theuni1 has joined #zope3-dev | 10:15 | |
| Theuni1 | morning | 10:18 |
| *** matthal has joined #zope3-dev | 10:19 | |
| *** JaRoel|4D has quit IRC | 10:21 | |
| *** matthal has quit IRC | 10:34 | |
| *** agroszer has quit IRC | 10:34 | |
| *** agroszer has joined #zope3-dev | 10:38 | |
| *** zagy has quit IRC | 10:44 | |
| *** andreypopp has joined #zope3-dev | 10:44 | |
| *** tarek has joined #zope3-dev | 10:51 | |
| agroszer | hmmmm.... I get failures with KGS3.4.0, even with virtualenv | 10:57 |
| *** andreypopp has quit IRC | 11:03 | |
| *** andreypopp has joined #zope3-dev | 11:04 | |
| *** redir has quit IRC | 11:06 | |
| *** matthal has joined #zope3-dev | 11:14 | |
| romanofski | moin Theuni1 | 11:16 |
| * Theuni1 waves romanofski | 11:20 | |
| Theuni1 | romanofski: bugfixing? :) | 11:20 |
| *** ccomb has joined #zope3-dev | 11:20 | |
| romanofski | Theuni1: ow... bugfix day today? | 11:21 |
| Theuni1 | jop | 11:21 |
| romanofski | hm.. do you have the URL to the list by hand? | 11:21 |
| Theuni1 | here's the wiki page | 11:22 |
| Theuni1 | http://wiki.zope.org/bluebream/BugDay20100424 | 11:22 |
| Theuni1 | it has a link to the bug list | 11:22 |
| romanofski | cheers | 11:22 |
| romanofski | hm... "can't set XUL content-type"... *G | 11:23 |
| Theuni1 | hahaha | 11:23 |
| Theuni1 | memories :) | 11:23 |
| * romanofski nods | 11:24 | |
| romanofski | Theuni1: I'm happy to help... | 11:24 |
| * romanofski is browsing | 11:24 | |
| *** sweh has joined #zope3-dev | 11:24 | |
| romanofski | Theuni1: it looks like there are already patches for the most? | 11:25 |
| romanofski | howdy sweh | 11:25 |
| Theuni1 | yeah | 11:26 |
| Theuni1 | still need to review them, though. | 11:26 |
| romanofski | sure | 11:26 |
| sweh | hi roman | 11:27 |
| sweh | how're u down under? | 11:28 |
| *** andreypopp has quit IRC | 11:29 | |
| romanofski | good good... just got hooked by Theuni1 for the bug day | 11:29 |
| romanofski | how about yourself? | 11:30 |
| Theuni1 | sweh: so what about you? you can fix one tiny bug, too! :) | 11:30 |
| Theuni1 | (and maybe another one, and then a tiny other one, and ...) | 11:30 |
| sweh | hm, sure I can, but did you look out if the window? | 11:31 |
| Theuni1 | yeah | 11:31 |
| Theuni1 | sun, fresh air and the awful noise of birds are the computer scientists arch enemies | 11:31 |
| sweh | by the way, my daily bug days start on monday and end on friday :P | 11:31 |
| Theuni1 | i'm talking about fixing bugs, not putting them in, thank you. ;) | 11:32 |
| sweh | lol :) | 11:32 |
| romanofski | Theuni1: send your employees to the east - they would now have no excuse because it'll be already dark outside ;) | 11:32 |
| Theuni1 | hehe | 11:33 |
| Theuni1 | cool | 11:33 |
| * Theuni1 got a checkin for revision 111333 | 11:33 | |
| romanofski | sweh: sounds like spring finally kicks in? | 11:34 |
| Theuni1 | it does :) | 11:34 |
| sweh | roman: indeed | 11:34 |
| sweh | Theuni: I've got a date with my family today, so unfortunately no time for fixing bugs | 11:35 |
| * sweh was just looking for some news while having breakfast | 11:36 | |
| * ccomb up | 11:40 | |
| romanofski | Theuni1: what should I do if .... let's say I'd like to pick #159467 (zope.testrunner should only profile actual tests, not setup) - checkout, check if the patch is working and commit? | 11:40 |
| Theuni1 | this sounds like it might have been fixed already, actually | 11:43 |
| Theuni1 | at least the patch won't work anymore because the test runner got heavily restructured after that patch | 11:43 |
| Theuni1 | you might want to check out zope.testing.testrunner and look at the pipeline i built there | 11:43 |
| romanofski | yeah - does that already count as a bugfix? | 11:43 |
| Theuni1 | IMHO the profiling plugin should be stopped/started before and after the test runs | 11:43 |
| Theuni1 | if it does, then I'd say this was fixed already | 11:43 |
| *** sweh has quit IRC | 11:44 | |
| romanofski | svn.zope.org? | 11:44 |
| romanofski | I probably have too old information - my pointer to the zope root is still: svn+ssh://romanofski@svn.zope.org/repos/main/ | 11:45 |
| ccomb | /me looking at #227617 | 11:46 |
| *** andreypopp has joined #zope3-dev | 11:47 | |
| Theuni1 | sounds good to me | 11:51 |
| romanofski | if it's zope.testrunner then I've found the module | 11:51 |
| Theuni1 | romanofski: the command should be 'svn co svn+ssh://svn.zope.org.repos/main/zope.testing/trunk zpoe.testing" | 11:51 |
| Theuni1 | ccomb: cool | 11:52 |
| romanofski | darn | 11:52 |
| Theuni1 | romanofski: your user account seems fine | 11:53 |
| Theuni1 | agroszer: is zope 3.4.1 getting mechanize 0.1.8 in there? | 11:53 |
| romanofski | Theuni1: yes - I checked... can still do a checkout *phew | 11:54 |
| agroszer | Theuni1, nope, 0.1.7b or? | 11:54 |
| Theuni1 | agroszer: that seems to break under python 2.5 | 11:54 |
| Theuni1 | File "/home/ctheune/.buildout/eggs/mechanize-0.1.7b-py2.6.egg/mechanize/_urllib2.py", line 3, in <module> | 11:54 |
| Theuni1 | from urllib2 import \ | 11:54 |
| Theuni1 | ImportError: cannot import name GopherError | 11:54 |
| agroszer | nice | 11:55 |
| agroszer | I'll take a look -- once I get there | 11:56 |
| Theuni1 | sure | 11:56 |
| agroszer | there are a bunch of other breakages | 11:56 |
| Theuni1 | i'm trying to fix an apidoc bug | 11:56 |
| Theuni1 | and i can't reproduce with 3.4.0 KGS | 11:56 |
| *** baijum has joined #zope3-dev | 11:57 | |
| ccomb | first I'm importing the two files maintaining-software and releasing-software from philikon's sandbox into the developer doc | 11:57 |
| Theuni1 | ccomb: there's another place | 11:58 |
| Theuni1 | ccomb: there's the ZTK documentation where I mirrored those docs already | 11:58 |
| ccomb | where? | 11:58 |
| Theuni1 | if you want to move them, you might wanna extract them from there | 11:58 |
| ccomb | ah ok | 11:58 |
| Theuni1 | so they can live in the developer doc and ZTK docs would only mention them | 11:58 |
| Theuni1 | (somebody was talking about an inter-sphinx installation which might help with those kinds of reference, but i don't know about that and i think it's not relevent yet) | 11:59 |
| ccomb | bb needs also that for the "what's new" section | 11:59 |
| agroszer | Theuni1, I'm wondering a bit about mechanize, cause I'm testing the KGS with py2.5 and that exception does not come up | 12:00 |
| * Theuni1 scratches his head | 12:00 | |
| Theuni1 | happened to me using zopeproject | 12:00 |
| Theuni1 | ouch | 12:00 |
| agroszer | Theuni1, you're using py2.6 | 12:00 |
| Theuni1 | that's python2.6 | 12:00 |
| *** afd_ has quit IRC | 12:01 | |
| Theuni1 | my bad | 12:01 |
| agroszer | yup | 12:01 |
| agroszer | nm | 12:01 |
| * Theuni1 scraps his virtualenv | 12:01 | |
| *** afd_ has joined #zope3-dev | 12:01 | |
| *** allisterb has quit IRC | 12:04 | |
| romanofski | *narf - the tests for zope.testing take quite some time | 12:10 |
| Theuni1 | yes they do | 12:17 |
| *** allisterb has joined #zope3-dev | 12:17 | |
| * Theuni1 wades through the remaining bugs with patches in Zope 3 | 12:17 | |
| romanofski | Theuni1: I just tried to run a few tests (limiting with -t) and it appears to me that the profiler is started and stopped before the layer setup and after the tearDown of the layers | 12:19 |
| romanofski | seems that the bug has been already fixed by the refactoring | 12:19 |
| Theuni1 | nope | 12:19 |
| Theuni1 | that's too coarse if you look closely | 12:20 |
| Theuni1 | it shouldn't be done on layer setup/teardown but on a test level | 12:20 |
| Theuni1 | otherwise the individual tests' setup and teardown will be profiled as well | 12:20 |
| Theuni1 | OTOH i don't know whether the test runner even has a look for that | 12:20 |
| Theuni1 | try checking the API of the test runner plugins whether they have something on a per-test level | 12:21 |
| *** huajie has quit IRC | 12:21 | |
| * romanofski tries to find the API for the plug-ins | 12:21 | |
| Theuni1 | well, OTOH the bug is talking about avoiding layer setu | 12:22 |
| Theuni1 | setup | 12:22 |
| Theuni1 | so that seems to have been fixed | 12:22 |
| Theuni1 | i'd say if you find a way to also avoid individual tests' setup/teardown try to do that, otherwise report the bug as fixed | 12:22 |
| romanofski | hm | 12:24 |
| romanofski | ah ok... found the whole kit and caboodle | 12:25 |
| Theuni1 | :) | 12:25 |
| *** projekt01 has joined #zope3-dev | 12:33 | |
| ccomb | I'm converting most namechooser doctests into unittests, leaving just a short informative docstring | 12:33 |
| *** JaRoel|4D has joined #zope3-dev | 12:33 | |
| lisppaste6 | agroszer pasted "z3c.layer" at http://paste.lisp.org/display/98267 | 12:33 |
| agroszer | ccomb, can you take a look at the above paste? | 12:34 |
| *** Theuni1 has quit IRC | 12:34 | |
| agroszer | which package might output that <h2>Unauthorized</h2> | 12:34 |
| agroszer | hallo projekt01 | 12:36 |
| projekt01 | agroszer, Hallo | 12:36 |
| projekt01 | agroszer, the paste bin shows z3c.layer, that's wvery old stuff | 12:37 |
| agroszer | yah I know | 12:37 |
| agroszer | I want to get a KGS3.4.1 | 12:37 |
| ccomb | maybe the string comes from a po file? | 12:38 |
| projekt01 | are you using both z3c.layer and z3c.layer.* packages in KGS? | 12:38 |
| projekt01 | ccomb, or from the layout template | 12:38 |
| agroszer | brb | 12:39 |
| projekt01 | probably it comes from the layout template showing that some parts are comming from layout and others from pagelet content | 12:39 |
| *** astoon has joined #zope3-dev | 12:43 | |
| *** Theuni1 has joined #zope3-dev | 12:49 | |
| *** JaRoel|4D has quit IRC | 12:52 | |
| romanofski | Theuni1: looks like I was wrong - the profiler profiles the layer setup | 12:53 |
| Theuni1 | meep :) | 12:53 |
| romanofski | Theuni1: looks like hotshot can't be enabled, disabled more than once and create a cumulative result :( | 13:01 |
| Theuni1 | romanofski: can you give me the bug URL again? | 13:02 |
| Theuni1 | There was a patch attached and I wonder how that worked. | 13:02 |
| romanofski | https://bugs.launchpad.net/zope.testing/+bug/159467 | 13:03 |
| romanofski | before_tests and after_tests | 13:03 |
| romanofski | early_teardown is already used | 13:04 |
| romanofski | which seems to be correct | 13:04 |
| Theuni1 | hmm | 13:04 |
| romanofski | but late_setup is before the layers are setup | 13:04 |
| Theuni1 | now i'm getting confused | 13:04 |
| Theuni1 | that means that we're already enabling/disabling the profile anyway | 13:05 |
| *** baijum has quit IRC | 13:05 | |
| romanofski | the profiler is enabled before the layers are setup and stopped after all tests | 13:06 |
| Theuni1 | so we're only calling it once | 13:07 |
| romanofski | what do you mean by that? | 13:07 |
| Theuni1 | i'm trying to figure out two things: | 13:07 |
| Theuni1 | are we calling enable/disable once or multiple times? | 13:08 |
| romanofski | once IMHO | 13:08 |
| Theuni1 | hmm | 13:08 |
| romanofski | I tried to do that multiple times and IMHO doesn't work | 13:08 |
| romanofski | could be, that I did it wrong tho | 13:08 |
| Theuni1 | Then I'd say ask the reporter of the bug about that. | 13:08 |
| romanofski | but I don't think so | 13:08 |
| Theuni1 | I don't think it's all that important WRT profiling, because profiling the setup code doesn't actually distort timing of the code under test anyway. | 13:09 |
| Theuni1 | It just makes everything run slower. | 13:09 |
| romanofski | I'll attach a comment | 13:09 |
| Theuni1 | I've set the importance to low. Can you write the comment and set the status to incomplete? | 13:10 |
| romanofski | sure | 13:10 |
| Theuni1 | thanks! | 13:10 |
| romanofski | easy | 13:11 |
| Theuni1 | took a while to figure out, though | 13:11 |
| romanofski | yeh.. I had to find the lines where the testrunner sets everything up | 13:13 |
| *** regebro has joined #zope3-dev | 13:17 | |
| *** JaRoel|4D has joined #zope3-dev | 13:18 | |
| *** matthal has quit IRC | 13:19 | |
| * Theuni1 ponders some food | 13:20 | |
| romanofski | Theuni1: either I don't have the permission or I can't see the form to set the bug as incomplete | 13:21 |
| romanofski | food... good call - there is already food on the table: late dinner today | 13:22 |
| Theuni1 | romanofski: try again | 13:22 |
| Theuni1 | there's still issues with the group management and the bug tracking on LP | 13:22 |
| Theuni1 | i've added you to the group you need, but we'll have to clean that situation up later | 13:22 |
| romanofski | still can't find the button/link whatever | 13:23 |
| Theuni1 | humm | 13:23 |
| Theuni1 | did you try reloading the page? | 13:23 |
| Theuni1 | i also set you as the assignee for now | 13:23 |
| romanofski | yeh - two times | 13:23 |
| Theuni1 | screw it | 13:24 |
| Theuni1 | i've set it to incomplete for ya | 13:24 |
| romanofski | cheers | 13:25 |
| *** ignas has quit IRC | 13:26 | |
| romanofski | if I've time after dinner/evening movie I'll squish another bug | 13:27 |
| Theuni1 | cool | 13:27 |
| Theuni1 | i'll be around for another 2.5 hours if you need me | 13:27 |
| Theuni1 | TresEquis should come in later to take over :) | 13:27 |
| * Theuni1 creates LP projects like crazy | 13:27 | |
| romanofski | is it only today or does it include tomorrow as well? | 13:29 |
| Theuni1 | only today | 13:30 |
| Theuni1 | but nobody will stop you if you want to fix bugs tomorrow, too ;) | 13:31 |
| romanofski | let's see - maybe there is time... depending on the weather | 13:31 |
| * Theuni1 keeps forgetting his lunch :/ | 13:32 | |
| *** JaRoel|4D has quit IRC | 13:43 | |
| *** aaronv has joined #zope3-dev | 13:47 | |
| Theuni1 | w00t | 13:48 |
| Theuni1 | all bugs that were registered with zope 3 and had patches are either triaged or fixed now | 13:49 |
| *** yota has joined #zope3-dev | 13:53 | |
| Theuni1 | now really some food and then some actual fixing. | 13:56 |
| Theuni1 | I'll be back in 30 minutes in case someone needs me as a guide. | 13:56 |
| ccomb | is it ok for the namechooser to return something even if we give it an int or None or anything? | 14:00 |
| ccomb | as a name | 14:00 |
| ccomb | I'm replacing | 14:01 |
| ccomb | name = unicode(name.replace('/', '-').lstrip('+@')) | 14:01 |
| ccomb | with | 14:01 |
| ccomb | name = unicode(name).replace('/', '-').lstrip('+@') | 14:01 |
| ccomb | so that it works with None as a name | 14:01 |
| agroszer | gaaah, zope.app.zapi breaks z3c.layer tests | 14:12 |
| Theuni1 | ccomb: what does the interface say? | 14:14 |
| Theuni1 | re | 14:14 |
| *** astoon has quit IRC | 14:14 | |
| ccomb | Theuni1: that chooseName should never raise an error | 14:14 |
| ccomb | I'm adding many unittests | 14:15 |
| ccomb | also replacing '.' with os.path.extsep | 14:15 |
| ccomb | and checking the type before the value in checkName | 14:15 |
| *** JaRoel|4D has joined #zope3-dev | 14:17 | |
| Theuni1 | ccomb: i wouldn't do the extsep | 14:17 |
| Theuni1 | we're talking about URIs which should be generated independently on where the server is running | 14:18 |
| Theuni1 | otherwise semantics of your application may change when you move the server between OSes | 14:18 |
| Theuni1 | which is exactly the opposite of cross platform ;) | 14:18 |
| Theuni1 | i would be careful about the unicode thing | 14:19 |
| Theuni1 | converting anything to unicode may raise an error | 14:19 |
| Theuni1 | you might want to protect it like this: | 14:19 |
| Theuni1 | try: | 14:19 |
| Theuni1 | name = unicode(name) | 14:19 |
| Theuni1 | except UnicodeDecodeError: | 14:19 |
| Theuni1 | name = '' | 14:19 |
| Theuni1 | name = ...replacements here | 14:19 |
| ccomb | ok for unicode | 14:20 |
| Theuni1 | the most important thing IMHO is that the assumption about chooseName never breaking holds | 14:20 |
| Theuni1 | as the interface tells the name only *may* be taken into account | 14:20 |
| Theuni1 | and we can try hard by converting ints etc. into strings, but we need to also be failsafe | 14:20 |
| agroszer | a string can be converted by omitting bad characters | 14:21 |
| agroszer | better try that too first before setting name = '' | 14:21 |
| Theuni1 | agroszer: fine with that | 14:21 |
| agroszer | name = '' seems pretty rude, huh? | 14:22 |
| ccomb | for the extsep thing, it is only used to keep the extension in case the name already exists | 14:22 |
| ccomb | 'foobar.rst' -> foobar-2.rst' | 14:22 |
| ccomb | instead of 'foobar.rst-2' which would break mimetype detection | 14:22 |
| ccomb | so I thing detecting the separator is better with os.path.extsep | 14:23 |
| Theuni1 | for that to work perfectly you would need to know the platform of the person who uploaded the file | 14:23 |
| Theuni1 | not the platform of the server | 14:23 |
| ccomb | mmmh right | 14:23 |
| Theuni1 | and i think sticking to '.' will be fine :) | 14:23 |
| agroszer | what does the mac use? | 14:23 |
| Theuni1 | i bet its '.' on almost all platforms, but the API doesn't guarantee that to you | 14:24 |
| Theuni1 | the formally correct thing would be to use the clients notion of the separation but we can't have that | 14:24 |
| Theuni1 | using the server's is definitely formally wrong. so i reaaaaaaaaally think '.' is the way to go. ;) | 14:25 |
| ccomb | ok I'm sticking with '.' | 14:25 |
| Theuni1 | hooray :) | 14:25 |
| ccomb | :P | 14:25 |
| Theuni1 | ;) | 14:25 |
| * Theuni1 picks another bug | 14:26 | |
| *** TresEquis has quit IRC | 14:28 | |
| *** JaRoel|4D has quit IRC | 14:29 | |
| *** TresEquis has joined #zope3-dev | 14:32 | |
| *** redir has joined #zope3-dev | 14:38 | |
| Theuni1 | looks like i found myself a rat hole | 14:43 |
| agroszer | which one? | 14:45 |
| Theuni1 | https://bugs.edge.launchpad.net/zope.testbrowser/+bug/98437 | 14:46 |
| agroszer | ouh that one | 14:46 |
| agroszer | I think I've seen even a patch for that | 14:47 |
| agroszer | but the patch was for Clientform | 14:47 |
| agroszer | Theuni1, I think we need to enforce dumping egg versions for tags | 14:52 |
| Theuni1 | humm? | 14:52 |
| agroszer | my problem is that I try to test a package on a tag | 14:53 |
| agroszer | and I have no idea whether to take the KGS3.4.0 or which pacakge versions | 14:53 |
| agroszer | cause it just fails | 14:53 |
| agroszer | with various problems | 14:53 |
| Theuni1 | yeah, i think we should discuss that on the list or in the meeting | 14:54 |
| Theuni1 | i've had a similar point earlier | 14:54 |
| agroszer | and if you want to release a next minor, you'll want your tests to pass | 14:54 |
| agroszer | baaah | 14:54 |
| *** alga has joined #zope3-dev | 14:55 | |
| agroszer | and on top of that I need zc.buildout 1.3.1, gaaah | 14:56 |
| *** JaRoel|4D has joined #zope3-dev | 14:59 | |
| *** JaRoel|4D has quit IRC | 15:04 | |
| Theuni1 | what are you up to? :) | 15:04 |
| agroszer | still fighting with the KGS | 15:05 |
| agroszer | z3c.layer 0.2.4 breaks z3c.formdemo | 15:05 |
| ccomb | agroszer: this is security fix that should break most applications. there is a warning about this already | 15:06 |
| agroszer | yes, now I'm trying to figure how to solve it in z3c.formdemo | 15:07 |
| ccomb | probably by adding more security registrations | 15:07 |
| agroszer | ccomb, weird is: | 15:08 |
| agroszer | <grantAll role="zope.Anonymous" /> | 15:08 |
| agroszer | so everyone ought to be a superuser | 15:09 |
| Theuni1 | no everyone | 15:09 |
| Theuni1 | only anonymous | 15:09 |
| Theuni1 | doesn't apply to authenticated | 15:09 |
| Theuni1 | there's a separate "everyone" | 15:09 |
| agroszer | and z3c.formdemo runs without auth | 15:09 |
| agroszer | views are registered for IContainer | 15:10 |
| agroszer | and I get | 15:11 |
| *** Charlie_X has joined #zope3-dev | 15:11 | |
| agroszer | ForbiddenAttribute: ('__getitem__', <zope.app.folder.folder.Folder object at 0xa88492c>) | 15:11 |
| *** astoon has joined #zope3-dev | 15:11 | |
| * Charlie_X waves | 15:11 | |
| * Theuni1 stares at the list of packages zope.testbrowser requires | 15:11 | |
| * Charlie_X offers Theuni1 some eyedrops and aspirin | 15:11 | |
| Theuni1 | thanks | 15:12 |
| * Charlie_X has just correctly built Python 2.7 from MacPorts. | 15:12 | |
| agroszer | Theuni1: | 15:13 |
| agroszer | The security policy defines a special role named "zope.Anonymous". All | 15:13 |
| agroszer | principals have this role and the role cannot be taken away. | 15:13 |
| agroszer | still does not apply to everyone? | 15:13 |
| Theuni1 | interesting | 15:15 |
| Theuni1 | ah | 15:15 |
| Theuni1 | role | 15:15 |
| Theuni1 | i think there's separate definitions of roles and groups | 15:15 |
| Theuni1 | I guess what I said applies to the groups not the groups. | 15:16 |
| Theuni1 | not the roles | 15:16 |
| agroszer | nm | 15:16 |
| Theuni1 | something is broken for me grrr | 15:16 |
| Theuni1 | zope.app.testing doesn't sucessfully complete tests when run on python 2.4 | 15:16 |
| *** JaRoel|4D has joined #zope3-dev | 15:17 | |
| Charlie_X | I removed Python 2.4 from my system this week. It's broken on OS X 10.6 and since Zope 2.12 I haven't needed it for anything. | 15:18 |
| *** alga has quit IRC | 15:18 | |
| * ccomb wonders whether a bugfix in 3.11 should be backported in 3.10, 3.9, 3.8, 3.7, 3.6, and 3.5 | 15:19 | |
| * ccomb feels the pain | 15:20 | |
| ccomb | do we really need releasing so many major versions? | 15:20 |
| Theuni1 | ccomb: i don't care too much about fine-grained backporting | 15:20 |
| agroszer | I guess if someone needs it he'll backport | 15:21 |
| ccomb | I'll probably backport at lest in the KGS 3.4 branch | 15:21 |
| Theuni1 | yeah | 15:21 |
| agroszer | that would be great | 15:21 |
| *** redir has quit IRC | 15:24 | |
| *** huajie has joined #zope3-dev | 15:32 | |
| *** TresEquis has quit IRC | 15:38 | |
| *** TresEquis has joined #zope3-dev | 15:39 | |
| ccomb | the KGS 3.4.1 really needs buildout 1.3.1 | 15:40 |
| ccomb | I cannot run tests on zope.app.container without it | 15:40 |
| agroszer | hmmmm, if a user does not have perm to __getitem__ ona folder, then he also cannot get a view on the folder?? | 15:41 |
| agroszer | ccomb, you're right | 15:41 |
| Charlie_X | I'm wondering how to go about applying, testing and publishing a patch for zope.structured I made a few years ago. Tres kindly reassigned the bug to me. | 15:41 |
| TresEquis | Charlie_X: check it out, boostrap the buildout, run bin/test --all | 15:42 |
| TresEquis | then try applying the patch | 15:42 |
| TresEquis | and re-run tests | 15:42 |
| agroszer | I'll file a bug | 15:42 |
| Charlie_X | Morning TresEquis | 15:43 |
| TresEquis | I'm gonna be gone to a jazz rehearsal for a couple of hours shortly | 15:44 |
| *** JaRoel|4D has quit IRC | 15:46 | |
| *** Charlie_X has quit IRC | 15:46 | |
| Theuni1 | TresEquis: if you have time later, i'd love if you could review my work on #98437 then | 15:47 |
| TresEquis | ok | 15:48 |
| *** Charlie_X has joined #zope3-dev | 15:48 | |
| TresEquis | I'm going to push the mechanize 2.0 changes to a branch | 15:48 |
| TresEquis | in case they step on your stuff | 15:48 |
| Theuni1 | k | 15:52 |
| Theuni1 | thanks | 15:52 |
| TresEquis | http://svn.zope.org/zope.testbrowser/branches/mechanize-0.2/ | 15:55 |
| TresEquis | Charlie_X: have you looked at the updated developer docs? | 15:56 |
| Charlie_X | Very briefly | 15:56 |
| Charlie_X | All tests pass after my patch. | 15:57 |
| Charlie_X | Making it conform to PEP 8 now | 16:00 |
| TresEquis | did your patch add any new tests for the issue? | 16:00 |
| agroszer | ccomb, you mind taking a look? | 16:03 |
| agroszer | svn+ssh://adamg@svn.zope.org/repos/main/z3c.formdemo/branches/adamg-1.5.4 | 16:03 |
| agroszer | svn+ssh://svn.zope.org/repos/main/z3c.formdemo/branches/adamg-1.5.4 | 16:03 |
| agroszer | I don't get this | 16:03 |
| agroszer | zope.security.management.thread_local.interaction.checkPermission('zope.View',self.context) | 16:03 |
| agroszer | sais I have permission tothe root folder | 16:03 |
| agroszer | but self.context[name] still fails | 16:03 |
| agroszer | where self.context is the root folder | 16:04 |
| Charlie_X | TresEquis: my patch effectively doubles the number of tests. | 16:05 |
| ccomb | agroszer: is there a 3.4.1 versions.cfg somewhere? | 16:05 |
| agroszer | not yet | 16:06 |
| TresEquis | romanofski: I just made an LP project for zope.testrunner (Lennart's split out version) | 16:06 |
| *** jfkw has joined #zope3-dev | 16:06 | |
| TresEquis | and tagged you with lp:159467 on that project as well | 16:06 |
| agroszer | ccomb, as soon as I got all tests pass | 16:07 |
| romanofski | TresEquis: alright - I guess that's were any further patches should go in? | 16:08 |
| ccomb | is the zope.release trunk updated? | 16:08 |
| Theuni1 | TresEquis: i didn't finish the testbrowser part of #98437 but i changed zope.app.testing not setting any referer at all, just looking for an OK from you. | 16:08 |
| agroszer | 3.4.1 goes into branches/3.4, or? | 16:08 |
| Theuni1 | for testbrowser i need to do some more | 16:08 |
| Theuni1 | gotta run to catch up with my GF now | 16:09 |
| ccomb | yes 3.4 branch, I think the trunk is unuseful now | 16:09 |
| agroszer | 2 more failures and z3c.formdemo to go | 16:09 |
| TresEquis | Theuni1: I think it should be fine | 16:12 |
| TresEquis | ok | 16:13 |
| TresEquis | Charlie_X: I would go ahead and commit when you think its ready | 16:13 |
| *** andreypopp has quit IRC | 16:18 | |
| *** andreypopp has joined #zope3-dev | 16:19 | |
| *** andreypopp has quit IRC | 16:21 | |
| ccomb | agroszer: I have a 404 on mechanize with your branch | 16:35 |
| agroszer | hmmm | 16:35 |
| agroszer | look into the addresbook sample | 16:35 |
| agroszer | that should fail with ForbiddenAttribute | 16:36 |
| agroszer | , /z3c/formdemo/addressbook/README.txt", line 22, in README.txt | 16:36 |
| ccomb | I mean during the buildout | 16:38 |
| ccomb | sf.net | 16:38 |
| agroszer | nice | 16:39 |
| agroszer | I guess I have it in the buildout cache | 16:39 |
| agroszer | gaaaah | 16:42 |
| agroszer | seems like 0.1.7b was removed | 16:42 |
| agroszer | that sucks | 16:42 |
| agroszer | ccomb, I'll drop you the targz by mail | 16:43 |
| ccomb | I have 0.1.8 in my cache | 16:44 |
| *** allisterb has quit IRC | 16:44 | |
| ccomb | 8 failures with 0.1.8 | 16:45 |
| agroszer | same here with 0.1.7b | 16:46 |
| agroszer | each README.txt fails | 16:46 |
| agroszer | maybe I'll bump it in KGS 3.4.1 | 16:47 |
| ccomb | same with 0.1.7b, 8 failures | 16:48 |
| agroszer | right | 16:49 |
| ccomb | since 0.1.8 is there, probably it should be used instead, yes | 16:51 |
| agroszer | it just fails | 16:52 |
| agroszer | Traceback (most recent call last): | 16:52 |
| agroszer | File "/home/adi/.buildout/eggs/zope.testbrowser-3.4.2-py2.5.egg/zope/testbrowser/tests.py", line 22, in <module> | 16:52 |
| agroszer | from zope.testbrowser import browser | 16:52 |
| agroszer | File "/home/adi/.buildout/eggs/zope.testbrowser-3.4.2-py2.5.egg/zope/testbrowser/browser.py", line 22, in <module> | 16:52 |
| agroszer | import mechanize | 16:52 |
| agroszer | File "/home/adi/.buildout/eggs/mechanize-0.1.8-py2.5.egg/mechanize/__init__.py", line 122, in <module> | 16:52 |
| agroszer | ImportError: cannot import name Firefox3CookieJar | 16:52 |
| agroszer | (for me) | 16:52 |
| agroszer | I guess I'm missing sqlite3 | 16:54 |
| ccomb | ok I see the ForbiddenAttribute during traversal | 16:55 |
| agroszer | great | 16:55 |
| *** ignas has joined #zope3-dev | 16:56 | |
| *** allisterb has joined #zope3-dev | 17:01 | |
| *** fcorrea has joined #zope3-dev | 17:06 | |
| Charlie_X | Where are the translation files? I've made a tiny change for choice widgets and want to update the German translation. | 17:07 |
| agroszer | which package? | 17:07 |
| Charlie_X | zope.formlib | 17:07 |
| agroszer | I guess zope.app.locales | 17:08 |
| Charlie_X | ta | 17:10 |
| *** JaRoel|4D has joined #zope3-dev | 17:11 | |
| agroszer | ccomb, mechanize 0.1.9 is the solution | 17:13 |
| ccomb | something special ? | 17:14 |
| agroszer | just a workaround for Firefox3CookieJar | 17:14 |
| ccomb | ok | 17:14 |
| Charlie_X | How do I get the changed default ("no value" -> "nothing selected") into the locales? | 17:20 |
| agroszer | lookin... | 17:22 |
| ccomb | finished with zope[.app.].container | 17:23 |
| ccomb | no new release yet | 17:23 |
| agroszer | hahh, that was to blame? | 17:24 |
| agroszer | Charlie_X, honsetly: no idea | 17:25 |
| agroszer | I guess i18n was not maintained since 3.4.0 or earlier | 17:25 |
| agroszer | projekt01, you around? | 17:26 |
| projekt01 | yup | 17:26 |
| agroszer | could you do a py2.5 win32 zope.security? | 17:26 |
| agroszer | could you do a py2.5 win32 zope.security egg? | 17:27 |
| agroszer | could you do a py2.5 win32 zope.security 3.4.3 egg? | 17:27 |
| agroszer | I get it right slowly... | 17:27 |
| projekt01 | which version? | 17:27 |
| projekt01 | 3.4.3 | 17:27 |
| projekt01 | agroszer, but that's a very old one? | 17:28 |
| agroszer | yup | 17:29 |
| agroszer | still working on KGS3.4.1 | 17:29 |
| agroszer | it almost passes now on linux | 17:29 |
| agroszer | now I'm getting to windowze | 17:29 |
| projekt01 | agroszer, Ok done | 17:30 |
| agroszer | thx | 17:30 |
| projekt01 | let me know if you need more | 17:30 |
| *** alga has joined #zope3-dev | 17:34 | |
| *** lisppaste6 has quit IRC | 17:34 | |
| *** alga has quit IRC | 17:37 | |
| *** dunny has quit IRC | 17:39 | |
| *** hazmat has quit IRC | 17:42 | |
| *** huajie has quit IRC | 17:42 | |
| *** lisppaste6 has joined #zope3-dev | 17:51 | |
| *** baijum has joined #zope3-dev | 17:53 | |
| *** baijum has quit IRC | 17:59 | |
| *** JaRoel|4D has quit IRC | 18:03 | |
| ccomb | agroszer: if I just add a security declaration for zope.app.folder.folder.Folder, I fall down to 3 failures | 18:06 |
| agroszer | great | 18:06 |
| ccomb | does the trunk have the same problem? | 18:07 |
| agroszer | good q | 18:07 |
| agroszer | let me check | 18:07 |
| ccomb | I'm commiting to your bhancr | 18:09 |
| agroszer | gaaah trunk is even worse | 18:10 |
| agroszer | IOError: [Errno 2] No such file or directory: '/home/adi/.buildout/eggs/zope.app.securitypolicy-3.5.2-py2.5.egg/zope/app/securitypolicy/meta.zcml' | 18:11 |
| ccomb | ok now: | 18:11 |
| ccomb | ForbiddenAttribute: ('__annotations__', <zope.app.folder.folder.Folder object at 0x4d46c08>) | 18:11 |
| ccomb | alsmost the same | 18:12 |
| agroszer | I don't get this, if the user has all perms, why is this coming? | 18:12 |
| *** JaRoel|4D has joined #zope3-dev | 18:13 | |
| Charlie_X | I don't know anything about ForbiddenAttribute but it sounds like the sort of thing that "not even god should change". | 18:13 |
| *** bitmonk1 has joined #zope3-dev | 18:13 | |
| agroszer | it's a permission problem, but the user ought to have all permissions :-O | 18:14 |
| ccomb | Even if you have all the permission, a missing security declaration is *always* preventing from accessing the content | 18:14 |
| ccomb | If I remember | 18:14 |
| * bitmonk1 couldn't add himself to the bugday in wiki, but is interested in helping with bb/ztk. anyone looking at 98395? | 18:15 | |
| *** JaRoel|4D has quit IRC | 18:25 | |
| agroszer | bitmonk1, assign to yourself | 18:29 |
| *** alga has joined #zope3-dev | 18:29 | |
| bitmonk1 | i don't see the option, checking again .. | 18:30 |
| bitmonk1 | ah-ho. | 18:30 |
| bitmonk1 | got it. | 18:30 |
| Charlie_X | Launchpad's icons are not very intuitive | 18:30 |
| agroszer | :-D you need lots of karma | 18:30 |
| bitmonk1 | Charlie_X: an old coworker of mine is listed as being on the UI team, something tells me this particular bit of UI is him. :) | 18:30 |
| * bitmonk1 hides from the edwin | 18:31 | |
| Charlie_X | It's miles better than bugzilla but I had the same problem earlier. | 18:31 |
| bitmonk1 | oh yeah bugzilla pffth.. once you know it, this sort of ui is very concise, but it just doesn't reach out to you the first time around. now i know to click the diagonal exclamation point balloon next to 'unassigned' for an assignee popup. | 18:32 |
| agroszer | that's a pencil... ;-) | 18:33 |
| agroszer | isn't it? | 18:33 |
| *** alga has quit IRC | 18:33 | |
| *** astoon has quit IRC | 18:35 | |
| Charlie_X | I suppose it could be a pencil. But the yellow circle certainly makes an exclamation mark the most likely interpretation. | 18:35 |
| Charlie_X | I've always assumed it was a warning symbol. | 18:35 |
| bitmonk1 | pencil would explain the lean, as if being held by an obviously superior right-handed person [ *ducks* ] | 18:37 |
| ccomb | annotation adapters are not trusted? | 18:38 |
| *** Charlie_X has quit IRC | 18:39 | |
| bitmonk1 | i would expect any adapter to be trusted .. are you getting an error that implies your ask? | 18:39 |
| ccomb | I'm still trying to make z3c.formdemo work | 18:40 |
| *** Charlie_X has joined #zope3-dev | 18:40 | |
| Charlie_X | Opera just went boom | 18:40 |
| * bitmonk1 just joined in the past hour | 18:41 | |
| ccomb | I don't like being forced to add a <require attributes="__annotations__" | 18:41 |
| agroszer | that's ugly | 18:42 |
| agroszer | something is wrong there | 18:42 |
| ccomb | sure | 18:42 |
| Theuni1 | TresEquis: there's a zope.app project group now | 18:45 |
| Theuni1 | in launchpad. i've put all zope.app projects that i found into it | 18:45 |
| *** Theuni1 has quit IRC | 18:51 | |
| *** ignas has quit IRC | 18:59 | |
| bitmonk1 | ccomb: talk it through, why do you have to do this? | 18:59 |
| Charlie_X | TresEquis: I committed both changes for the two bugs you tagged for me. I don't understand much of the other CMF bugs so I am continuing to work on Yuppie's CookieCrumbler branch. | 19:01 |
| ccomb | no I think it's just another missing declaration on an annotation adapter | 19:03 |
| bitmonk1 | ok :) | 19:03 |
| ccomb | tell me if I'm wrong, when using an annotation adapter, either you declare it as trusted, or you declare security for its interface | 19:03 |
| bitmonk1 | that is not a question i know the answer to, or obvious to me from a glance at annotation docs | 19:10 |
| *** redir has joined #zope3-dev | 19:10 | |
| *** astoon has joined #zope3-dev | 19:13 | |
| *** projekt01 has quit IRC | 19:13 | |
| TresEquis | ok, back from rehearsal | 19:22 |
| TresEquis | anybody still squishing crustaceans here? | 19:22 |
| TresEquis | arthropods, anyway | 19:22 |
| * bitmonk1 stomp | 19:24 | |
| bitmonk1 | in fact .. i think this patch is ready. | 19:24 |
| bitmonk1 | well, i'm unclear if the test needs to be further improved.. but still squishing away. :) | 19:26 |
| ccomb | just 1 more failure on formdemo | 19:30 |
| bitmonk1 | yah i need to test if this output is actually unicode, rather than just checking the content-type header's charset. hm. | 19:31 |
| TresEquis | ccomb: re https://bugs.launchpad.net/bugs/569408 | 19:35 |
| TresEquis | do you actually see the forbidden error propagating? | 19:35 |
| TresEquis | oops, that was agroszer, not ccomb | 19:35 |
| ccomb | TresEquis agroszer the view is asked without @@ | 19:37 |
| ccomb | I think if we directly ask for the view using @@, there is no permission denied | 19:38 |
| ccomb | the traverser first tries to getitem and then falls back to the view | 19:38 |
| TresEquis | ah, ok | 19:39 |
| TresEquis | and this is with spacesuits, right? | 19:39 |
| TresEquis | aka security proxies | 19:39 |
| TresEquis | which make __getitem__ raise the forbidden exception? | 19:39 |
| ccomb | yes | 19:39 |
| ccomb | I've tried replacing all the views with @@ in the template and it worked | 19:40 |
| TresEquis | I think a new unit test, with a dummy context whose __getitem__ raises the error, would be enough to add the fix | 19:40 |
| TresEquis | hmm | 19:40 |
| TresEquis | but this is a case where there *is* an item with the same name | 19:40 |
| TresEquis | as the view | 19:40 |
| TresEquis | or is __getitem__ raising the error unconditionally? | 19:41 |
| TresEquis | (which it probably shouldn't) | 19:41 |
| ccomb | you want the traverser to try the view even if it failed on getitem due to security? | 19:41 |
| TresEquis | that is what the bug report suggests | 19:41 |
| bitmonk1 | nope, the result itself is not unicode because it is the whole http response including the headers. dur. | 19:41 |
| TresEquis | I think it is generally true that templates should use 'context/@@view' to form URLs | 19:42 |
| TresEquis | when they know they want a view | 19:43 |
| TresEquis | I don't think that falling back to a same-name view is the right thing to do if there is an item with the same name, but the user isn't allowed to see it | 19:43 |
| ccomb | the last error on formdemo is an UnpickleableError: Cannot pickle <type 'zope.security._proxy._Proxy'> objects | 19:44 |
| TresEquis | the odd case is if __getitem__ is raising an exception without checking for the item | 19:44 |
| bitmonk1 | what is the $Id .. etc .. syntax in the docstrings? I | 19:47 |
| bitmonk1 | I'm familiar with it, but there's no googling $Id | 19:47 |
| * bitmonk1 ends up reading about freud | 19:48 | |
| *** fcorrea has quit IRC | 19:49 | |
| bitmonk1 | anyway 98395 has a patch with tests that first failed, and now pass. going to throw together some breakfast and pick up another / field feedback. :) | 19:49 |
| *** agroszer has quit IRC | 19:57 | |
| *** agroszer_ has joined #zope3-dev | 19:57 | |
| *** aaronv has quit IRC | 20:13 | |
| *** bitmonk has joined #zope3-dev | 20:14 | |
| * Charlie_X is eating liquorice - does that count? | 20:15 | |
| TresEquis | bitmonk1 it identifies the VCS version of the file | 20:19 |
| TresEquis | generally cruft | 20:19 |
| Charlie_X | eek! disposing of auto_login_page causes an error in GenericSetup's utils! :-( | 20:21 |
| Charlie_X | But only when CMFDefault's tests run... | 20:22 |
| Charlie_X | ah, it's a profile issue | 20:23 |
| bitmonk | TresEquis: sure i just, didn't know if i need to muck with it | 20:24 |
| bitmonk | looks like my patch needs a couple touches on review.. | 20:24 |
| TresEquis | Removing it would be "janitorial" | 20:25 |
| TresEquis | should normally not be done in same commit as "real" fixes | 20:25 |
| TresEquis | and might need to be deferred until all "old" patches have been reviewed / applied, like other janitorial cleanups | 20:25 |
| TresEquis | because they can cause spurious patch failures | 20:25 |
| *** fcorrea has joined #zope3-dev | 20:27 | |
| bitmonk | TresEquis: absolutely. | 20:28 |
| bitmonk | more like, i copied a file to a new one, to create a new test. apparently it's a non-issue. | 20:29 |
| TresEquis | in a new file, just zap it | 20:29 |
| TresEquis | fossil from CVS days, actually | 20:29 |
| ccomb | agroszer_: formdemo is ok | 20:34 |
| ccomb | agroszer_: I'm renaming adamg-1.5.4 to 1.5 | 20:39 |
| bitmonk | hokay i feel pretty comfortable with the patch for 98395, what status should i set this issue to. fix committed wouldn't be appropriate since i've only attached a patch and am not a committer. | 20:44 |
| bitmonk | confirmed? | 20:44 |
| Charlie_X | No, In progress makes more sense. | 20:46 |
| bitmonk | sure.. | 20:50 |
| TresEquis | bitmonk you can either upload the patch as an attachment, or push a bzr branch to launchpad | 20:54 |
| TresEquis | and ask me to review | 20:54 |
| bitmonk | sure the patch is attached, but .. bzr is fine. my patch is against svn trunk atm. | 20:55 |
| TresEquis | bzr is just an option | 20:55 |
| TresEquis | for getting your branch uploaded with maybe multiple discrete changes | 20:55 |
| TresEquis | but a patch is fine, too | 20:56 |
| bitmonk | sure.. i would actually prefer it, i didn't know there was vcs-import of zope stuff. sweet. | 20:56 |
| TresEquis | which package? | 20:56 |
| bitmonk | zope.publisher | 20:56 |
| TresEquis | $ bzr co lp:zope.publisher gets you the trunk | 20:56 |
| bitmonk | i am looking at the branches page now | 20:56 |
| TresEquis | $ bzr branch lp:zope.publisher | 20:57 |
| TresEquis | I mean | 20:57 |
| bitmonk | got it. | 20:57 |
| TresEquis | We can't push back to the branch, so checkout doesn't make sense | 20:57 |
| TresEquis | then you can do: | 20:57 |
| TresEquis | $ patch < your.patch | 20:58 |
| TresEquis | $ bzr commit --fixes lp:98395 | 20:58 |
| TresEquis | $ bzr push lp:~bitmonk/zope.publisher/lp_98395 | 20:58 |
| TresEquis | outlined on the shiny new "contributing as a non-committer using Bzr page" | 20:59 |
| TresEquis | http://docs.zope.org/developer/noncommitter-bzr.html | 20:59 |
| *** astoon has quit IRC | 21:00 | |
| bitmonk | suhweet. | 21:00 |
| * bitmonk is actually justizin on launchpad because .. bitmonk is linked to siggraph.org email or rackspace or who knows what of the past ;d | 21:01 | |
| bitmonk | but i get the point. | 21:01 |
| bitmonk | done and ready for review TresEquis | 21:04 |
| TresEquis | cool | 21:07 |
| *** jfkw has quit IRC | 21:08 | |
| TresEquis | OK, looks pretty good | 21:12 |
| TresEquis | one nit is our 80 column fetish | 21:12 |
| TresEquis | but the extra tests look to exercise the new functionality fully | 21:12 |
| * bitmonk never knows what to do about 80 columns when others are involved ;d | 21:13 | |
| TresEquis | There's docs for that ;) http://docs.zope.org/developer/development-culture.html#coding-standards | 21:14 |
| TresEquis | I tried to get most of our current practice into those docs | 21:14 |
| TresEquis | the bzr stuff is pretty much speculative: you're the first actual non-committer to try them out | 21:15 |
| TresEquis | for which I'm grateful ;) | 21:15 |
| TresEquis | I can fix those before pushing to SVN | 21:15 |
| TresEquis | ah, another fix: needs to update CHANGES.txt | 21:15 |
| bitmonk | The docstring should contain a reference about version control status. The example given is valid for at least CVS and Subversion. <- the example is "$Id$", this is the thing i ripped out. just noting. | 21:16 |
| bitmonk | i'm happy to do both. | 21:16 |
| bitmonk | on http://docs.zope.org/zopetoolkit/codingstyle/python-style.html that is | 21:16 |
| TresEquis | hmm, I don't see that in the patch | 21:16 |
| bitmonk | sorry, segway | 21:16 |
| bitmonk | segue | 21:16 |
| TresEquis | ah, ok | 21:16 |
| TresEquis | sure | 21:17 |
| TresEquis | changes to those docs need to be run by the ZTK steering group (of which I'm a member) | 21:17 |
| TresEquis | but I would be in favor of dropping the $Id$ fossil | 21:17 |
| bitmonk | fair enough, just pointing out since we discussed it so you'd be aware. | 21:21 |
| *** astoon has joined #zope3-dev | 21:21 | |
| * bitmonk observe what appears to be an 86 column fetish :-P | 21:25 | |
| bitmonk | pushed TresEquis with CHANGES.txt entries and multilined the error message to fit in 80 columns. | 21:29 |
| bitmonk | er, entry. | 21:29 |
| bitmonk | also happy to help try out the bzr non-committer access. super duper handy. | 21:30 |
| *** shen-long has joined #zope3-dev | 21:30 | |
| TresEquis | ah, I jumped the gone and tidied the long lines -- looks like there were some pre-existing fouls, too | 21:32 |
| TresEquis | your branch is now merged to the SVN trunk | 21:32 |
| bitmonk | sweet. picking through what remain in lp. | 21:32 |
| TresEquis | 209550 is another zope.publisher one with a patch | 21:35 |
| * bitmonk takes a look | 21:37 | |
| bitmonk | ah i was in fact just looking at this.. | 21:38 |
| *** fcorrea has quit IRC | 21:41 | |
| *** jfkw has joined #zope3-dev | 21:42 | |
| bitmonk | alright well that patch doesn't apply cleanly so.. i'll work on that. :) | 21:46 |
| TresEquis | sounds good | 21:51 |
| TresEquis | BIAB -- daddy taxi duties call | 22:02 |
| bitmonk | going to assign myself, suck down to the netbook, and travel with it for a couple hours. :) | 22:02 |
| bitmonk | pretty straightforward just, picking through stuff by hand. the tests are what don't quite cleanly apply. | 22:03 |
| *** matthal has joined #zope3-dev | 22:06 | |
| *** bitmonk1 has quit IRC | 22:21 | |
| *** dunny has joined #zope3-dev | 22:30 | |
| bitmonk | alright i've actually got 209550 ready TresEquis, but the push to lp is hanging .. | 22:32 |
| bitmonk | thar she blows.. updating the ticket with a note it is ready for your review after taxi duties, TresEquis. | 22:37 |
| TresEquis | thanks, taxi back in the statnd | 22:42 |
| *** ignas has joined #zope3-dev | 22:43 | |
| *** agroszer_ has quit IRC | 22:45 | |
| Charlie_X | Right, I've added a logout view to Yuppie's branch. Still need to sort out the tests but things are looking good. | 23:01 |
| *** andreypopp has joined #zope3-dev | 23:04 | |
| Charlie_X | bitmonk: 80 characters is there for several reasons but the most cogent is your ability to read a lot of characters per line is limited. And line breaks don't hurt | 23:04 |
| *** matthal has quit IRC | 23:09 | |
| *** allisterb has quit IRC | 23:09 | |
| TresEquis | Charlie_X: more important is *other* people's ability to read the lines, particularly in the popular editors | 23:11 |
| *** matthal has joined #zope3-dev | 23:11 | |
| andreypopp | Hello, what is the status of https://bugs.launchpad.net/zope.schema/+bug/567520 ? | 23:14 |
| TresEquis | bitmonk: https://bugs.launchpad.net/zopetoolkit-project/+bug/569541 | 23:17 |
| *** alga has joined #zope3-dev | 23:17 | |
| TresEquis | andreypopp: nobody has tackled it yet | 23:18 |
| andreypopp | TresEquis: ok, it has patch with tests | 23:18 |
| TresEquis | cool | 23:19 |
| TresEquis | andreypopp: are you a Zope SVN committer? | 23:19 |
| andreypopp | no | 23:20 |
| *** JaRoel|4D has joined #zope3-dev | 23:21 | |
| andreypopp | the possible problem with this issue is it can break b/w | 23:22 |
| andreypopp | i don't really know | 23:22 |
| TresEquis | you have two attachments to the issue: does the second (the patch) include the first? | 23:22 |
| andreypopp | sthe first one is just test to show the bug, the second is fox with unit test | 23:23 |
| andreypopp | ignore the first one | 23:23 |
| TresEquis | great | 23:23 |
| andreypopp | fox = fix | 23:23 |
| *** afd_ has quit IRC | 23:24 | |
| *** allisterb has joined #zope3-dev | 23:25 | |
| TresEquis | andreypopp: why does the fix not just propagate the Invalid exception? | 23:30 |
| TresEquis | instead of wrapping it as a WrongContainedType exception? | 23:30 |
| andreypopp | is it not the policy for Object validation error to be wrapped in WrongContainedType? | 23:31 |
| andreypopp | This is how code that collects errors at top level can differentiate errors from fields | 23:32 |
| TresEquis | hmm | 23:32 |
| TresEquis | I may misunderstand | 23:33 |
| TresEquis | there is test code which wants WrongContainedType to be raised | 23:33 |
| TresEquis | the 'getErrors' bit | 23:33 |
| andreypopp | yes | 23:34 |
| *** ignas has quit IRC | 23:34 | |
| TresEquis | but other fields have _validate methods which raise different errors | 23:35 |
| andreypopp | this is because I do not propagate Invalie exc and wrap it in WrongContainedType | 23:35 |
| andreypopp | Ok, for example we use zope.schema.getValidationErrors, and have failed invariant check something deeper inside Object field… we cannot differentiate it by field | 23:36 |
| andreypopp | but if we wrap it inside WrongContainedType — we can | 23:37 |
| andreypopp | I think it is reasonable | 23:37 |
| andreypopp | TresEquis: sorry, I have to go, please update bug ticket if you reject or commit fix, ok? | 23:40 |
| TresEquis | ok | 23:41 |
| *** andreypopp has quit IRC | 23:41 | |
| TresEquis | Here is the set of tagged bugs resolved today in the ZTK: https://bugs.launchpad.net/zopetoolkit/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=INVALID&field.status%3Alist=WONTFIX&field.status%3Alist=FIXCOMMITTED&field.status%3Alist=FIXRELEASED&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.tag=bugday20100424&field.tags_combina | 23:52 |
| TresEquis | tor=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on | 23:52 |
| TresEquis | crap | 23:52 |
| TresEquis | http://bit.ly/afUs7x | 23:53 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!