*** avoinea has quit IRC | 00:04 | |
*** J1m has joined #zope | 00:05 | |
*** menesis has quit IRC | 00:14 | |
*** nande has joined #zope | 00:25 | |
*** moo-_- has quit IRC | 00:28 | |
*** moo-_- has joined #zope | 00:30 | |
*** alecm_ has joined #zope | 00:33 | |
*** kosh has joined #zope | 00:34 | |
*** alecm has quit IRC | 00:35 | |
*** alecm_ is now known as alecm | 00:35 | |
*** mindthief414 has quit IRC | 00:44 | |
*** mcdonc has quit IRC | 00:50 | |
*** mcdonc has joined #zope | 01:01 | |
*** m8 has quit IRC | 01:07 | |
*** paltas has quit IRC | 01:15 | |
*** mindthief414 has joined #zope | 01:52 | |
*** _mup_ has quit IRC | 02:00 | |
*** _mup_ has joined #zope | 02:00 | |
*** daMaestro has quit IRC | 02:02 | |
*** dayne has quit IRC | 02:03 | |
*** LeoRochael has quit IRC | 02:17 | |
*** fgs has quit IRC | 02:18 | |
*** fgs has joined #zope | 02:19 | |
*** J1m has quit IRC | 02:19 | |
*** RichyB has quit IRC | 02:34 | |
*** pumazi has joined #zope | 02:51 | |
*** tiwula has quit IRC | 02:57 | |
*** mcdonc has quit IRC | 03:10 | |
*** tiwula has joined #zope | 03:18 | |
*** nueces has quit IRC | 03:39 | |
*** nande has quit IRC | 03:49 | |
*** J1m has joined #zope | 04:25 | |
*** pumazi has left #zope | 04:26 | |
*** nande has joined #zope | 04:27 | |
*** J1m has quit IRC | 04:36 | |
*** benbangert has quit IRC | 04:55 | |
*** benbangert has joined #zope | 04:55 | |
*** fdrake has joined #zope | 05:15 | |
*** mindthief414 has quit IRC | 05:42 | |
*** kosh has quit IRC | 06:57 | |
*** __mac__ has joined #zope | 07:17 | |
*** __mac__ has quit IRC | 07:40 | |
*** zenwryly has quit IRC | 07:44 | |
*** __mac__ has joined #zope | 07:51 | |
*** tiwula has quit IRC | 07:58 | |
*** __mac__ has quit IRC | 08:05 | |
*** mitchell`off has quit IRC | 08:07 | |
*** mitchell` has joined #zope | 08:07 | |
*** zagy has joined #zope | 08:15 | |
*** zagy has quit IRC | 08:24 | |
*** mindthief414 has joined #zope | 08:26 | |
*** __mac__ has joined #zope | 08:31 | |
*** agroszer has joined #zope | 09:11 | |
*** tmog has joined #zope | 09:34 | |
*** zagy has joined #zope | 09:44 | |
*** avoinea has joined #zope | 09:45 | |
*** mindthief414 has quit IRC | 10:12 | |
*** menesis has joined #zope | 10:23 | |
*** giacomos has joined #zope | 10:24 | |
*** nande has quit IRC | 10:29 | |
*** thetet has joined #zope | 10:43 | |
*** goschtl has joined #zope | 10:50 | |
*** thetet has quit IRC | 11:38 | |
*** thetet has joined #zope | 11:40 | |
*** AdamDangoor has joined #zope | 11:43 | |
*** mwilkes|away is now known as MatthewWilkes | 11:55 | |
*** evilbungle has joined #zope | 11:58 | |
*** thetet has quit IRC | 12:04 | |
*** thetet has joined #zope | 12:04 | |
*** RichyB has joined #zope | 12:11 | |
*** moumoutt1 has joined #zope | 12:19 | |
*** yvl_ has joined #zope | 12:19 | |
*** gawel_ has joined #zope | 12:20 | |
*** goschtl has quit IRC | 12:20 | |
*** moumoutte has quit IRC | 12:20 | |
*** yvl has quit IRC | 12:20 | |
*** gawel has quit IRC | 12:20 | |
*** KageSenshi has quit IRC | 12:20 | |
*** KageSenshi has joined #zope | 12:20 | |
*** gawel_ is now known as gawel | 12:21 | |
*** fdrake has quit IRC | 12:45 | |
*** goschtl has joined #zope | 12:47 | |
*** nueces has joined #zope | 12:56 | |
*** __mac__ has quit IRC | 13:04 | |
*** __mac__ has joined #zope | 13:14 | |
mgedmin | any users of z3c.etestbrowser or zope.app.wsgi.testlayer? | 13:17 |
---|---|---|
*** eperez has joined #zope | 13:26 | |
*** giacomos has quit IRC | 13:48 | |
*** sp0cksbeard has joined #zope | 14:18 | |
*** nande has joined #zope | 14:45 | |
*** yvl_ has quit IRC | 15:05 | |
*** yvl has joined #zope | 15:05 | |
*** tmog has quit IRC | 15:08 | |
*** sunew has joined #zope | 15:08 | |
*** fdrake has joined #zope | 15:12 | |
*** maurits has joined #zope | 15:15 | |
*** maurits has quit IRC | 15:15 | |
*** maurits has joined #zope | 15:16 | |
*** giacomos has joined #zope | 15:16 | |
*** J1m has joined #zope | 15:17 | |
*** tmog has joined #zope | 15:26 | |
*** sunew has quit IRC | 15:44 | |
*** sunew has joined #zope | 15:49 | |
__mac__ | mgedmin: here | 15:51 |
__mac__ | mgedmin: at least z3c.etestbrowser on WSGI | 15:52 |
mgedmin | wsgi, exactly the thing I'm interested in | 15:52 |
mgedmin | zope.app.wsgi defines a BrowserLayer test layer | 15:52 |
mgedmin | it used to extend zope.testbrowser.wsgi.Layer | 15:52 |
mgedmin | but it doesn't any more since zope.app.wsgi 4.0.0a3 | 15:53 |
mgedmin | I discovered that this breaks z3c.etestbrowser's testsuite a bit | 15:53 |
mgedmin | and am wondering about other possible users | 15:53 |
*** sp0cksbeard has quit IRC | 15:54 | |
__mac__ | mgedmin: I'm only using z3c.etestbrowser.wsgi.ExtendedTestBrowser which does not need zope.app.wsgi | 15:56 |
mgedmin | yes, it needs zope.testbrowser.wsgi | 15:56 |
mgedmin | specifically, it needs zope.testbrowser.wsgi.Layer.get_app() | 15:57 |
mgedmin | or you have to pass your own wsgi_app explicitly to ExtendedTestBrowser(wsgi_app=...) | 15:57 |
*** sp0cksbeard has joined #zope | 15:57 | |
__mac__ | mgedmin: yes, I've seen it in the code | 15:57 |
mgedmin | zope.app.wsgi.testlayer.BrowserLayer used to install that global app | 15:57 |
mgedmin | now it doesn't any more | 15:57 |
mgedmin | and I'm wondering if anybody cares | 15:57 |
__mac__ | mgedmin: I think the module global _APP_UNDER_TEST was a bad idea, I'd be happy to get rid of it | 15:59 |
__mac__ | mgedmin: but witch test of z3c.etestbrowser needs this variable? | 16:00 |
mgedmin | wsgi.txt | 16:00 |
mgedmin | I fixed it in master, haven't pushed yet | 16:00 |
mgedmin | the test was dirt simple: set up a BrowserLayer using some ftesting.zcml, instantiate wsgi.ExtendedTestBrowser(), try to use it | 16:00 |
mgedmin | and relied on the global app | 16:01 |
mgedmin | I made it instantiate the app explicitly in doctest setUp and pass it to ExtendedTestBrowser(wsgi_app=...) | 16:01 |
*** tmog has quit IRC | 16:03 | |
__mac__ | mgedmin: I wondered not to see any changes on github | 16:03 |
*** tmog has joined #zope | 16:04 | |
mgedmin | I hadn't made up my mind whether the fix was correct, or if I should instead restore BBB in zope.app.wsgi | 16:04 |
__mac__ | mgedmin: I think the app could be stored on the layer, there is no need to have it module global, this way z3c.etestbrowser should not be affected | 16:05 |
mgedmin | I don't think a running test has access to its layer... | 16:06 |
*** thetet has quit IRC | 16:07 | |
__mac__ | mgedmin: the layer is stored on the test class, so self.layer can be used to access the Layer | 16:10 |
mgedmin | DocFileSuite() | 16:10 |
__mac__ | mgedmin: DocFileSuite can be instructed to push the layer into the globals of the test | 16:11 |
mgedmin | yes | 16:11 |
__mac__ | mgedmin: After looking a bit into zope.testbrowser.wsgi.Layer I've seen hat storing the WSGI app on the Layer is no solution because get_app is a classmethod, so having the app on the layer class or in the module makes no difference | 16:13 |
__mac__ | mgedmin: I suspect the whole layer and browser integration needs to be refactored or kept as it is | 16:14 |
*** sp0cksbeard has quit IRC | 16:41 | |
*** sp0cksbeard has joined #zope | 16:48 | |
*** kosh has joined #zope | 16:49 | |
*** sp0cksbeard has quit IRC | 16:50 | |
*** sp0cksbeard has joined #zope | 16:50 | |
*** daMaestro has joined #zope | 16:56 | |
*** __mac__ has quit IRC | 17:10 | |
*** zagy has quit IRC | 17:11 | |
*** __mac__ has joined #zope | 17:16 | |
*** mcdonc has joined #zope | 17:17 | |
*** calvinhp has joined #zope | 17:18 | |
*** mr_jolly has joined #zope | 17:20 | |
*** calvinhp_ has quit IRC | 17:21 | |
*** tiwula has joined #zope | 17:29 | |
*** mr_jolly has quit IRC | 17:29 | |
*** avoinea has quit IRC | 17:34 | |
*** mcdonc has quit IRC | 17:37 | |
*** dayne has joined #zope | 17:40 | |
*** goschtl has quit IRC | 17:41 | |
*** avoinea has joined #zope | 17:47 | |
*** mr_jolly has joined #zope | 17:51 | |
*** lane_ has joined #zope | 17:54 | |
*** __mac__ has quit IRC | 17:55 | |
*** zagy has joined #zope | 17:55 | |
*** supton has joined #zope | 17:56 | |
*** zagy has quit IRC | 17:57 | |
*** tiwula has quit IRC | 17:58 | |
*** lane__ has joined #zope | 17:59 | |
*** mr_jolly has quit IRC | 18:00 | |
*** lane_ has quit IRC | 18:03 | |
*** tmog has quit IRC | 18:03 | |
*** mr_jolly has joined #zope | 18:05 | |
*** sunew has quit IRC | 18:08 | |
*** RichyB has quit IRC | 18:13 | |
*** sunew has joined #zope | 18:17 | |
*** evilbungle has quit IRC | 18:22 | |
*** mr_jolly has quit IRC | 18:24 | |
*** sunew has quit IRC | 18:24 | |
*** RichyB has joined #zope | 18:26 | |
*** kosh has quit IRC | 18:26 | |
*** LeoRochael has joined #zope | 18:28 | |
*** __mac__ has joined #zope | 18:30 | |
*** mcdonc has joined #zope | 18:32 | |
*** mindthief414 has joined #zope | 18:33 | |
*** jham_ has joined #zope | 18:36 | |
*** jham has quit IRC | 18:36 | |
*** calvinhp has quit IRC | 18:36 | |
*** calvinhp has joined #zope | 18:37 | |
*** dayne has quit IRC | 18:40 | |
*** chaoflow has quit IRC | 18:42 | |
*** MrTango has joined #zope | 18:43 | |
*** agroszer has quit IRC | 18:44 | |
*** chaoflow has joined #zope | 18:50 | |
*** dayne has joined #zope | 18:56 | |
*** __mac__ has quit IRC | 19:01 | |
*** LeoRochael has quit IRC | 19:09 | |
*** giacomos has quit IRC | 19:10 | |
*** supton_ has joined #zope | 19:26 | |
*** supton has quit IRC | 19:29 | |
*** supton_ is now known as supton | 19:29 | |
*** maurits has quit IRC | 19:40 | |
*** nande has quit IRC | 19:44 | |
*** avoinea1 has joined #zope | 20:02 | |
*** avoinea1 has quit IRC | 20:03 | |
*** agroszer has joined #zope | 20:06 | |
*** AdamDangoor has quit IRC | 20:14 | |
*** lane__ has quit IRC | 20:15 | |
*** agroszer has quit IRC | 20:20 | |
*** eperez has quit IRC | 20:24 | |
*** MatthewWilkes is now known as mwilkes|away | 20:37 | |
*** m8 has joined #zope | 20:52 | |
*** kosh has joined #zope | 21:00 | |
*** tiwula has joined #zope | 21:11 | |
*** tiwula has quit IRC | 21:11 | |
*** tiwula has joined #zope | 21:14 | |
*** MrTango has quit IRC | 21:24 | |
*** __mac__ has joined #zope | 21:25 | |
*** Spanktar has joined #zope | 21:39 | |
*** sunew has joined #zope | 21:44 | |
*** paltas has joined #zope | 21:57 | |
*** benji has quit IRC | 22:00 | |
*** benji has joined #zope | 22:02 | |
*** avoinea has quit IRC | 22:03 | |
*** benji has quit IRC | 22:05 | |
*** benji has joined #zope | 22:13 | |
*** thetet has joined #zope | 22:24 | |
*** mcdonc_ has joined #zope | 22:29 | |
*** mcdonc has quit IRC | 22:31 | |
*** nueces has quit IRC | 22:32 | |
*** nueces has joined #zope | 22:35 | |
*** sunew has quit IRC | 22:39 | |
*** nueces has quit IRC | 22:45 | |
*** __mac__ has quit IRC | 23:00 | |
*** mcdonc_ has quit IRC | 23:22 | |
*** betabug has quit IRC | 23:25 | |
*** sp0cksbeard has quit IRC | 23:26 | |
*** fdrake has quit IRC | 23:31 | |
*** eperez has joined #zope | 23:32 | |
*** mindthief414 has quit IRC | 23:32 | |
*** eperez has quit IRC | 23:33 | |
*** mwilkes|away is now known as MatthewWilkes | 23:36 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!