IRC log of #zope for Monday, 2015-01-12

*** J1m has joined #zope00:11
*** kosh has quit IRC00:30
*** m8 has quit IRC01:11
*** J1m has quit IRC01:35
*** J1m has joined #zope02:02
*** J1m has quit IRC02:58
*** kiorky has quit IRC03:29
*** kiorky has joined #zope03:31
*** KageSenshi has joined #zope03:57
*** menesis has quit IRC03:58
*** wleslie has joined #zope04:45
*** yvl has joined #zope07:28
*** wleslie has left #zope07:36
*** alecm has quit IRC07:43
*** daMaestro has quit IRC08:15
*** J1m has joined #zope08:31
*** J1m has quit IRC08:31
*** projekt01 has joined #zope08:42
*** bosim has joined #zope08:55
*** bosim has quit IRC08:56
*** bosim has joined #zope08:57
*** KageSenshi has quit IRC09:13
*** agroszer has joined #zope09:16
*** tisto has joined #zope09:40
*** MrTango has joined #zope09:44
*** __mac__ has joined #zope10:04
*** tisto has quit IRC10:05
*** __mac__1 has joined #zope10:11
*** __mac__ has quit IRC10:14
*** KageSenshi has joined #zope10:20
*** tisto has joined #zope10:20
*** giacomos has joined #zope10:22
*** KageSenshi has quit IRC10:52
*** tisto is now known as tisto|away10:55
*** menesis has joined #zope11:14
*** PeterZ1 has joined #zope11:31
*** PeterZ1 has left #zope11:31
*** MrTango has quit IRC11:46
*** KageSenshi has joined #zope12:26
*** KageSenshi has quit IRC12:40
*** maurits has joined #zope13:00
do3ccmgedmin: I revisited the zope.testrunner and I realized something, we are abusing __bases__, which itself is actually a python provided attribute giving the direct base classes13:07
do3ccthe docs state in no place that __bases__ is a layer property. So imho if MininalTestLayer fakes __bases__ it is messing with internal undocument structure of zope.testrunner13:07
do3ccthe plone.testing docs also get it wrong13:08
*** giacomos has quit IRC13:36
*** giacomos has joined #zope13:37
*** projekt01 has quit IRC13:41
*** benji has joined #zope14:04
*** J1m has joined #zope14:05
*** J1m has quit IRC14:09
*** J1m has joined #zope14:13
*** J1m has quit IRC14:45
*** menesis has quit IRC14:55
*** MrTango has joined #zope14:57
*** Pumukel has joined #zope15:04
*** __mac__1 has left #zope15:20
mgedmindo3cc, IIRC the people responsible admitted it was a mistake to use __bases__ as the name of that attribute15:36
mgedmin"Layers are generally implemented as classes using class methods."15:38
mgedminimplying that they're not necessarily classes15:38
mgedmin(this is from zope/testrunner/tests/testrunner-layers-api.txt)15:39
do3ccyes, I read the docs too, and linked them15:39
mgedminI'm not a fan of the zope.testrunner layer design15:40
do3ccI am not a fan of the documentation15:41
do3ccdoesnt hel[p15:41
mgedminexample of layer-as-an-instance: https://github.com/zopefoundation/zope.app.wsgi/blob/0a50583193daf85d16d81731a9b1358d8074e3f4/src/zope/app/wsgi/tests.py#L7415:41
do3ccabusing internal non documented behavior15:42
do3cchmm, non documented behavior, I see many changes one can do in zope that don't need minor or major version number increase ;-)15:42
mgedminjust another day in zopeland15:43
*** menesis has joined #zope15:47
mgedminthere's a subthread starting with https://mail.zope.org/pipermail/zope-dev/2010-April/040161.html15:56
mgedminwhere people argue about why classes are a bad implementation technique for layers15:57
mgedminhttps://mail.zope.org/pipermail/zope-dev/2010-April/040267.html is notable15:59
mgedminand this is why people started using instances to represent layers16:00
do3ccplone does not use instances16:00
do3ccelse davisaglis code would not work16:00
do3ccbut I understand the critic from martin16:00
mgedminI think gocept.selenium also uses layer instances, but I'm not sure16:02
mgedminthe code is hard to follow :/16:02
mgedminoh right, gocept.selenium is based on plone.testing's layers16:03
mgedminwith __bases__ as an instance variable16:03
do3ccI wonder if I should just stop here and und 4.4.516:03
mgedminhttps://github.com/plone/plone.testing/blob/master/src/plone/testing/layer.py#L816:03
do3ccI don't want to support code that abuses __bases__ property16:04
mgedmintalk to Jim, he disagrees that there's any abuse going on :)16:04
mgedminhttps://mail.zope.org/pipermail/zope-dev/2010-April/040264.html16:04
mgedminI'm willing to make zope.testrunner work with non-class-based layers16:05
mgedminbecause I want the run-unit-tests-first part of the latest patchset16:05
*** bosim has quit IRC16:05
do3ccI am at a loss for words16:05
*** __mac__ has joined #zope16:15
*** __mac__ has quit IRC16:50
*** __mac__ has joined #zope16:52
*** agroszer has quit IRC16:54
*** fredvd has joined #zope17:53
*** MrTango has quit IRC17:56
*** __mac__ has quit IRC18:47
*** giacomos has quit IRC19:03
*** alecm has joined #zope19:05
*** fredvd has quit IRC19:08
*** tisto|away has quit IRC19:10
*** maurits has quit IRC19:17
*** giacomos has joined #zope20:00
*** giacomos has quit IRC20:03
*** menesis has quit IRC21:06
*** giacomos has joined #zope21:19
*** __mac__ has joined #zope21:24
*** giacomos has quit IRC21:37
*** menesis has joined #zope22:05
*** RiverRat has quit IRC22:14
*** RiverRat has joined #zope22:14
*** Pumukel has quit IRC22:21
*** Pumukel has joined #zope22:22
*** Jan_Garaj3 has joined #zope22:32
*** __mac__ has quit IRC23:04
*** stereo_ has joined #zope23:11
*** roq_ has quit IRC23:17
*** fdrake2 has quit IRC23:26
*** MrTango has joined #zope23:28
*** fdrake has joined #zope23:47

Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!