| *** J1m has joined #zope | 00:11 | |
| *** kosh has quit IRC | 00:30 | |
| *** m8 has quit IRC | 01:11 | |
| *** J1m has quit IRC | 01:35 | |
| *** J1m has joined #zope | 02:02 | |
| *** J1m has quit IRC | 02:58 | |
| *** kiorky has quit IRC | 03:29 | |
| *** kiorky has joined #zope | 03:31 | |
| *** KageSenshi has joined #zope | 03:57 | |
| *** menesis has quit IRC | 03:58 | |
| *** wleslie has joined #zope | 04:45 | |
| *** yvl has joined #zope | 07:28 | |
| *** wleslie has left #zope | 07:36 | |
| *** alecm has quit IRC | 07:43 | |
| *** daMaestro has quit IRC | 08:15 | |
| *** J1m has joined #zope | 08:31 | |
| *** J1m has quit IRC | 08:31 | |
| *** projekt01 has joined #zope | 08:42 | |
| *** bosim has joined #zope | 08:55 | |
| *** bosim has quit IRC | 08:56 | |
| *** bosim has joined #zope | 08:57 | |
| *** KageSenshi has quit IRC | 09:13 | |
| *** agroszer has joined #zope | 09:16 | |
| *** tisto has joined #zope | 09:40 | |
| *** MrTango has joined #zope | 09:44 | |
| *** __mac__ has joined #zope | 10:04 | |
| *** tisto has quit IRC | 10:05 | |
| *** __mac__1 has joined #zope | 10:11 | |
| *** __mac__ has quit IRC | 10:14 | |
| *** KageSenshi has joined #zope | 10:20 | |
| *** tisto has joined #zope | 10:20 | |
| *** giacomos has joined #zope | 10:22 | |
| *** KageSenshi has quit IRC | 10:52 | |
| *** tisto is now known as tisto|away | 10:55 | |
| *** menesis has joined #zope | 11:14 | |
| *** PeterZ1 has joined #zope | 11:31 | |
| *** PeterZ1 has left #zope | 11:31 | |
| *** MrTango has quit IRC | 11:46 | |
| *** KageSenshi has joined #zope | 12:26 | |
| *** KageSenshi has quit IRC | 12:40 | |
| *** maurits has joined #zope | 13:00 | |
| do3cc | mgedmin: I revisited the zope.testrunner and I realized something, we are abusing __bases__, which itself is actually a python provided attribute giving the direct base classes | 13:07 |
|---|---|---|
| do3cc | the docs state in no place that __bases__ is a layer property. So imho if MininalTestLayer fakes __bases__ it is messing with internal undocument structure of zope.testrunner | 13:07 |
| do3cc | the plone.testing docs also get it wrong | 13:08 |
| *** giacomos has quit IRC | 13:36 | |
| *** giacomos has joined #zope | 13:37 | |
| *** projekt01 has quit IRC | 13:41 | |
| *** benji has joined #zope | 14:04 | |
| *** J1m has joined #zope | 14:05 | |
| *** J1m has quit IRC | 14:09 | |
| *** J1m has joined #zope | 14:13 | |
| *** J1m has quit IRC | 14:45 | |
| *** menesis has quit IRC | 14:55 | |
| *** MrTango has joined #zope | 14:57 | |
| *** Pumukel has joined #zope | 15:04 | |
| *** __mac__1 has left #zope | 15:20 | |
| mgedmin | do3cc, IIRC the people responsible admitted it was a mistake to use __bases__ as the name of that attribute | 15:36 |
| mgedmin | "Layers are generally implemented as classes using class methods." | 15:38 |
| mgedmin | implying that they're not necessarily classes | 15:38 |
| mgedmin | (this is from zope/testrunner/tests/testrunner-layers-api.txt) | 15:39 |
| do3cc | yes, I read the docs too, and linked them | 15:39 |
| mgedmin | I'm not a fan of the zope.testrunner layer design | 15:40 |
| do3cc | I am not a fan of the documentation | 15:41 |
| do3cc | doesnt hel[p | 15:41 |
| mgedmin | example of layer-as-an-instance: https://github.com/zopefoundation/zope.app.wsgi/blob/0a50583193daf85d16d81731a9b1358d8074e3f4/src/zope/app/wsgi/tests.py#L74 | 15:41 |
| do3cc | abusing internal non documented behavior | 15:42 |
| do3cc | hmm, non documented behavior, I see many changes one can do in zope that don't need minor or major version number increase ;-) | 15:42 |
| mgedmin | just another day in zopeland | 15:43 |
| *** menesis has joined #zope | 15:47 | |
| mgedmin | there's a subthread starting with https://mail.zope.org/pipermail/zope-dev/2010-April/040161.html | 15:56 |
| mgedmin | where people argue about why classes are a bad implementation technique for layers | 15:57 |
| mgedmin | https://mail.zope.org/pipermail/zope-dev/2010-April/040267.html is notable | 15:59 |
| mgedmin | and this is why people started using instances to represent layers | 16:00 |
| do3cc | plone does not use instances | 16:00 |
| do3cc | else davisaglis code would not work | 16:00 |
| do3cc | but I understand the critic from martin | 16:00 |
| mgedmin | I think gocept.selenium also uses layer instances, but I'm not sure | 16:02 |
| mgedmin | the code is hard to follow :/ | 16:02 |
| mgedmin | oh right, gocept.selenium is based on plone.testing's layers | 16:03 |
| mgedmin | with __bases__ as an instance variable | 16:03 |
| do3cc | I wonder if I should just stop here and und 4.4.5 | 16:03 |
| mgedmin | https://github.com/plone/plone.testing/blob/master/src/plone/testing/layer.py#L8 | 16:03 |
| do3cc | I don't want to support code that abuses __bases__ property | 16:04 |
| mgedmin | talk to Jim, he disagrees that there's any abuse going on :) | 16:04 |
| mgedmin | https://mail.zope.org/pipermail/zope-dev/2010-April/040264.html | 16:04 |
| mgedmin | I'm willing to make zope.testrunner work with non-class-based layers | 16:05 |
| mgedmin | because I want the run-unit-tests-first part of the latest patchset | 16:05 |
| *** bosim has quit IRC | 16:05 | |
| do3cc | I am at a loss for words | 16:05 |
| *** __mac__ has joined #zope | 16:15 | |
| *** __mac__ has quit IRC | 16:50 | |
| *** __mac__ has joined #zope | 16:52 | |
| *** agroszer has quit IRC | 16:54 | |
| *** fredvd has joined #zope | 17:53 | |
| *** MrTango has quit IRC | 17:56 | |
| *** __mac__ has quit IRC | 18:47 | |
| *** giacomos has quit IRC | 19:03 | |
| *** alecm has joined #zope | 19:05 | |
| *** fredvd has quit IRC | 19:08 | |
| *** tisto|away has quit IRC | 19:10 | |
| *** maurits has quit IRC | 19:17 | |
| *** giacomos has joined #zope | 20:00 | |
| *** giacomos has quit IRC | 20:03 | |
| *** menesis has quit IRC | 21:06 | |
| *** giacomos has joined #zope | 21:19 | |
| *** __mac__ has joined #zope | 21:24 | |
| *** giacomos has quit IRC | 21:37 | |
| *** menesis has joined #zope | 22:05 | |
| *** RiverRat has quit IRC | 22:14 | |
| *** RiverRat has joined #zope | 22:14 | |
| *** Pumukel has quit IRC | 22:21 | |
| *** Pumukel has joined #zope | 22:22 | |
| *** Jan_Garaj3 has joined #zope | 22:32 | |
| *** __mac__ has quit IRC | 23:04 | |
| *** stereo_ has joined #zope | 23:11 | |
| *** roq_ has quit IRC | 23:17 | |
| *** fdrake2 has quit IRC | 23:26 | |
| *** MrTango has joined #zope | 23:28 | |
| *** fdrake has joined #zope | 23:47 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!