IRC log of #zope3-dev for Thursday, 2009-10-22

*** redir_ has quit IRC00:05
*** malthe_ has joined #zope3-dev00:10
*** dunny has joined #zope3-dev00:11
*** junkafarian has joined #zope3-dev00:14
*** J1m has quit IRC00:15
*** jbglenn has joined #zope3-dev00:17
*** alga has quit IRC00:20
*** jbglenn has quit IRC00:20
*** fcorrea has quit IRC00:23
*** malthe has quit IRC00:25
*** povbot has joined #zope3-dev00:54
*** davisagli has quit IRC01:03
*** Theuni1 has quit IRC01:05
*** nathany has quit IRC01:13
*** redir has joined #zope3-dev01:16
*** matthal has joined #zope3-dev01:26
*** gary-sprint has quit IRC01:27
*** mcdonc has quit IRC01:37
*** lurkymclurkleton has quit IRC01:39
*** mcdonc has joined #zope3-dev01:40
*** hathawsh is now known as hath|away01:54
*** hath|away is now known as hathawsh02:05
*** jhauser has quit IRC02:10
*** reinout has quit IRC02:32
*** davisagli has joined #zope3-dev02:51
*** Aiste has quit IRC03:57
*** junkafarian has quit IRC03:57
*** brandon_rhodes has joined #zope3-dev03:58
*** alecm has quit IRC04:07
*** dunny has quit IRC04:09
*** hathawsh is now known as hath|away04:09
*** dunny has joined #zope3-dev04:13
*** fcorrea has joined #zope3-dev04:20
*** pcardune has quit IRC04:32
*** markusleist has quit IRC04:33
*** hath|away is now known as hathawsh04:39
*** brandon_rhodes has quit IRC04:52
*** ignas has quit IRC05:11
*** hathawsh is now known as hath|away05:15
*** fcorrea has quit IRC05:25
*** afd_ has joined #zope3-dev06:08
*** hath|away is now known as hathawsh06:32
*** davisagli has quit IRC07:04
*** tarek has quit IRC08:01
*** baijum has joined #zope3-dev08:05
*** jfkw has quit IRC08:06
*** Theuni1 has joined #zope3-dev08:13
*** davisagli has joined #zope3-dev08:15
*** Theuni1 has quit IRC08:21
*** baijum1 has joined #zope3-dev08:27
*** baijum has quit IRC08:27
*** jukart has joined #zope3-dev08:31
*** tarek has joined #zope3-dev08:38
*** Theuni1 has joined #zope3-dev08:42
*** JaRoel|4_ has quit IRC08:43
*** runyaga__ has quit IRC08:45
*** runyaga has joined #zope3-dev08:51
*** redir has quit IRC08:52
*** redir has joined #zope3-dev08:52
*** nyo has joined #zope3-dev08:53
*** matthal has quit IRC08:55
*** tarek has quit IRC08:57
*** runyaga has quit IRC08:58
*** Theuni1 has quit IRC09:04
*** Theuni1 has joined #zope3-dev09:07
*** runyaga has joined #zope3-dev09:17
*** __mac__ has joined #zope3-dev09:17
*** hexsprite has quit IRC09:28
*** hexsprite has joined #zope3-dev09:29
*** sweh has joined #zope3-dev09:35
*** afd_ has quit IRC09:46
*** redir has quit IRC09:47
*** romanofski has quit IRC10:00
*** agroszer has joined #zope3-dev10:01
*** jpcw has quit IRC10:04
*** pcardune has joined #zope3-dev10:07
*** JaRoel|4D has joined #zope3-dev10:09
*** afd__ has joined #zope3-dev10:24
*** malthe has joined #zope3-dev10:29
*** romanofski has joined #zope3-dev10:32
*** matthal has joined #zope3-dev10:33
*** matthal has quit IRC10:37
*** matthal has joined #zope3-dev10:37
*** hathawsh is now known as hath|away10:43
*** hath|away is now known as hathawsh10:43
*** davisagli has left #zope3-dev10:45
*** junkafarian has joined #zope3-dev10:48
*** jpcw has joined #zope3-dev10:49
*** projekt01 has joined #zope3-dev10:58
*** MJ has joined #zope3-dev11:11
*** matthal has quit IRC11:14
*** projekt01 has quit IRC11:14
*** romanofski has quit IRC11:21
*** fcorrea has joined #zope3-dev11:24
*** menesis has joined #zope3-dev11:27
*** hathawsh is now known as hath|away11:29
*** hath|away is now known as hathawsh11:30
*** goschtl has joined #zope3-dev11:30
*** hathawsh is now known as hath|away11:44
*** hath|away is now known as hathawsh11:49
*** reinout has joined #zope3-dev12:01
*** alga has joined #zope3-dev12:37
*** baijum1 has quit IRC12:38
*** mgedmin has joined #zope3-dev12:39
*** projekt01 has joined #zope3-dev12:43
*** hathawsh is now known as hath|away12:44
*** romanofski has joined #zope3-dev12:48
*** baijum has joined #zope3-dev12:52
*** baijum has quit IRC12:55
*** tarek has joined #zope3-dev13:00
*** ignas has joined #zope3-dev13:17
*** pcardune has quit IRC13:31
*** Theuni1 has quit IRC13:49
*** Theuni1 has joined #zope3-dev14:01
*** romanofski has quit IRC14:16
*** kiorky has quit IRC14:25
*** kiorky_ has joined #zope3-dev14:25
*** markusleist has joined #zope3-dev14:27
*** chaoflow_ has joined #zope3-dev14:29
*** chaoflow has quit IRC14:29
*** lisppaste6 has quit IRC14:41
*** lisppaste6 has joined #zope3-dev14:41
*** fcorrea has quit IRC14:41
*** drudi has joined #zope3-dev14:55
*** kiorky_ has quit IRC14:57
*** kiorky has joined #zope3-dev14:57
*** fcorrea has joined #zope3-dev15:14
*** tarek is now known as tarek|lunch15:22
*** baijum has joined #zope3-dev15:30
*** gary_poster has joined #zope3-dev15:36
*** hazmat has quit IRC15:45
*** sunoano has joined #zope3-dev15:46
*** projekt01 has quit IRC15:52
*** gary_poster is now known as gary-sprint15:56
*** lurkymclurkleton has joined #zope3-dev16:04
*** __mac__ has quit IRC16:04
*** __mac__ has joined #zope3-dev16:07
*** fcorrea_ has joined #zope3-dev16:15
*** fcorrea has quit IRC16:21
*** fcorrea_ is now known as fcorrea16:21
*** tarek|lunch is now known as tarek16:30
*** baijum has quit IRC16:31
*** sweh has quit IRC16:38
*** sweh has joined #zope3-dev16:46
*** dunny has quit IRC16:46
*** dunny has joined #zope3-dev16:47
*** aaronv has joined #zope3-dev16:51
*** jbglenn has joined #zope3-dev16:55
*** nyo has quit IRC17:00
*** sweh has quit IRC17:01
*** jfkw has joined #zope3-dev17:25
*** afd__ has quit IRC17:27
*** baijum has joined #zope3-dev17:35
*** redir has joined #zope3-dev17:38
*** reinout has quit IRC17:57
gary-sprintif anyone can get tlotze on the channel, that would be cool17:57
*** jukart has quit IRC18:16
*** alecm has joined #zope3-dev18:21
*** allisterb_ has joined #zope3-dev18:22
*** afd__ has joined #zope3-dev18:24
*** afd__ has quit IRC18:25
*** afd_ has joined #zope3-dev18:28
*** alecm has quit IRC18:35
*** allisterb has quit IRC18:40
*** redir_ has joined #zope3-dev18:40
Theuni1gimme a sec18:41
Theuni1.oO(hmm. gave me already an hour)18:42
Theuni1gary-sprint: whatcha sprinting on?18:42
*** JaRoel|4D has quit IRC18:42
*** mgedmin has quit IRC18:42
CSWookieActually, I bet he's just giving AT&T a warning about how he feels about the iPhone.18:43
gary-sprintTheuni1: Launchpad on ZTK18:43
Theuni1I poked Thomas on an internal channel where he's idling, I guess he'll get back to you at some point18:43
Theuni1gary-sprint: yay18:43
gary-sprintTheuni1: thank you!18:43
Theuni1CSWookie: hah. that was partially hard to understand for non-us ;)18:43
* Theuni1 considers moving himself into a sauna18:43
CSWookieTheuni1: I thought about that after I said it...18:44
CSWookieBut you deserve it, for having access to a sauna.18:44
Theuni1That simplifies coming to a decision a lot. Thanks! :)18:44
*** alecm has joined #zope3-dev18:45
*** goschtl has quit IRC18:45
*** J1m has joined #zope3-dev18:52
*** redir has quit IRC18:54
*** afd__ has joined #zope3-dev18:57
*** hath|away is now known as hathawsh18:58
*** __mac__ has quit IRC18:59
*** MJ has quit IRC19:00
*** afd_ has quit IRC19:03
*** jpcw has left #zope3-dev19:07
*** davisagli has joined #zope3-dev19:16
*** faassen has joined #zope3-dev19:17
*** tlotze has joined #zope3-dev19:18
tlotzegary-sprint: I've heard you were asking after me?19:18
*** faassen has quit IRC19:19
tlotze(or whatever the right preposition in place of 'after' would be...)19:21
*** Aiste has joined #zope3-dev19:27
*** pcardune has joined #zope3-dev19:28
gary-sprinttlotze: hi, yes!  thank you for getting to me19:31
gary-sprinttlotze: I want to make a couple of fixes to zope.publisher19:31
gary-sprintI noticed that trunk depends on unreleased changes of zope.contenttype19:31
gary-sprintWhy are they unreleased?19:32
gary-sprintShould we release zope.contenttype as is, and then should I develop on zope.publisher trunk?19:32
gary-sprintI was proceeding with making a 2.9 branch and making changes there19:32
tlotzeI intended to release a bunch of things together19:33
tlotzeI realize I should have kept the stuff in branches until that point.19:33
gary-sprintalso, I didn't check to see if you were the one who had made changes to setDefaultSkin, but I'd love to run my change by you if you are familiar with it19:33
*** alga has quit IRC19:33
gary-sprintyeah, branches would have been nice :-)19:33
tlotzeI principle, that stuff may be released at any time.19:33
gary-sprintso are there more packages that will need to be released?19:34
tlotzeHm, I can have a look at the change even though I didn't do anything about setDefaultSkin.19:34
tlotzeI'll look up my notes about which packages go together.19:34
gary-sprintok thanks19:34
tlotzeHow urgent is looking at your change? I won't have time for it until tomorrow morning (GMT).19:35
gary-sprinttlotze: pretty urgent, but I can make a release without it if need be: I've already gotten Barry Warsaw and another good engineer here to look at it.  You had the zope.publisher context, so it would be nice to get your review.  It's essentially a one line change, plus indenting a block, but you do have to think about it19:36
tlotzeOK, show me now.19:37
tlotzeMaybe it helps anyway.19:37
tlotzeI've got a few minutes left...19:38
gary-sprinttlotze: this is a sketch; I was in the middle of writing the tests, so I had not actually made the code changes yet.  So, this is my intent:
* tlotze goes looking19:38
gary-sprintI think I might actually remove the try: except around the skin(request)19:39
gary-sprintbecause my check should make it unnecessary19:39
gary-sprintthe problem is that, if the skin is an interface, and you have a request that already implements the skin, things fall over badly.  While that's perhaps an odd case, in general I think that adapting request to an interface to have it return an interface is a bit insane.19:40
*** ignas has quit IRC19:41
tlotzeAt first glance, it does look cleaner and a lot more expressive.19:41
gary-sprintHaving a request already implement the skin is not all that odd really: I'd argue it is reasonable to hardcode the skin interface on the request if it makes sense for your app.19:41
gary-sprintok cool.  Of course, I intend to write a test showing the behavior, and I won't proceed if the tests fail.19:42
tlotzeHowever, why would your change make the try-except unnecessary? I'm not too familiar with that area of code, in fact... Is there some guarantee that if the skin is an interface, the call will succeed?19:43
gary-sprintif the skin is not an interface, you mean?19:44
tlotzeCannot the adapter lookup fail?19:44
tlotzeOne corner too many to think around ;o)19:44
tlotzeHow's test coverage for the code in question?19:45
gary-sprintif, coming into the ``skin = skin(request)`` line, the skin is not an interface, then it is supposed to be a factory.  If the factory fails, AFAIK it is appropriate to blow up: the factory configured to provide a default skin did not do so, and that should be an error.19:46
tlotzebtw, I'm currently running compat tests against everything mentioned in ztk.cfg with only zope.contenttype and zope.publisher taken from trunk...19:46
tlotzeBut then, isn't it possible to fix the situation that a request which already implements the skin makes things falls over?19:47
gary-sprinttests: there's a skinnable.txt that seems pretty good.  I had a bit of a hard time following it, but it is reasonably thorough.19:47
gary-sprintpossible to fix the situation: what do you mean?19:48
gary-sprintI mean, what do you have in mind?19:48
tlotzenothing specific, I just noticed that your explanation sounds like a work-around, so I wonder on a rather general level why we have to work around things19:51
tlotzeWhy cannot skin(request) just do the right thing in case the request implements the skin already?19:52
tlotzere releases: you can release just zope.contenttype and zope.publisher and everything will be fine19:53
gary-sprinttlotze: re releases: ok cool thanks!19:53
tlotzeI did touch a bunch of packages in the course of the same refactoring but they will be OK due to BBB imports, and I'll release them later. Maybe more similar changes accumulate for them as I have some other refactorings going.19:54
gary-sprintskin(request) will always return the request if the skin is an interface and if the request implements the interface.  That's just how zope.interface works19:54
gary-sprintit's the adaptation short cut19:55
gary-sprintotherpackages: ok cool19:55
tlotzeI'll have to leave in a couple of minutes.19:57
gary-sprintunderstood.  thanks for your help.  So, are you relatively convinced by my change, then?19:58
gary-sprintcool thanks19:58
tlotzeto the extent that I think I understand the problem ;o)19:58
gary-sprintheh, completely understood19:58
gary-sprintok, I'll make the contenttype release in a sec19:58
gary-sprintthanks again!19:58
tlotzeno problem whatsoever19:59
*** tarek has quit IRC20:00
*** junkafarian has quit IRC20:05
*** aaronv has quit IRC20:07
*** mcdonc has quit IRC20:12
*** agroszer has quit IRC20:18
*** agroszer_ has joined #zope3-dev20:18
*** baijum has quit IRC20:28
*** sunoano has quit IRC20:42
*** agroszer has joined #zope3-dev20:46
*** agroszer_ has quit IRC20:53
*** allisterb_ has quit IRC21:05
*** jpcw has joined #zope3-dev21:06
*** afd__ has quit IRC21:14
*** JaRoel|4D has joined #zope3-dev21:14
*** JaRoel|4_ has joined #zope3-dev21:16
*** matthal has joined #zope3-dev21:19
*** matthal has quit IRC21:37
*** JaRoel|4D has quit IRC21:38
*** aaronv has joined #zope3-dev21:38
*** mcdonc has joined #zope3-dev21:44
*** hathawsh is now known as hath|away21:47
*** __mac__ has joined #zope3-dev21:47
*** __mac__ has quit IRC21:56
*** junkafarian has joined #zope3-dev22:11
*** hath|away is now known as hathawsh22:11
*** dunny has joined #zope3-dev22:18
*** agroszer has quit IRC22:22
*** sm has joined #zope3-dev22:24
smg'day all22:24
smjust wanted to say: latest zope/zodb/ztk release looks really impressive so far, well done zope devs22:24
*** aaronv has quit IRC22:32
*** hathawsh is now known as hath|away22:35
*** malthe has quit IRC22:48
*** mgedmin has joined #zope3-dev22:58
*** aaronv has joined #zope3-dev23:03
*** matthal has joined #zope3-dev23:17
*** J1m_ has joined #zope3-dev23:23
*** tarek has joined #zope3-dev23:30
*** J1m has quit IRC23:33
*** gary-sprint has quit IRC23:48
*** pcardune has quit IRC23:56

Generated by 2.15.1 by Marius Gedminas - find it at!