| *** redir_ has quit IRC | 00:05 | |
| *** malthe_ has joined #zope3-dev | 00:10 | |
| *** dunny has joined #zope3-dev | 00:11 | |
| *** junkafarian has joined #zope3-dev | 00:14 | |
| *** J1m has quit IRC | 00:15 | |
| *** jbglenn has joined #zope3-dev | 00:17 | |
| *** alga has quit IRC | 00:20 | |
| *** jbglenn has quit IRC | 00:20 | |
| *** fcorrea has quit IRC | 00:23 | |
| *** malthe has quit IRC | 00:25 | |
| *** povbot has joined #zope3-dev | 00:54 | |
| *** davisagli has quit IRC | 01:03 | |
| *** Theuni1 has quit IRC | 01:05 | |
| *** nathany has quit IRC | 01:13 | |
| *** redir has joined #zope3-dev | 01:16 | |
| *** matthal has joined #zope3-dev | 01:26 | |
| *** gary-sprint has quit IRC | 01:27 | |
| *** mcdonc has quit IRC | 01:37 | |
| *** lurkymclurkleton has quit IRC | 01:39 | |
| *** mcdonc has joined #zope3-dev | 01:40 | |
| *** hathawsh is now known as hath|away | 01:54 | |
| *** hath|away is now known as hathawsh | 02:05 | |
| *** jhauser has quit IRC | 02:10 | |
| *** reinout has quit IRC | 02:32 | |
| *** davisagli has joined #zope3-dev | 02:51 | |
| *** Aiste has quit IRC | 03:57 | |
| *** junkafarian has quit IRC | 03:57 | |
| *** brandon_rhodes has joined #zope3-dev | 03:58 | |
| *** alecm has quit IRC | 04:07 | |
| *** dunny has quit IRC | 04:09 | |
| *** hathawsh is now known as hath|away | 04:09 | |
| *** dunny has joined #zope3-dev | 04:13 | |
| *** fcorrea has joined #zope3-dev | 04:20 | |
| *** pcardune has quit IRC | 04:32 | |
| *** markusleist has quit IRC | 04:33 | |
| *** hath|away is now known as hathawsh | 04:39 | |
| *** brandon_rhodes has quit IRC | 04:52 | |
| *** ignas has quit IRC | 05:11 | |
| *** hathawsh is now known as hath|away | 05:15 | |
| *** fcorrea has quit IRC | 05:25 | |
| *** afd_ has joined #zope3-dev | 06:08 | |
| *** hath|away is now known as hathawsh | 06:32 | |
| *** davisagli has quit IRC | 07:04 | |
| *** tarek has quit IRC | 08:01 | |
| *** baijum has joined #zope3-dev | 08:05 | |
| *** jfkw has quit IRC | 08:06 | |
| *** Theuni1 has joined #zope3-dev | 08:13 | |
| *** davisagli has joined #zope3-dev | 08:15 | |
| *** Theuni1 has quit IRC | 08:21 | |
| *** baijum1 has joined #zope3-dev | 08:27 | |
| *** baijum has quit IRC | 08:27 | |
| *** jukart has joined #zope3-dev | 08:31 | |
| *** tarek has joined #zope3-dev | 08:38 | |
| *** Theuni1 has joined #zope3-dev | 08:42 | |
| *** JaRoel|4_ has quit IRC | 08:43 | |
| *** runyaga__ has quit IRC | 08:45 | |
| *** runyaga has joined #zope3-dev | 08:51 | |
| *** redir has quit IRC | 08:52 | |
| *** redir has joined #zope3-dev | 08:52 | |
| *** nyo has joined #zope3-dev | 08:53 | |
| *** matthal has quit IRC | 08:55 | |
| *** tarek has quit IRC | 08:57 | |
| *** runyaga has quit IRC | 08:58 | |
| *** Theuni1 has quit IRC | 09:04 | |
| *** Theuni1 has joined #zope3-dev | 09:07 | |
| *** runyaga has joined #zope3-dev | 09:17 | |
| *** __mac__ has joined #zope3-dev | 09:17 | |
| *** hexsprite has quit IRC | 09:28 | |
| *** hexsprite has joined #zope3-dev | 09:29 | |
| *** sweh has joined #zope3-dev | 09:35 | |
| *** afd_ has quit IRC | 09:46 | |
| *** redir has quit IRC | 09:47 | |
| *** romanofski has quit IRC | 10:00 | |
| *** agroszer has joined #zope3-dev | 10:01 | |
| *** jpcw has quit IRC | 10:04 | |
| *** pcardune has joined #zope3-dev | 10:07 | |
| *** JaRoel|4D has joined #zope3-dev | 10:09 | |
| *** afd__ has joined #zope3-dev | 10:24 | |
| *** malthe has joined #zope3-dev | 10:29 | |
| *** romanofski has joined #zope3-dev | 10:32 | |
| *** matthal has joined #zope3-dev | 10:33 | |
| *** matthal has quit IRC | 10:37 | |
| *** matthal has joined #zope3-dev | 10:37 | |
| *** hathawsh is now known as hath|away | 10:43 | |
| *** hath|away is now known as hathawsh | 10:43 | |
| *** davisagli has left #zope3-dev | 10:45 | |
| *** junkafarian has joined #zope3-dev | 10:48 | |
| *** jpcw has joined #zope3-dev | 10:49 | |
| *** projekt01 has joined #zope3-dev | 10:58 | |
| *** MJ has joined #zope3-dev | 11:11 | |
| *** matthal has quit IRC | 11:14 | |
| *** projekt01 has quit IRC | 11:14 | |
| *** romanofski has quit IRC | 11:21 | |
| *** fcorrea has joined #zope3-dev | 11:24 | |
| *** menesis has joined #zope3-dev | 11:27 | |
| *** hathawsh is now known as hath|away | 11:29 | |
| *** hath|away is now known as hathawsh | 11:30 | |
| *** goschtl has joined #zope3-dev | 11:30 | |
| *** hathawsh is now known as hath|away | 11:44 | |
| *** hath|away is now known as hathawsh | 11:49 | |
| *** reinout has joined #zope3-dev | 12:01 | |
| *** alga has joined #zope3-dev | 12:37 | |
| *** baijum1 has quit IRC | 12:38 | |
| *** mgedmin has joined #zope3-dev | 12:39 | |
| *** projekt01 has joined #zope3-dev | 12:43 | |
| *** hathawsh is now known as hath|away | 12:44 | |
| *** romanofski has joined #zope3-dev | 12:48 | |
| *** baijum has joined #zope3-dev | 12:52 | |
| *** baijum has quit IRC | 12:55 | |
| *** tarek has joined #zope3-dev | 13:00 | |
| *** ignas has joined #zope3-dev | 13:17 | |
| *** pcardune has quit IRC | 13:31 | |
| *** Theuni1 has quit IRC | 13:49 | |
| *** Theuni1 has joined #zope3-dev | 14:01 | |
| *** romanofski has quit IRC | 14:16 | |
| *** kiorky has quit IRC | 14:25 | |
| *** kiorky_ has joined #zope3-dev | 14:25 | |
| *** markusleist has joined #zope3-dev | 14:27 | |
| *** chaoflow_ has joined #zope3-dev | 14:29 | |
| *** chaoflow has quit IRC | 14:29 | |
| *** lisppaste6 has quit IRC | 14:41 | |
| *** lisppaste6 has joined #zope3-dev | 14:41 | |
| *** fcorrea has quit IRC | 14:41 | |
| *** drudi has joined #zope3-dev | 14:55 | |
| *** kiorky_ has quit IRC | 14:57 | |
| *** kiorky has joined #zope3-dev | 14:57 | |
| *** fcorrea has joined #zope3-dev | 15:14 | |
| *** tarek is now known as tarek|lunch | 15:22 | |
| *** baijum has joined #zope3-dev | 15:30 | |
| *** gary_poster has joined #zope3-dev | 15:36 | |
| *** hazmat has quit IRC | 15:45 | |
| *** sunoano has joined #zope3-dev | 15:46 | |
| *** projekt01 has quit IRC | 15:52 | |
| *** gary_poster is now known as gary-sprint | 15:56 | |
| *** lurkymclurkleton has joined #zope3-dev | 16:04 | |
| *** __mac__ has quit IRC | 16:04 | |
| *** __mac__ has joined #zope3-dev | 16:07 | |
| *** fcorrea_ has joined #zope3-dev | 16:15 | |
| *** fcorrea has quit IRC | 16:21 | |
| *** fcorrea_ is now known as fcorrea | 16:21 | |
| *** tarek|lunch is now known as tarek | 16:30 | |
| *** baijum has quit IRC | 16:31 | |
| *** sweh has quit IRC | 16:38 | |
| *** sweh has joined #zope3-dev | 16:46 | |
| *** dunny has quit IRC | 16:46 | |
| *** dunny has joined #zope3-dev | 16:47 | |
| *** aaronv has joined #zope3-dev | 16:51 | |
| *** jbglenn has joined #zope3-dev | 16:55 | |
| *** nyo has quit IRC | 17:00 | |
| *** sweh has quit IRC | 17:01 | |
| *** jfkw has joined #zope3-dev | 17:25 | |
| *** afd__ has quit IRC | 17:27 | |
| *** baijum has joined #zope3-dev | 17:35 | |
| *** redir has joined #zope3-dev | 17:38 | |
| *** reinout has quit IRC | 17:57 | |
| gary-sprint | if anyone can get tlotze on the channel, that would be cool | 17:57 |
|---|---|---|
| *** jukart has quit IRC | 18:16 | |
| *** alecm has joined #zope3-dev | 18:21 | |
| *** allisterb_ has joined #zope3-dev | 18:22 | |
| *** afd__ has joined #zope3-dev | 18:24 | |
| *** afd__ has quit IRC | 18:25 | |
| *** afd_ has joined #zope3-dev | 18:28 | |
| *** alecm has quit IRC | 18:35 | |
| *** allisterb has quit IRC | 18:40 | |
| *** redir_ has joined #zope3-dev | 18:40 | |
| Theuni1 | gimme a sec | 18:41 |
| Theuni1 | .oO(hmm. gave me already an hour) | 18:42 |
| Theuni1 | gary-sprint: whatcha sprinting on? | 18:42 |
| *** JaRoel|4D has quit IRC | 18:42 | |
| *** mgedmin has quit IRC | 18:42 | |
| CSWookie | Actually, I bet he's just giving AT&T a warning about how he feels about the iPhone. | 18:43 |
| gary-sprint | Theuni1: Launchpad on ZTK | 18:43 |
| Theuni1 | I poked Thomas on an internal channel where he's idling, I guess he'll get back to you at some point | 18:43 |
| Theuni1 | gary-sprint: yay | 18:43 |
| gary-sprint | Theuni1: thank you! | 18:43 |
| Theuni1 | CSWookie: hah. that was partially hard to understand for non-us ;) | 18:43 |
| * Theuni1 considers moving himself into a sauna | 18:43 | |
| CSWookie | Theuni1: I thought about that after I said it... | 18:44 |
| CSWookie | But you deserve it, for having access to a sauna. | 18:44 |
| Theuni1 | meh | 18:44 |
| Theuni1 | That simplifies coming to a decision a lot. Thanks! :) | 18:44 |
| *** alecm has joined #zope3-dev | 18:45 | |
| *** goschtl has quit IRC | 18:45 | |
| *** J1m has joined #zope3-dev | 18:52 | |
| *** redir has quit IRC | 18:54 | |
| *** afd__ has joined #zope3-dev | 18:57 | |
| *** hath|away is now known as hathawsh | 18:58 | |
| *** __mac__ has quit IRC | 18:59 | |
| *** MJ has quit IRC | 19:00 | |
| *** afd_ has quit IRC | 19:03 | |
| *** jpcw has left #zope3-dev | 19:07 | |
| *** davisagli has joined #zope3-dev | 19:16 | |
| *** faassen has joined #zope3-dev | 19:17 | |
| *** tlotze has joined #zope3-dev | 19:18 | |
| tlotze | gary-sprint: I've heard you were asking after me? | 19:18 |
| *** faassen has quit IRC | 19:19 | |
| tlotze | (or whatever the right preposition in place of 'after' would be...) | 19:21 |
| *** Aiste has joined #zope3-dev | 19:27 | |
| *** pcardune has joined #zope3-dev | 19:28 | |
| gary-sprint | tlotze: hi, yes! thank you for getting to me | 19:31 |
| gary-sprint | tlotze: I want to make a couple of fixes to zope.publisher | 19:31 |
| gary-sprint | I noticed that trunk depends on unreleased changes of zope.contenttype | 19:31 |
| gary-sprint | Why are they unreleased? | 19:32 |
| gary-sprint | Should we release zope.contenttype as is, and then should I develop on zope.publisher trunk? | 19:32 |
| gary-sprint | I was proceeding with making a 2.9 branch and making changes there | 19:32 |
| tlotze | ugh | 19:32 |
| tlotze | sorry | 19:33 |
| tlotze | I intended to release a bunch of things together | 19:33 |
| tlotze | I realize I should have kept the stuff in branches until that point. | 19:33 |
| gary-sprint | also, I didn't check to see if you were the one who had made changes to setDefaultSkin, but I'd love to run my change by you if you are familiar with it | 19:33 |
| *** alga has quit IRC | 19:33 | |
| gary-sprint | yeah, branches would have been nice :-) | 19:33 |
| tlotze | I principle, that stuff may be released at any time. | 19:33 |
| gary-sprint | so are there more packages that will need to be released? | 19:34 |
| tlotze | Hm, I can have a look at the change even though I didn't do anything about setDefaultSkin. | 19:34 |
| tlotze | I'll look up my notes about which packages go together. | 19:34 |
| gary-sprint | ok thanks | 19:34 |
| tlotze | How urgent is looking at your change? I won't have time for it until tomorrow morning (GMT). | 19:35 |
| gary-sprint | tlotze: pretty urgent, but I can make a release without it if need be: I've already gotten Barry Warsaw and another good engineer here to look at it. You had the zope.publisher context, so it would be nice to get your review. It's essentially a one line change, plus indenting a block, but you do have to think about it | 19:36 |
| tlotze | OK, show me now. | 19:37 |
| tlotze | Maybe it helps anyway. | 19:37 |
| tlotze | I've got a few minutes left... | 19:38 |
| gary-sprint | tlotze: this is a sketch; I was in the middle of writing the tests, so I had not actually made the code changes yet. So, this is my intent: http://paste.ubuntu.com/299158/ | 19:38 |
| * tlotze goes looking | 19:38 | |
| gary-sprint | I think I might actually remove the try: except around the skin(request) | 19:39 |
| gary-sprint | because my check should make it unnecessary | 19:39 |
| gary-sprint | the problem is that, if the skin is an interface, and you have a request that already implements the skin, things fall over badly. While that's perhaps an odd case, in general I think that adapting request to an interface to have it return an interface is a bit insane. | 19:40 |
| *** ignas has quit IRC | 19:41 | |
| tlotze | At first glance, it does look cleaner and a lot more expressive. | 19:41 |
| gary-sprint | Having a request already implement the skin is not all that odd really: I'd argue it is reasonable to hardcode the skin interface on the request if it makes sense for your app. | 19:41 |
| gary-sprint | ok cool. Of course, I intend to write a test showing the behavior, and I won't proceed if the tests fail. | 19:42 |
| tlotze | However, why would your change make the try-except unnecessary? I'm not too familiar with that area of code, in fact... Is there some guarantee that if the skin is an interface, the call will succeed? | 19:43 |
| gary-sprint | if the skin is not an interface, you mean? | 19:44 |
| tlotze | Cannot the adapter lookup fail? | 19:44 |
| tlotze | right | 19:44 |
| tlotze | One corner too many to think around ;o) | 19:44 |
| gary-sprint | :-) | 19:44 |
| tlotze | How's test coverage for the code in question? | 19:45 |
| gary-sprint | if, coming into the ``skin = skin(request)`` line, the skin is not an interface, then it is supposed to be a factory. If the factory fails, AFAIK it is appropriate to blow up: the factory configured to provide a default skin did not do so, and that should be an error. | 19:46 |
| tlotze | btw, I'm currently running compat tests against everything mentioned in ztk.cfg with only zope.contenttype and zope.publisher taken from trunk... | 19:46 |
| tlotze | true | 19:46 |
| tlotze | But then, isn't it possible to fix the situation that a request which already implements the skin makes things falls over? | 19:47 |
| gary-sprint | tests: there's a skinnable.txt that seems pretty good. I had a bit of a hard time following it, but it is reasonably thorough. | 19:47 |
| gary-sprint | possible to fix the situation: what do you mean? | 19:48 |
| gary-sprint | I mean, what do you have in mind? | 19:48 |
| tlotze | nothing specific, I just noticed that your explanation sounds like a work-around, so I wonder on a rather general level why we have to work around things | 19:51 |
| tlotze | Why cannot skin(request) just do the right thing in case the request implements the skin already? | 19:52 |
| tlotze | re releases: you can release just zope.contenttype and zope.publisher and everything will be fine | 19:53 |
| gary-sprint | tlotze: re releases: ok cool thanks! | 19:53 |
| tlotze | I did touch a bunch of packages in the course of the same refactoring but they will be OK due to BBB imports, and I'll release them later. Maybe more similar changes accumulate for them as I have some other refactorings going. | 19:54 |
| gary-sprint | skin(request) will always return the request if the skin is an interface and if the request implements the interface. That's just how zope.interface works | 19:54 |
| tlotze | right | 19:55 |
| gary-sprint | it's the adaptation short cut | 19:55 |
| gary-sprint | otherpackages: ok cool | 19:55 |
| tlotze | I'll have to leave in a couple of minutes. | 19:57 |
| gary-sprint | understood. thanks for your help. So, are you relatively convinced by my change, then? | 19:58 |
| tlotze | yes | 19:58 |
| gary-sprint | cool thanks | 19:58 |
| tlotze | to the extent that I think I understand the problem ;o) | 19:58 |
| gary-sprint | heh, completely understood | 19:58 |
| gary-sprint | ok, I'll make the contenttype release in a sec | 19:58 |
| gary-sprint | thanks again! | 19:58 |
| tlotze | no problem whatsoever | 19:59 |
| tlotze | bye | 19:59 |
| gary-sprint | bye | 19:59 |
| *** tarek has quit IRC | 20:00 | |
| *** junkafarian has quit IRC | 20:05 | |
| *** aaronv has quit IRC | 20:07 | |
| *** mcdonc has quit IRC | 20:12 | |
| *** agroszer has quit IRC | 20:18 | |
| *** agroszer_ has joined #zope3-dev | 20:18 | |
| *** baijum has quit IRC | 20:28 | |
| *** sunoano has quit IRC | 20:42 | |
| *** agroszer has joined #zope3-dev | 20:46 | |
| *** agroszer_ has quit IRC | 20:53 | |
| *** allisterb_ has quit IRC | 21:05 | |
| *** jpcw has joined #zope3-dev | 21:06 | |
| *** afd__ has quit IRC | 21:14 | |
| *** JaRoel|4D has joined #zope3-dev | 21:14 | |
| *** JaRoel|4_ has joined #zope3-dev | 21:16 | |
| *** matthal has joined #zope3-dev | 21:19 | |
| *** matthal has quit IRC | 21:37 | |
| *** JaRoel|4D has quit IRC | 21:38 | |
| *** aaronv has joined #zope3-dev | 21:38 | |
| *** mcdonc has joined #zope3-dev | 21:44 | |
| *** hathawsh is now known as hath|away | 21:47 | |
| *** __mac__ has joined #zope3-dev | 21:47 | |
| *** __mac__ has quit IRC | 21:56 | |
| *** junkafarian has joined #zope3-dev | 22:11 | |
| *** hath|away is now known as hathawsh | 22:11 | |
| *** dunny has joined #zope3-dev | 22:18 | |
| *** agroszer has quit IRC | 22:22 | |
| *** sm has joined #zope3-dev | 22:24 | |
| sm | g'day all | 22:24 |
| sm | just wanted to say: latest zope/zodb/ztk release looks really impressive so far, well done zope devs | 22:24 |
| *** aaronv has quit IRC | 22:32 | |
| *** hathawsh is now known as hath|away | 22:35 | |
| *** malthe has quit IRC | 22:48 | |
| *** mgedmin has joined #zope3-dev | 22:58 | |
| *** aaronv has joined #zope3-dev | 23:03 | |
| *** matthal has joined #zope3-dev | 23:17 | |
| *** J1m_ has joined #zope3-dev | 23:23 | |
| *** tarek has joined #zope3-dev | 23:30 | |
| *** J1m has quit IRC | 23:33 | |
| *** gary-sprint has quit IRC | 23:48 | |
| *** pcardune has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!