| *** J1m has quit IRC | 00:38 | |
| *** J1m has joined #zodb | 00:49 | |
| *** J1m has quit IRC | 01:02 | |
| *** povbot has joined #zodb | 06:50 | |
| *** jamadden has quit IRC | 08:09 | |
| *** jensens has joined #zodb | 10:20 | |
| *** jamadden has joined #zodb | 13:25 | |
| *** J1m has joined #zodb | 15:20 | |
| J1m | We should probably revert my RelStorage changes. | 16:08 |
|---|---|---|
| jamadden | because you're going in a different direction in ZODB itself? | 16:14 |
| jamadden | based on those comments in ZODB#56 | 16:15 |
| J1m | More based on our dicussion about IMVCC. | 16:15 |
| jamadden | which you just referenced in ZODB#56, so it's all very meta | 16:15 |
| J1m | :) | 16:16 |
| J1m | Yes | 16:16 |
| J1m | But I also just discussed other things, like making transaction boundaries more explicit. | 16:16 |
| jamadden | true. which I think is a good thing | 16:16 |
| J1m | (I'm drafting a message to python-transaction about that. | 16:16 |
| J1m | or maybe not... | 16:30 |
| *** J1m_ has joined #zodb | 17:29 | |
| *** J1m_ has left #zodb | 17:29 | |
| *** aclark has joined #zodb | 17:45 | |
| jamadden | Is it OK to update the ZODB dependency in RelStorage for 1.7.0? Currently it's at ZODB3 >= 3.7.0 (!), but tests are broken when 4.3.0 is used, and PyPy support needs at least 4.2.0. These can be worked around in various ways, but it's nicer to update the dep | 18:02 |
| J1m | Not sure what you're proposing, but sure. :) | 18:03 |
| jamadden | proposing to update RelStorage 1.7.0 to depend on ZODB >= 4.3.0 (instead of ZODB3>3.7.0) | 18:04 |
| J1m | +1 | 18:04 |
| jamadden | cool. on it. | 18:05 |
| J1m | But what is 1.7.0 for? | 18:08 |
| J1m | My opinion is that we should back out the changes I made. | 18:08 |
| J1m | Unfortunately, I don't think I can do the IMVCCStorage everywhere work soon. | 18:09 |
| J1m | I think it's going to be rather involved. | 18:09 |
| jamadden | I'm fine with that. So that would just leave 1.7.0/master as the place to land the updates that were too much for 1.6.0, like PyPy support, better exceptions, various other extent PRs | 18:09 |
| J1m | which makes me think that RelStorage should grow an upper bound to prevent it being used with ZODB5. | 18:10 |
| jamadden | I might have some time to contribute to helping with IMVCCStorage if you can lay out a plan, but I suspect my time may better be spent on something like bringing Python 3 support to RelStorage | 18:10 |
| jamadden | good point | 18:10 |
| J1m | The tricky part of the adapter will be getting the invalidartions right. | 18:11 |
| J1m | Especially the plumbing. | 18:11 |
| J1m | Maybe it won't be too bad, but I really want to finish a bunch of other stuff first. | 18:12 |
| jamadden | any particular way you want to handle reverting the change to relstorage? | 18:12 |
| J1m | +1 on Python 3 support for RelStorage, to say nothing of CI. | 18:12 |
| J1m | I would use git revert commit undoing transactions. Do you know of an easier way? | 18:13 |
| J1m | I can do this if you want. | 18:14 |
| jamadden | I do not know an easier way. I've never actually "reverted" something in git that had commits on top of it (other than manually), even if they don't conflict, so that would be new to me. I'd be happy to take a crack at it and learn though | 18:15 |
| J1m | There's a relatively easy way to do it in a local repo. but now that it's in github that won't work. | 18:16 |
| J1m | I'll take care of it using git revert. | 18:16 |
| J1m | I was hoping for some automatiin in github, but I dn't see anything in the ui. Og well. | 18:17 |
| jamadden | That's what I meant, I've done it locally but not after a push. | 18:17 |
| jamadden | If you come up with a nice command to to it, I'd appreciate seeing it | 18:17 |
| * J1m seens a revert button on the pr... | 18:18 | |
| J1m | ha! | 18:18 |
| jamadden | ha, no way! | 18:18 |
| J1m | way! | 18:19 |
| J1m | https://github.com/zodb/relstorage/pull/34 | 18:19 |
| J1m | Of course, one of my changes was needed ti get tests to pass. :) | 18:20 |
| J1m | s/ti/to | 18:20 |
| jamadden | Yes, the 'doctest' thing for one. If you want to go ahead and merge it, I'm working on a PR anyway to fix the remaining tests (that were still failing) and I can roll re-fixing doctest, etc, in to that | 18:22 |
| J1m | k | 18:22 |
| J1m | done | 18:23 |
| *** J1m has quit IRC | 19:15 | |
| *** aclark has quit IRC | 21:20 | |
| *** J1m has joined #zodb | 21:25 | |
| *** jamadden is now known as jamadden_away | 21:25 | |
| *** jamadden_away is now known as jamadden | 21:40 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!