| jamadden | A ZODB Connection is documented as not being thread-safe and must be used only by a single thread at a time. In IMVCC, each Connection has a unique storage object. So the storage object is used only by a single thread. So there's really not much point in RelStorage keeping thread locks around its methods, is there? | 00:01 |
|---|---|---|
| jamadden | There are a tiny handful (8) of ZODB test cases that assume the storage is thread safe, but other than that I don't see any problems | 00:41 |
| *** J1m has quit IRC | 01:03 | |
| *** J1m has joined #zodb | 01:11 | |
| *** J1m has quit IRC | 01:33 | |
| *** jamadden has quit IRC | 04:59 | |
| *** J1m has joined #zodb | 06:18 | |
| *** J1m has quit IRC | 06:36 | |
| *** jensens has joined #zodb | 10:19 | |
| *** jamadden has joined #zodb | 10:46 | |
| *** J1m has joined #zodb | 15:33 | |
| *** povbot has joined #zodb | 16:04 | |
| *** jensens has quit IRC | 21:37 | |
| jamadden | The changed method signature of ZODB.tests.ConflictResolution.ConflictResolvingStorage.checkResolve() in 4.4.0 broke RelStorage tests. 😢 | 22:13 |
| J1m | hm | 22:14 |
| jamadden | it's not a big deal, just surprising. | 22:14 |
| J1m | That's weird. It looks backward compatible to me. | 22:17 |
| J1m | The old function took no arguments and demonstrated handling of a resolvable conflict. | 22:17 |
| J1m | The new function takes a resolvable argument that defaults to true. | 22:18 |
| jamadden | We override checkResolve(self), and but ZODb.tests.ConflictResolution.py line 90 in checkUnresolvable calls self.checkResolve(False) | 22:18 |
| jamadden | I think we mean 'resolve' in different ways | 22:18 |
| jamadden | so the RelStorage function was unintentionally, as far as I can see, shadowing the ZODB function | 22:19 |
| J1m | This is why inheritance interface is an oxymoron. | 22:19 |
| jamadden | I figure that since RS 2.0b1 *just* came out and bumped the min supported ZODB version to 4.3, there won't be any problem if 2.0b2 goes right ahead and bumps it to 4.4 and implements the new protocol | 22:27 |
| J1m | +1 | 22:56 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!