| jamadden | Nice work on ZEO and ZODB this week! | 01:07 |
|---|---|---|
| J1m | Thanks. | 01:07 |
| J1m | making progress | 01:07 |
| J1m | working on object-level locks for ZEO atm. | 01:07 |
| jamadden | is a 4.4.2 release blocked on anything? As I understand it, I need the fixes there to properly implement the new protocol in RelStorage | 01:07 |
| jamadden | nice! I didn't realize that was actually on the table | 01:08 |
| J1m | I'll make a 4.4.2 release shortly... | 01:09 |
| jamadden | no rush on my account. I'm just trying to schedule out milestones. I think I'll push that update off another milestone anyway, 2.0b2 is looking large as it is | 01:10 |
| J1m | done | 01:11 |
| jamadden | cool, thanks | 01:12 |
| *** J1m has quit IRC | 02:02 | |
| *** agroszer has joined #zodb | 07:44 | |
| *** jamadden has quit IRC | 08:09 | |
| *** jamadden has joined #zodb | 13:25 | |
| *** jensens has joined #zodb | 13:53 | |
| *** agroszer has quit IRC | 14:33 | |
| *** jamadden has left #zodb | 14:52 | |
| *** agroszer has joined #zodb | 15:40 | |
| *** J1m has joined #zodb | 16:16 | |
| *** agroszer has quit IRC | 16:34 | |
| *** agroszer has joined #zodb | 19:52 | |
| *** agroszer has quit IRC | 21:01 | |
| *** jamadden has joined #zodb | 21:18 | |
| jamadden | It looks to me like ZODB.tests.StorageTestBase:handle_all_serials hasn't been updated for the new commit protocol, it still expects 2-tuples (when called from _dostore, which passes in the value of storage.tpc_vote, which now returns a simple set of OIDs). | 21:30 |
| J1m | That | 21:35 |
| J1m | That's odd. | 21:35 |
| J1m | Oh | 21:35 |
| J1m | no | 21:35 |
| J1m | In ZODB 4, supposedly, both the old and new protocols are supported. | 21:36 |
| jamadden | The code for handle_all_serials is the same in ZODB 4.4.2, 5.0.0a5 and git master | 21:36 |
| J1m | But it wasn't tested with any storages that implement the new protocols. | 21:36 |
| J1m | Then I think there's something you're missing, becase the tests pass with ZEO and ZODB 5. | 21:37 |
| jamadden | RelStorage has tests that (deliberately) generate conflicts and use _dostore, but I guess ZODB doesn't in a5 or git master or they would blow up the same way | 21:37 |
| J1m | Thanks for the pr | 21:58 |
| jamadden | are the ZODB 4 releases just coming from the "4" branch? unfortunately that one commit doesn't cherry-pick cleanly onto 4 so we'll need a new pr | 22:01 |
| J1m | yes | 22:06 |
| J1m | I didn't notice that that was master. | 22:07 |
| J1m | It shouldn't have sniffed. | 22:08 |
| J1m | ZODB 5 requires the new style. | 22:08 |
| jamadden | Right, so I guess I want to merge that change to 4 and a non-sniffy change to master | 22:08 |
| J1m | yup | 22:09 |
| *** J1m has quit IRC | 22:14 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!