| *** jensens has quit IRC | 01:27 | |
| *** jamadden has quit IRC | 08:09 | |
| *** agroszer has joined #zodb | 08:52 | |
| *** agroszer has quit IRC | 09:12 | |
| *** jensens has joined #zodb | 12:03 | |
| *** jamadden has joined #zodb | 13:25 | |
| *** J1m has joined #zodb | 14:45 | |
| *** aclark has joined #zodb | 15:06 | |
| *** J1m has quit IRC | 15:57 | |
| *** aclark has quit IRC | 16:56 | |
| *** aclark has joined #zodb | 17:53 | |
| *** aclark has quit IRC | 19:04 | |
| *** jensens has quit IRC | 19:05 | |
| *** jmuchemb has joined #zodb | 19:10 | |
| *** J1m has joined #zodb | 20:29 | |
| jmuchemb | Hello Jim, the next step about the new commit protocol is to decide whether we drop support for the old one in ZODB5 | 21:32 |
|---|---|---|
| jmuchemb | do you mean prefer we discuss this on the ML ? | 21:32 |
| jmuchemb | (oops s/mean//) | 21:32 |
| J1m | I thought this was already done. | 21:33 |
| J1m | afaict, ZODB5 already requires the new protocol. | 21:33 |
| jmuchemb | there's indeed no test anymore for the old protocol, but the code still supports it | 21:34 |
| jmuchemb | I just want confirmation that I can now cleanup and remove support for the old one | 21:34 |
| J1m | then lets stop "supporting" things that aren't tested. :) | 21:35 |
| jmuchemb | great | 21:35 |
| jmuchemb | a last question about IMultiCommitStorage: | 21:36 |
| jmuchemb | Currently, it's unused. Personally, I always found it overkill, but I think your idea is to declare it on all storage implementation (FileStorage, etc.) | 21:37 |
| J1m | Yes. I like being explicit about contracts and it provides an opportunity to fail early. | 21:38 |
| J1m | I declare it for ZEO. I let the declaration slide on your PR. I probably shouldn't have. | 21:39 |
| J1m | I think we should require the interface when we stop supporting the old commit protocol. | 21:40 |
| jmuchemb | what about ZODB.ConflictResolution.ResolvedSerial ? can I just delete the "ResolvedSerial = b'rs'" line ? | 21:41 |
| J1m | I guess :) | 21:41 |
| jmuchemb | ok I think I have all the information. I don't know when I'll submit something. I still have urgent tasks for a customer. Maybe 1 week. | 21:44 |
| *** agroszer has joined #zodb | 21:45 | |
| J1m | OK. Thanks a lot for all your work. | 21:45 |
| jmuchemb | have you seen https://travis-ci.org/zopefoundation/ZODB/jobs/142289195 ? | 21:45 |
| jmuchemb | I think the random failures we sometimes have pypy are not pypy bugs. At least the one I had in one of my PR was really a bug in my code. | 21:47 |
| jmuchemb | pypy seems more sensitive to race conditions | 21:48 |
| J1m | That's weird. | 21:49 |
| J1m | There's a pretty consistent failure in those builds. | 21:49 |
| J1m | Oh wait, I was looking at the wrong thing. | 21:52 |
| J1m | I find travis a bit hard to navigate still. | 21:52 |
| J1m | Generally, I ignore intermittent failures unless a) I see the same failure often and b) I feel like taking the time to run it dowm. | 21:53 |
| J1m | In particular, I'll try running the test 99 times by itself, and if it fails, I dig futher. | 21:54 |
| J1m | further | 21:54 |
| *** agroszer has quit IRC | 22:00 | |
| *** J1m has quit IRC | 22:38 | |
| *** jmuchemb has quit IRC | 22:49 | |
| *** J1m has joined #zodb | 23:12 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!