*** LeoRochael has quit IRC | 00:00 | |
*** fdrake has quit IRC | 00:02 | |
*** crazydiamond has joined #zope | 00:49 | |
*** Spanktar has quit IRC | 00:51 | |
*** supton has joined #zope | 00:55 | |
*** m8 has quit IRC | 00:56 | |
*** tiwula has joined #zope | 01:01 | |
*** LeoRochael has joined #zope | 01:05 | |
*** fdrake has joined #zope | 01:29 | |
*** J1m has quit IRC | 01:45 | |
*** evilbungle has quit IRC | 01:53 | |
*** _mup_ has quit IRC | 02:00 | |
*** _mup_ has joined #zope | 02:01 | |
*** supton has quit IRC | 02:03 | |
*** J1m has joined #zope | 02:11 | |
*** tiwula has quit IRC | 02:13 | |
*** J1m has quit IRC | 02:13 | |
*** River-Rat has joined #zope | 02:18 | |
*** River_Rat has quit IRC | 02:22 | |
*** sm has quit IRC | 02:35 | |
*** phux has quit IRC | 02:41 | |
*** mcdonc has quit IRC | 02:49 | |
*** mcdonc has joined #zope | 02:51 | |
*** sm_ has joined #zope | 02:54 | |
*** River_Rat has joined #zope | 04:04 | |
*** River-Rat has quit IRC | 04:06 | |
*** thetet has quit IRC | 04:07 | |
*** nande has quit IRC | 04:09 | |
*** mr_jolly has quit IRC | 04:34 | |
*** crazydiamond has quit IRC | 04:52 | |
*** LeoRochael has quit IRC | 05:20 | |
*** zenwryly has quit IRC | 05:34 | |
*** zenwryly has joined #zope | 05:35 | |
*** zenwryly has quit IRC | 05:38 | |
*** zenwryly has joined #zope | 05:38 | |
*** zenwryly has quit IRC | 05:43 | |
*** Arfrever has quit IRC | 06:01 | |
*** zenwryly has joined #zope | 06:05 | |
*** zenwryly has quit IRC | 06:08 | |
*** zenwryly has joined #zope | 06:09 | |
*** roq_ has quit IRC | 06:31 | |
*** KageSenshi has quit IRC | 06:42 | |
*** KageSenshi has joined #zope | 06:43 | |
*** kosh has quit IRC | 06:50 | |
*** River-Rat has joined #zope | 07:09 | |
*** River_Rat has quit IRC | 07:12 | |
*** __mac__ has joined #zope | 07:18 | |
*** __mac__ has quit IRC | 07:21 | |
*** roq_ has joined #zope | 07:23 | |
*** __mac__ has joined #zope | 07:59 | |
*** __mac__ has quit IRC | 08:09 | |
*** AnneGilles_ has quit IRC | 09:15 | |
*** __mac__ has joined #zope | 09:21 | |
*** AnneGilles has joined #zope | 09:22 | |
*** agroszer has joined #zope | 09:31 | |
*** tisto has joined #zope | 09:42 | |
*** River_Rat has joined #zope | 09:47 | |
*** River-Rat has quit IRC | 09:49 | |
*** yvl has joined #zope | 10:15 | |
*** zagy has joined #zope | 10:22 | |
*** avoinea has joined #zope | 10:28 | |
*** MrTango has joined #zope | 10:44 | |
*** goschtl has joined #zope | 10:55 | |
*** mr_jolly has joined #zope | 10:58 | |
*** sunew has joined #zope | 11:00 | |
*** AnneGilles_ has joined #zope | 11:03 | |
*** AnneGilles has quit IRC | 11:05 | |
*** AnneGilles_ is now known as AnneGilles | 11:05 | |
*** maurits has joined #zope | 11:07 | |
*** fredvd has joined #zope | 11:54 | |
*** RichyB has joined #zope | 11:59 | |
*** miano_ has quit IRC | 11:59 | |
*** evilbungle has joined #zope | 12:08 | |
*** evilbungle has joined #zope | 12:08 | |
*** miano_ has joined #zope | 12:16 | |
*** mr_jolly has left #zope | 12:34 | |
*** eperez has joined #zope | 12:36 | |
*** mitchell`off is now known as mitchell` | 13:09 | |
*** mr_jolly has joined #zope | 13:41 | |
*** maurits has quit IRC | 13:41 | |
*** maurits has joined #zope | 14:03 | |
*** __mac__ has quit IRC | 14:03 | |
*** __mac__ has joined #zope | 14:04 | |
*** __mac__ has quit IRC | 14:05 | |
*** __mac__ has joined #zope | 14:08 | |
*** avoinea has quit IRC | 14:18 | |
*** avoinea has joined #zope | 14:21 | |
*** fredvd has quit IRC | 14:34 | |
*** __mac__ has quit IRC | 14:52 | |
*** __mac__ has joined #zope | 14:53 | |
*** __mac__ has quit IRC | 14:57 | |
*** benji has joined #zope | 14:59 | |
*** miano_ has quit IRC | 15:05 | |
*** __mac__ has joined #zope | 15:06 | |
*** miano_ has joined #zope | 15:08 | |
*** agroszer has quit IRC | 15:37 | |
_mup_ | Branch | 15:47 |
---|---|---|
*** tisto has quit IRC | 15:49 | |
*** zagy has quit IRC | 15:59 | |
*** RichyB has quit IRC | 16:04 | |
*** evilbungle has quit IRC | 16:05 | |
*** evilbungle has joined #zope | 16:05 | |
*** mr_jolly has quit IRC | 16:07 | |
*** J1m has joined #zope | 16:19 | |
*** nande has joined #zope | 16:19 | |
*** miano_ has quit IRC | 16:29 | |
*** menesis has joined #zope | 16:30 | |
*** miano_ has joined #zope | 16:46 | |
*** fredvd has joined #zope | 16:50 | |
*** RichyB has joined #zope | 16:51 | |
*** fredvd has quit IRC | 16:55 | |
*** evilbungle has quit IRC | 16:55 | |
*** evilbungle has joined #zope | 16:56 | |
*** fredvd has joined #zope | 16:56 | |
*** fredvd has quit IRC | 17:00 | |
*** fredvd has joined #zope | 17:05 | |
*** avoinea has quit IRC | 17:06 | |
*** mr_jolly has joined #zope | 17:07 | |
*** agroszer has joined #zope | 17:10 | |
*** avoinea has joined #zope | 17:15 | |
*** leo2007 has joined #zope | 17:29 | |
*** sunew has quit IRC | 17:41 | |
*** LeoRochael has joined #zope | 17:47 | |
*** __mac__ has quit IRC | 17:48 | |
*** mr_jolly has quit IRC | 18:12 | |
*** mr_jolly has joined #zope | 18:12 | |
*** LeoRochael has quit IRC | 18:20 | |
*** avoinea has quit IRC | 18:23 | |
*** jakke has quit IRC | 18:23 | |
*** goschtl has quit IRC | 18:40 | |
*** maurits has quit IRC | 18:41 | |
*** kosh has joined #zope | 18:41 | |
*** agroszer has quit IRC | 18:53 | |
*** tiwula has joined #zope | 19:17 | |
*** miano_ has quit IRC | 19:28 | |
*** miano_ has joined #zope | 19:29 | |
*** roq_ has quit IRC | 19:33 | |
*** roq_ has joined #zope | 19:33 | |
*** m8 has joined #zope | 19:34 | |
*** m8 has quit IRC | 19:37 | |
*** m8 has joined #zope | 19:42 | |
*** Spanktar has joined #zope | 19:57 | |
*** zenwryly has quit IRC | 20:00 | |
*** zenwryly has joined #zope | 20:00 | |
*** eperez has quit IRC | 20:01 | |
*** zenwryly has quit IRC | 20:01 | |
*** zenwryly has joined #zope | 20:01 | |
*** zenwryly has quit IRC | 20:04 | |
*** zenwryly has joined #zope | 20:04 | |
*** agroszer has joined #zope | 20:06 | |
*** menesis has quit IRC | 20:16 | |
*** mitchell` is now known as mitchell`off | 20:22 | |
*** leo2007 has quit IRC | 20:23 | |
*** morphex has joined #zope | 20:27 | |
*** evilbungle has quit IRC | 20:36 | |
*** zenwryly has quit IRC | 20:38 | |
*** zenwryly has joined #zope | 20:38 | |
*** RichyB has quit IRC | 20:41 | |
*** MrTango has quit IRC | 20:50 | |
*** Darni has joined #zope | 20:58 | |
*** RichyB has joined #zope | 20:58 | |
Darni | hey guys... I've found a problem in zc.lockfile, and I'm not sure where's the right place to report it | 20:58 |
*** mcdonc has quit IRC | 21:06 | |
*** mcdonc has joined #zope | 21:07 | |
J1m | Darni, what problem? | 21:08 |
Darni | I'm looking at: http://svn.zope.org/zc.lockfile/trunk/src/zc/lockfile/__init__.py?rev=121133&view=markup | 21:09 |
Darni | in, LockFile.__init__ the lock is opened in mode w+ | 21:09 |
Darni | that makes a truncate so even if the file was locked already, the pid inside is overwritten | 21:09 |
Darni | so, if two process try to get a lock, the second fails (which is fine), but gets an empty pid when trying to generate the logged message | 21:10 |
J1m | Good point. | 21:10 |
J1m | sp probably should be r+ | 21:10 |
J1m | s/sp/so | 21:10 |
Darni | yes, I think so | 21:11 |
Darni | I didn't check thoroughly, but ceratinly w+ is a problem | 21:11 |
J1m | Looks worth fixing. I look forward to moving that to github and giving it an issue tracker. | 21:12 |
J1m | any interest in working up a test? | 21:12 |
*** KageSenshi has quit IRC | 21:13 | |
Darni | if it's easy to get the test environment up, I'm fine with that (I'm using zc.lockfile as a dependency of a dependency of a company django project, so I'm not familiar with it :) ) | 21:14 |
J1m | as long as you're ok w buildout, it should be easy enough. | 21:15 |
Darni | I didn't even know where the issue tracker was :) | 21:15 |
J1m | Just build it and run bin/test. | 21:15 |
J1m | I don't think it has an issue tracker at this point. | 21:15 |
J1m | It's soo small and boring :) | 21:15 |
*** agroszer has quit IRC | 21:16 | |
J1m | For now, I added an XXX <shrug> | 21:17 |
Darni | is it on github? I just found some svn repo when googling | 21:17 |
J1m | svn co svn://svn.zope.org/repos/main/zc.lockfile/trunk | 21:17 |
J1m | wget buildout.org/bootstrap.py | 21:17 |
J1m | python bootstrap.py | 21:18 |
J1m | bin/buildout | 21:18 |
J1m | bin/test | 21:18 |
J1m | :) | 21:18 |
J1m | It will move to github soonish | 21:18 |
J1m | Thanks for pointing this out. | 21:20 |
Darni | np... What I'm thinking is that the bug is easy to reproduce from two python shells, but I'll need to create two processes to make a test case. Do you need tests to be portable? | 21:22 |
*** KageSenshi has joined #zope | 21:23 | |
J1m | make it work in linux or macos w subprocess. | 21:23 |
Darni | sounds good | 21:23 |
J1m | If it doesn't work on windows, maybe I'll skip running it there. Not sure how this works on windows :) | 21:23 |
J1m | It may work, I don't remember. | 21:24 |
J1m | I only run windows to test stuff :) | 21:24 |
*** RichyB has quit IRC | 21:25 | |
Darni | I don't have windows here, so I'll try to make it run on linux with subprocess | 21:26 |
J1m | good enough. | 21:26 |
*** supton has joined #zope | 21:31 | |
*** tiwula has quit IRC | 21:50 | |
*** roq_ has quit IRC | 21:53 | |
*** roq_ has joined #zope | 21:54 | |
*** les_sylvains has joined #zope | 21:57 | |
*** fdrake has quit IRC | 22:00 | |
*** menesis has joined #zope | 22:00 | |
*** les_sylvains has quit IRC | 22:19 | |
*** fdrake has joined #zope | 22:26 | |
*** mr_jolly_ has joined #zope | 22:30 | |
*** mr_jolly__ has joined #zope | 22:31 | |
*** mr_jolly_ has quit IRC | 22:31 | |
*** mr_jolly has quit IRC | 22:31 | |
*** mr_jolly__ is now known as mr_jolly | 22:31 | |
*** tiwula has joined #zope | 22:40 | |
*** nande has quit IRC | 22:52 | |
*** supton has quit IRC | 22:56 | |
*** supton has joined #zope | 23:01 | |
Darni | J1m: ok, I have a test; r+ doesn't fix it (it fails when there's no previous lock), but "a+" seems ok. Other test started failing, but because the text appears to be written with the bug in mind: http://pastebin.com/zmVMqKJM | 23:02 |
Darni | how do you prefer me to submit this? I have the svn diff output if that helps | 23:03 |
*** nande has joined #zope | 23:07 | |
J1m | Darni, svn diff to jim@zope.com will do. Do you mind fixing theo ther tests too? | 23:08 |
J1m | The less work I have to do to review, the quicker it will get merged and released. :) | 23:09 |
Darni | ok, done :) | 23:14 |
J1m | Looks good. Thanks. I'll get this out this afternoon. | 23:17 |
Darni | nice! ok, bye! | 23:46 |
*** Darni has left #zope | 23:57 | |
*** supton has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!