philiKON_ | TresEquis is reviving zope.bobo? | 00:01 |
---|---|---|
philiKON_ | J1m: re egg day: theuni, uwe and I were discussing a cleanup sprint at europython | 00:03 |
philiKON_ | J1m: to be scheduled at the end fo september | 00:03 |
philiKON_ | cleanup as in dependency cleanup | 00:03 |
TresEquis | philiKON_: I just tried making an egg of it, which led me to the sulphurous hairball that is download.zope.org/distributioun | 00:04 |
fsufitch | anybody here familiar with i18n? | 00:05 |
fsufitch | i need some help with it | 00:05 |
lisppaste6 | fsufitch pasted "Traceback" at http://paste.lisp.org/display/45180 | 00:06 |
srichter | fsufitch: I am here | 00:06 |
fsufitch | k good :) | 00:06 |
Lumiere | srichter: see traceback pasted above ;) | 00:06 |
*** greenman has quit IRC | 00:07 | |
*** jodok_ has joined #zope3-dev | 00:07 | |
srichter | I have no idea what this error is | 00:07 |
srichter | it will require some serious debugging | 00:07 |
srichter | first you have to find the location in the page template where this happens | 00:07 |
fsufitch | i did | 00:07 |
*** greenman has joined #zope3-dev | 00:08 | |
fsufitch | <h3 i18n:translate=""> | 00:08 |
fsufitch | Import Competencies | 00:08 |
fsufitch | </h3> | 00:08 |
fsufitch | weait no | 00:08 |
Lumiere | that isn't it, it's a piece generated from a zcml | 00:08 |
srichter | did you specify an i18n domain in the scope of the call? | 00:08 |
*** jsadjohnson has quit IRC | 00:08 | |
fsufitch | no | 00:09 |
fsufitch | although i barely have a notion of what u mean... | 00:09 |
fsufitch | this was in an ftest | 00:09 |
*** RaFromBRC|lunch is now known as RaFromBRC | 00:09 | |
fsufitch | where i just did getLink("Import Competencies").click() | 00:09 |
srichter | well, where in the template is the "i18n:domain" decalration (btw, I am just guessing that this might be the problem) | 00:10 |
fsufitch | in the <html> | 00:10 |
lisppaste6 | Lumiere annotated #45180 with "page zcml" at http://paste.lisp.org/display/45180#1 | 00:10 |
srichter | mh, then I have no idea | 00:11 |
fsufitch | d'oh | 00:12 |
srichter | you have to use the debugger to see what's going on | 00:12 |
Lumiere | k -> eldar ;) | 00:12 |
TresEquis | the dance to register a custom publication object looks *way* too hard | 00:16 |
*** schwendinger has quit IRC | 00:20 | |
*** jodok has quit IRC | 00:23 | |
TresEquis | J1m: did you ever have zope.bobo actually wired up into a server? Or were you just playing around in doctests? | 00:24 |
*** timte has joined #zope3-dev | 00:26 | |
*** Ariel_Calzada has quit IRC | 00:29 | |
*** cursor has quit IRC | 00:33 | |
*** jsadjohnson has joined #zope3-dev | 00:34 | |
*** lucielejard has quit IRC | 00:35 | |
*** jsadjohnson has quit IRC | 00:43 | |
J1m | philiKON_, that sounds good. | 00:44 |
J1m | TresEquis, I thought I hooked it up w wsgi, but I don't remember for sure. | 00:45 |
TresEquis | I get the feeling that there is about five times too much machinery there as needed | 00:45 |
J1m | The dance to set this up with zope.app.server or zope.app.twisted is a mess. | 00:45 |
TresEquis | for instance, why is the publication not looked up as an adapter to the request | 00:45 |
J1m | Could be. | 00:46 |
philiKON_ | publication and request are usually created together | 00:46 |
*** Ariel_Calzada has joined #zope3-dev | 00:46 | |
philiKON_ | at least that's how it is in plain zope 3 | 00:46 |
TresEquis | Why? | 00:46 |
philiKON_ | why should i know, i didn't write that :) | 00:47 |
TresEquis | it looks as though it tries to reuse the publication *instance* across requests, which is just silly | 00:47 |
TresEquis | if IPublication were and adapter interface | 00:47 |
TresEquis | then all its API would lose the 'request' argument | 00:47 |
J1m | I don't really remember the details and can't look atm. | 00:47 |
TresEquis | and the publisher would just adapt the request | 00:47 |
J1m | I'm sure major improvements could be made. | 00:47 |
philiKON_ | that much is certain | 00:47 |
TresEquis | we could move all the silly traversal logic out of the request, too | 00:47 |
*** philiKON_ is now known as philiKON | 00:48 | |
TresEquis | since that is inherently a policy of the publication object | 00:48 |
philiKON | yes yes yes | 00:48 |
TresEquis | so object publication would consist of: | 00:48 |
TresEquis | 1. adapt request to IPublication | 00:48 |
* philiKON looks into his magic ball and sees a branch of zope.publisher coming up | 00:48 | |
*** eldar has quit IRC | 00:49 | |
TresEquis | 2. call the IPublication methods in template fashion until the publication says stop | 00:49 |
TresEquis | we could then throw out all the 'requestpublicationfactory' nonsense | 00:49 |
J1m | yes | 00:49 |
TresEquis | which I can't figure out how to configure now | 00:50 |
J1m | I doubt we need to use adaptation to get the publication. | 00:50 |
philiKON | TresEquis: it's nasty | 00:50 |
philiKON | TresEquis: grok does it | 00:50 |
J1m | Use Python luke. | 00:50 |
J1m | and wsgi | 00:50 |
J1m | and paste | 00:50 |
philiKON | but something needs to create the publication | 00:50 |
TresEquis | the publication object could just turn into the WSGI application | 00:50 |
J1m | I though philiKON cleaned all this up w his paste work. :) | 00:50 |
philiKON | and making the publication an adapter of request seems quite good | 00:50 |
philiKON | J1m: i merely provided tiny shims over what's there already ;) | 00:51 |
philiKON | TresEquis: almost | 00:51 |
J1m | I think the application setup code could do it. | 00:51 |
philiKON | TresEquis: there's zope.app.wsgi.WSGIPublisherApplication which ends up creating request + publication | 00:51 |
J1m | It's not like a single application is going to have more than one. | 00:51 |
TresEquis | J1m: adaptation might be needed to allow DAV traversal to differ from "normal" traversal | 00:51 |
philiKON | right | 00:51 |
philiKON | different kinds of requests have different kinds of publications | 00:52 |
philiKON | at least right now | 00:52 |
J1m | but I really don't have time for an on-line design session though. :) | 00:52 |
philiKON | may not be a good idea | 00:52 |
*** fsufitch has quit IRC | 00:52 | |
J1m | good point | 00:57 |
J1m | +1 :) | 00:57 |
*** ksmith99 has left #zope3-dev | 01:01 | |
*** benji has quit IRC | 01:02 | |
*** jsadjohnson has joined #zope3-dev | 01:05 | |
*** netshade has quit IRC | 01:06 | |
*** whit has quit IRC | 01:19 | |
*** whit has joined #zope3-dev | 01:19 | |
*** nouri has joined #zope3-dev | 01:26 | |
*** J1m has quit IRC | 01:28 | |
*** bigkev has joined #zope3-dev | 01:30 | |
*** bigkevmcd has quit IRC | 01:30 | |
*** Ariel_Calzada has quit IRC | 01:41 | |
*** jsadjohnson has quit IRC | 01:52 | |
*** hazmat has quit IRC | 02:01 | |
*** hazmat has joined #zope3-dev | 02:02 | |
*** ChanServ sets mode: +o hazmat | 02:02 | |
*** timte has quit IRC | 02:08 | |
*** jodok_ has quit IRC | 02:10 | |
*** dobee has quit IRC | 02:10 | |
*** dunny has joined #zope3-dev | 02:10 | |
*** srichter has quit IRC | 02:11 | |
*** projekt01 has left #zope3-dev | 02:13 | |
*** deo has quit IRC | 02:27 | |
*** b52laptop has joined #zope3-dev | 02:33 | |
*** b52laptop has quit IRC | 02:33 | |
*** Jell-O-Fishi has joined #zope3-dev | 02:35 | |
*** Jell-O-Fishi has quit IRC | 02:42 | |
*** deo has joined #zope3-dev | 02:44 | |
*** huajie has joined #zope3-dev | 02:51 | |
*** redir has quit IRC | 03:03 | |
*** jsadjohnson has joined #zope3-dev | 03:04 | |
*** pcardune has joined #zope3-dev | 03:15 | |
*** greenman_ has joined #zope3-dev | 03:16 | |
*** jsadjohnson has quit IRC | 03:24 | |
*** greenman has quit IRC | 03:31 | |
*** nouri has quit IRC | 03:32 | |
*** BjornT has quit IRC | 03:32 | |
*** nouri has joined #zope3-dev | 03:32 | |
*** BjornT has joined #zope3-dev | 03:32 | |
*** TresEquis has quit IRC | 04:04 | |
*** replicant has joined #zope3-dev | 04:16 | |
*** jsadjohnson has joined #zope3-dev | 04:17 | |
*** srichter has joined #zope3-dev | 04:25 | |
*** jsadjohnson has quit IRC | 04:25 | |
*** ChanServ sets mode: +o srichter | 04:25 | |
*** hazmat has quit IRC | 04:30 | |
*** RaFromBRC has quit IRC | 04:44 | |
*** bigkev is now known as bigkevmcd | 04:50 | |
*** bigkevmcd has quit IRC | 05:10 | |
*** benji has joined #zope3-dev | 05:40 | |
benji | just about to work on leak #2 a little | 05:42 |
benji | hmm, wrong chan | 05:45 |
*** rcrafton_ has quit IRC | 06:24 | |
*** replicant has quit IRC | 06:26 | |
*** philiKON_ has joined #zope3-dev | 06:28 | |
*** philiKON has quit IRC | 06:37 | |
*** pcardune has quit IRC | 06:45 | |
*** chacha_chaudhry has joined #zope3-dev | 06:50 | |
*** baijum has joined #zope3-dev | 07:40 | |
*** stub has joined #zope3-dev | 08:00 | |
*** cursor has joined #zope3-dev | 08:21 | |
*** dunny has quit IRC | 08:31 | |
*** deo has quit IRC | 09:00 | |
*** yvl has joined #zope3-dev | 09:04 | |
*** afd has joined #zope3-dev | 09:30 | |
*** timte has joined #zope3-dev | 09:37 | |
*** pelle_ has quit IRC | 09:42 | |
*** huajie has quit IRC | 09:50 | |
*** zagy has joined #zope3-dev | 09:50 | |
*** romanofski has joined #zope3-dev | 09:55 | |
*** markusleist has joined #zope3-dev | 10:02 | |
*** goschtl has joined #zope3-dev | 10:16 | |
*** ignas has joined #zope3-dev | 10:17 | |
*** zagy has quit IRC | 10:19 | |
*** schwendinger has joined #zope3-dev | 10:19 | |
*** pelle_ has joined #zope3-dev | 10:20 | |
*** lmiller_ has quit IRC | 10:24 | |
goschtl | i ´ve a question about the wsgi stuff, espacially the work zopeproject from philipp. Is the wsgi, paste_deploy stuff only a development option or should this be used in production as well. If so how is the performance related to zserver? | 10:38 |
*** MJ has joined #zope3-dev | 10:45 | |
romanofski | moin | 10:46 |
*** markusleist has quit IRC | 10:48 | |
*** bigkevmcd has joined #zope3-dev | 11:01 | |
*** cursor has quit IRC | 11:02 | |
*** zagy has joined #zope3-dev | 11:05 | |
*** projekt01 has joined #zope3-dev | 11:14 | |
*** jinty has joined #zope3-dev | 11:15 | |
*** jinty has joined #zope3-dev | 11:16 | |
*** tarek has joined #zope3-dev | 11:21 | |
*** romanofs1i has joined #zope3-dev | 11:22 | |
*** norro has joined #zope3-dev | 11:24 | |
*** romanofski has quit IRC | 11:39 | |
*** ferrafox has joined #zope3-dev | 11:47 | |
*** ghendi has joined #zope3-dev | 11:51 | |
*** henri_ has joined #zope3-dev | 11:54 | |
*** henri_ has left #zope3-dev | 11:54 | |
*** tarek has quit IRC | 11:56 | |
*** tarek has joined #zope3-dev | 12:03 | |
*** Aiste has joined #zope3-dev | 12:11 | |
*** richardkan has joined #zope3-dev | 12:14 | |
*** b52laptop has joined #zope3-dev | 12:17 | |
*** b52laptop has quit IRC | 12:17 | |
*** b52laptop has joined #zope3-dev | 12:18 | |
*** ghendi has quit IRC | 12:24 | |
*** srichter has quit IRC | 12:31 | |
*** romanofs1i is now known as romanofski | 12:33 | |
*** ChrisW has joined #zope3-dev | 12:46 | |
ChrisW | mornin' all, where do I find the actual provideAdapter call that results from a zcml <adapter> directive? | 12:46 |
ChrisW | I'm specifically interested in what turns the * into whatever it gets turned into... | 12:46 |
wiggy | it gets turned into zope.interface.Interface | 12:47 |
ChrisW | where? | 12:47 |
wiggy | I'm guessing zope.component | 12:47 |
ChrisW | see, I reckon it gets turned into None | 12:47 |
wiggy | afaik it doesn't | 12:48 |
ChrisW | well exactly, hence trying to find the code ;-) | 12:48 |
wiggy | zcml doesn't directly result in a provideAdapter call, there is delayed init involved | 12:48 |
ChrisW | yeah, I'd imagine an action gets created during zcml parsing which later results in the provideAdapter call | 12:49 |
ChrisW | however, the action contains all the parameters | 12:49 |
ChrisW | so I suspect the parsing is done before then | 12:49 |
wiggy | it is immediately parsed | 12:49 |
ChrisW | yeah, and I reckon it's the parsin that turns the * into something | 12:50 |
ChrisW | I guess that's the code I'm looking for | 12:50 |
ChrisW | it's not in zope.component | 12:50 |
ChrisW | I suspect it's in zope.app.component, I'm just trying to figure out where | 12:50 |
bigkevmcd | maybe put an error in and look at the traceback? | 12:54 |
projekt01 | ChrisW, * represents None | 12:55 |
projekt01 | This is done in zope.configuration.fields.GlobalObject / fromUnicode | 12:56 |
ChrisW | projekt01: thanks, who are you? | 12:56 |
projekt01 | The field converts the * to None and the adapter registry uses None as discriminator | 12:56 |
ChrisW | cool | 12:57 |
projekt01 | ChriW, Roger Ineichen | 12:57 |
ChrisW | aha, thought I rememberedthe projekt01 ;-) Thanks Roger! | 12:57 |
projekt01 | np | 12:58 |
ChrisW | I think I may have found some weirdness with adapter looks preference, just playing around to see if I can reproduce... | 13:00 |
*** alga has joined #zope3-dev | 13:06 | |
*** afd has quit IRC | 13:14 | |
*** whit has quit IRC | 13:15 | |
*** whit has joined #zope3-dev | 13:15 | |
*** norro has quit IRC | 13:38 | |
*** cursor has joined #zope3-dev | 13:42 | |
*** jfroche has joined #zope3-dev | 13:45 | |
*** bigkevmcd has quit IRC | 13:49 | |
*** bigkevmcd has joined #zope3-dev | 13:49 | |
*** Newfie2007 has joined #zope3-dev | 13:56 | |
*** afd_ has joined #zope3-dev | 13:59 | |
*** MJ is now known as MJ|lunch | 14:07 | |
*** tarek has left #zope3-dev | 14:15 | |
*** mkerrin has joined #zope3-dev | 14:35 | |
*** nikhil_n has joined #Zope3-dev | 14:36 | |
*** markusleist has joined #zope3-dev | 14:38 | |
*** srichter has joined #zope3-dev | 14:44 | |
*** nikhil_n has quit IRC | 14:56 | |
*** benji has quit IRC | 14:57 | |
*** nikhil_n has joined #Zope3-dev | 15:01 | |
*** nikhil_n has quit IRC | 15:04 | |
*** tarek has joined #zope3-dev | 15:05 | |
*** mgedmin has joined #zope3-dev | 15:08 | |
*** bigkevmcd has quit IRC | 15:10 | |
*** bigkevmcd has joined #zope3-dev | 15:10 | |
*** greenman_ has quit IRC | 15:16 | |
*** ignas_ has joined #zope3-dev | 15:17 | |
*** srichter has quit IRC | 15:19 | |
*** J1m has joined #zope3-dev | 15:23 | |
*** whit has quit IRC | 15:28 | |
*** Ariel_Calzada has joined #zope3-dev | 15:35 | |
*** goschtl has quit IRC | 15:46 | |
*** ignas_ has quit IRC | 15:48 | |
*** MJ|lunch is now known as MJ | 15:48 | |
*** alga has quit IRC | 15:52 | |
*** romanofski has quit IRC | 15:52 | |
*** pelle_ has quit IRC | 15:52 | |
*** nouri has quit IRC | 15:52 | |
*** BjornT has quit IRC | 15:52 | |
*** alga has joined #zope3-dev | 15:52 | |
*** romanofski has joined #zope3-dev | 15:52 | |
*** pelle_ has joined #zope3-dev | 15:52 | |
*** nouri has joined #zope3-dev | 15:52 | |
*** BjornT has joined #zope3-dev | 15:52 | |
*** dabu has quit IRC | 15:52 | |
*** wiggy has quit IRC | 15:52 | |
*** jap has quit IRC | 15:52 | |
*** dabu has joined #zope3-dev | 15:54 | |
*** wiggy has joined #zope3-dev | 15:54 | |
*** jap has joined #zope3-dev | 15:54 | |
*** ChrisW has quit IRC | 15:55 | |
baijum | J1m, can you update this page to redirect to PyPI page : http://www.zope.org/DevHome/Buildout | 15:57 |
J1m | I've never seen this page before. | 15:58 |
J1m | I wonder who created it. | 15:58 |
baijum | well, I found some peoples still referring to that outdated page | 15:59 |
*** rcrafton has joined #zope3-dev | 15:59 | |
J1m | Man, I wish history worked on all objects. :( | 15:59 |
J1m | God the zope.org redirector mechanism is totally INSANE! | 16:01 |
wiggy | what is it? | 16:01 |
J1m | You don't want to know. | 16:02 |
J1m | done | 16:04 |
J1m | whoever invented that thing ... | 16:04 |
baijum | cool | 16:06 |
*** ferrafox has quit IRC | 16:15 | |
*** jsadjohnson has joined #zope3-dev | 16:16 | |
*** benji has joined #zope3-dev | 16:22 | |
*** povbot has joined #zope3-dev | 16:27 | |
*** pelle__ has joined #zope3-dev | 16:27 | |
*** bjdevlin has quit IRC | 16:28 | |
*** povbot` has joined #zope3-dev | 16:32 | |
*** baijum has quit IRC | 16:34 | |
*** replicant has joined #zope3-dev | 16:41 | |
*** srichter has joined #zope3-dev | 16:41 | |
*** ferrafox has joined #zope3-dev | 16:42 | |
*** pelle_ has quit IRC | 16:43 | |
*** povbot has quit IRC | 16:46 | |
*** derek_richardson has joined #zope3-dev | 16:46 | |
derek_richardson | how does OFS.Folder.Folder relate to zope.app.folder.Folder? Is OFS used in z2.10 and app used in 3.x? | 16:48 |
zagy | yep | 16:50 |
zagy | ofs is z2 | 16:50 |
derek_richardson | thanks! | 16:51 |
*** Ariel_Calzada has quit IRC | 16:59 | |
*** yvl has quit IRC | 17:06 | |
*** reco has joined #zope3-dev | 17:07 | |
*** pelle__ has quit IRC | 17:08 | |
*** pelle_ has joined #zope3-dev | 17:09 | |
*** richardkan_ has joined #zope3-dev | 17:15 | |
*** romanofski has quit IRC | 17:21 | |
*** richardkan has quit IRC | 17:23 | |
*** alecm has joined #zope3-dev | 17:23 | |
*** Aiste has quit IRC | 17:36 | |
*** nouri has left #zope3-dev | 17:57 | |
*** bigkevmcd has quit IRC | 18:10 | |
*** bigkevmcd has joined #zope3-dev | 18:10 | |
*** Newfie2007 has quit IRC | 18:13 | |
*** richardkan_ has quit IRC | 18:13 | |
*** replicant is now known as hazmat | 18:14 | |
*** ChanServ sets mode: +o hazmat | 18:14 | |
*** Newfie2007 has joined #zope3-dev | 18:14 | |
*** zagy has quit IRC | 18:17 | |
*** richardkan has joined #zope3-dev | 18:20 | |
*** dobee has joined #zope3-dev | 18:23 | |
*** pelle_ has quit IRC | 18:23 | |
*** pelle_ has joined #zope3-dev | 18:26 | |
*** philiKON_ is now known as philiKON | 18:28 | |
*** netshade has joined #zope3-dev | 18:28 | |
philiKON | derek_richardson: except that zope.app.folder.Folder uses BTree storage, OFS.Folder.Folder doesn't | 18:31 |
philiKON | derek_richardson: i suggest using Products.BTreeFolder2 for anything meaningful | 18:31 |
derek_richardson | philiKON: this isn't meaningful, it's just ftests. But I'll ftest BTreeFolder2, as well as the OFS Folder. Thanks! | 18:35 |
philiKON | for ftests, OFS.Folder is sufficient | 18:35 |
philiKON | no need to double the work | 18:35 |
*** gumpa has joined #zope3-dev | 18:36 | |
*** davidstryker has joined #zope3-dev | 18:48 | |
*** dobee has quit IRC | 18:49 | |
*** reco has quit IRC | 18:51 | |
*** reco has joined #zope3-dev | 18:52 | |
*** stub has quit IRC | 18:53 | |
*** yvl has joined #zope3-dev | 19:10 | |
*** reco has quit IRC | 19:11 | |
*** ignas has quit IRC | 19:20 | |
*** xbeanx has quit IRC | 19:21 | |
*** MJ has quit IRC | 19:28 | |
*** projekt01 has quit IRC | 19:28 | |
*** redir has joined #zope3-dev | 19:39 | |
*** pelle_ has quit IRC | 19:42 | |
*** markusleist has quit IRC | 19:43 | |
*** malthe has joined #zope3-dev | 19:55 | |
*** whit has quit IRC | 20:02 | |
*** whit has joined #zope3-dev | 20:03 | |
*** cursor has quit IRC | 20:05 | |
*** whit has quit IRC | 20:05 | |
*** schwendinger has quit IRC | 20:09 | |
*** ignas has joined #zope3-dev | 20:12 | |
*** yvl has quit IRC | 20:14 | |
*** rcrafton has quit IRC | 20:18 | |
*** ferrafox_ has joined #zope3-dev | 20:18 | |
*** malthe has quit IRC | 20:20 | |
*** pcardune has joined #zope3-dev | 20:24 | |
*** whit has joined #zope3-dev | 20:27 | |
*** lucielejard has joined #zope3-dev | 20:30 | |
*** ferrafox has quit IRC | 20:36 | |
*** chacha_chaudhry has quit IRC | 20:38 | |
*** jinty has quit IRC | 20:39 | |
*** natea_ has joined #zope3-dev | 20:39 | |
*** whit has quit IRC | 20:43 | |
*** alga has quit IRC | 20:46 | |
*** pcardune has quit IRC | 20:51 | |
*** whit has joined #zope3-dev | 20:55 | |
*** romanofski has joined #zope3-dev | 20:56 | |
*** cursor has joined #zope3-dev | 20:57 | |
*** Ariel_Calzada has joined #zope3-dev | 20:59 | |
*** fdrake has joined #zope3-dev | 21:01 | |
fdrake | So, where's the right place to report bugs in z3c.configurator? | 21:02 |
*** chacha_chaudhry has joined #zope3-dev | 21:05 | |
*** markusleist has joined #zope3-dev | 21:07 | |
*** bjdevlin has joined #zope3-dev | 21:07 | |
*** projekt01 has joined #zope3-dev | 21:14 | |
*** ksmith99 has joined #zope3-dev | 21:14 | |
fdrake | srichter: You here? | 21:15 |
*** alecm has quit IRC | 21:21 | |
fdrake | Is there a known tracker for bugs in the z3c packages? | 21:24 |
*** rcrafton has joined #zope3-dev | 21:27 | |
*** tarek_ has joined #zope3-dev | 21:27 | |
projekt01 | fdrake, svn://svn.zope.org/repos/main/bugtracker | 21:29 |
projekt01 | probably outdated | 21:30 |
fdrake | projekt01: Probably not. ;-) What I want is to report a bug in z3c.configurator. | 21:32 |
projekt01 | Ah, I don't know what is the state of the art for report a bug right now. Probably launchpad since the community is not able to develope a own bugtracker. | 21:34 |
projekt01 | fdrake, what is the issue? | 21:35 |
fdrake | Perhaps so. | 21:35 |
projekt01 | You can tell me what is the issue, I'll fix that. | 21:36 |
*** tarek has quit IRC | 21:36 | |
fdrake | The requiredPlugins() function can enter an infinite recursion because it doesn't keep track of what it's looking at in each iteration of _add(). | 21:36 |
fdrake | Taking note of the items as it enters _add() avoids that. | 21:36 |
*** richardkan has quit IRC | 21:37 | |
projekt01 | Did you fix this allready? | 21:37 |
fdrake | I have a patch, but it's a hack; I've only used that package a very little, and probably don't understand the full requirements. | 21:38 |
fdrake | I'll get the patch I made... | 21:38 |
*** afd_ has quit IRC | 21:39 | |
*** schwendinger has joined #zope3-dev | 21:41 | |
projekt01 | fdrake, does this not avoid recursions: if not dep in res: | 21:42 |
projekt01 | line: 61 | 21:42 |
fdrake | No, that's too late. | 21:42 |
fdrake | --- src/z3c/configurator/configurator.py (revision 78320) | 21:43 |
fdrake | +++ src/z3c/configurator/configurator.py (working copy) | 21:43 |
fdrake | @@ -54,8 +54,11 @@ | 21:43 |
fdrake | # interfaces may change during execution | 21:43 |
fdrake | plugins = getAdapterFactories(component, | 21:43 |
fdrake | specific=False) | 21:43 |
fdrake | - | 21:43 |
fdrake | + seen = set() | 21:43 |
fdrake | def _add(name, res): | 21:43 |
fdrake | + if name in seen: | 21:43 |
fdrake | + return | 21:43 |
fdrake | + seen.add(name) | 21:43 |
fdrake | deps = getattr(plugins[name], 'dependencies', ()) | 21:43 |
fdrake | for dep in deps: | 21:43 |
fdrake | if not dep in res: | 21:43 |
fdrake | Hope that came through ok. | 21:43 |
fdrake | I don't have tests; was trying to get something else working. | 21:43 |
fdrake | I don't have time to write a proper test, probably for a couple of weeks at least. | 21:43 |
projekt01 | I can do that tomorrow | 21:44 |
fdrake | That would be great! I'll be keeping an eye on the checkins. ;-) | 21:44 |
fdrake | Thanks! | 21:44 |
projekt01 | Thanks too for reporting | 21:45 |
projekt01 | Have a nice weekend | 21:45 |
*** chacha_chaudhry has quit IRC | 21:46 | |
fdrake | Thank you! Go have some fun. :-) | 21:46 |
*** Newfie2007 has quit IRC | 21:49 | |
*** schwendinger has quit IRC | 21:54 | |
*** mgedmin has quit IRC | 21:58 | |
*** mkerrin has quit IRC | 21:58 | |
*** Ariel_Calzada has quit IRC | 22:17 | |
*** hazmat has quit IRC | 22:21 | |
*** srichter has quit IRC | 22:23 | |
*** natea_ has quit IRC | 22:26 | |
*** jsadjohnson has quit IRC | 22:32 | |
*** RaFromBRC has joined #zope3-dev | 22:36 | |
*** rcrafton_ has joined #zope3-dev | 22:54 | |
*** cursor has quit IRC | 22:58 | |
*** davidstryker has quit IRC | 22:59 | |
projekt01 | fdrake, it's fixed, can you check this? | 23:04 |
projekt01 | fdrake, it's only in the trunk, no EGG. | 23:04 |
fdrake | Sure, in just a few minutes. Ok, that's fine. | 23:04 |
projekt01 | fdrake, do you egg today? | 23:05 |
projekt01 | or are you working with the trunk? | 23:05 |
fdrake | That can wait a little while, or I can do that myself. | 23:05 |
fdrake | I've been using eggs wherever possible. | 23:05 |
fdrake | I'll need an egg very soon since others are on this project too. | 23:06 |
projekt01 | Can you egg z3c.configurator if it's fixed? | 23:06 |
fdrake | Sure; no problem. | 23:06 |
projekt01 | Ok, cool | 23:06 |
projekt01 | I also added a test for the fix in the README.txt, e.g. first -> second, second -> first and bang recursion. | 23:07 |
fdrake | Yep, that's all it takes. Very cool. | 23:08 |
*** gumpa has quit IRC | 23:09 | |
*** rcrafton has quit IRC | 23:11 | |
*** ksmith99 has left #zope3-dev | 23:11 | |
*** ferrafox_ has quit IRC | 23:14 | |
*** greenman has joined #zope3-dev | 23:28 | |
*** faassen has quit IRC | 23:36 | |
*** rcrafton_ has quit IRC | 23:41 | |
*** romanofski has quit IRC | 23:42 | |
markusleist | projekt01: hi, still online? | 23:45 |
*** jsadjohnson has joined #zope3-dev | 23:45 | |
markusleist | what's the best way to transfer form data from z3c addform to a new object in form.AddForm.create().method? there are some different recipes... | 23:48 |
markusleist | i have some forms with 10-20 attributes and searching for a generic "data-set" in AddForm.create() without data['atr1'], data['atr2'] and so on. / any fine recipes there? | 23:51 |
markusleist | maybe later... | 23:52 |
*** jsadjohnson has quit IRC | 23:56 | |
*** Ariel_Calzada has joined #zope3-dev | 23:57 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!