*** horizon5 has quit IRC | 00:29 | |
*** alienoid has quit IRC | 00:34 | |
*** MrTopf has quit IRC | 00:35 | |
*** anguenot has joined #zope3-dev | 00:38 | |
*** niemeyer has quit IRC | 00:44 | |
*** |jbb| has quit IRC | 00:54 | |
*** fdrake has quit IRC | 00:56 | |
*** RaFromBRC has joined #zope3-dev | 01:35 | |
*** tvon|x31 has quit IRC | 01:44 | |
*** bskahan has joined #zope3-dev | 01:46 | |
*** MiUlEr has quit IRC | 01:47 | |
*** benji_york has quit IRC | 01:51 | |
*** d2m has quit IRC | 02:29 | |
*** cwells is now known as BLACK_SKULL | 02:42 | |
*** SureshZ has quit IRC | 02:47 | |
*** SureshZ has joined #zope3-dev | 02:48 | |
*** yota has quit IRC | 02:57 | |
*** srichter has joined #zope3-dev | 03:21 | |
*** BLACK_SKULL is now known as cwells | 03:21 | |
*** ChanServ sets mode: +o srichter | 03:21 | |
*** __gotcha_ has joined #zope3-dev | 03:21 | |
*** SureshZ has quit IRC | 03:29 | |
*** SureshZ has joined #zope3-dev | 03:30 | |
*** __gotcha has quit IRC | 03:38 | |
*** SureshZ has quit IRC | 03:41 | |
*** SureshZ has joined #zope3-dev | 03:41 | |
*** SureshZ has quit IRC | 03:43 | |
*** SureshZ has joined #zope3-dev | 04:00 | |
*** bskahan has quit IRC | 04:07 | |
*** projekt01 has quit IRC | 04:13 | |
*** povbot` has joined #zope3-dev | 05:54 | |
*** douglasc has joined #zope3-dev | 06:06 | |
*** povbot has quit IRC | 06:10 | |
*** Aiste has quit IRC | 06:12 | |
*** RaFromBRC has quit IRC | 06:18 | |
*** bskahan has joined #zope3-dev | 06:48 | |
*** SureshZ has quit IRC | 07:18 | |
*** SureshZ has joined #zope3-dev | 07:18 | |
*** SureshZ has quit IRC | 07:51 | |
*** SureshZ has joined #zope3-dev | 07:51 | |
*** douglasc has quit IRC | 08:04 | |
*** zagy has joined #zope3-dev | 08:28 | |
*** zagy has quit IRC | 08:34 | |
*** zagy has joined #zope3-dev | 08:36 | |
*** zagy has quit IRC | 08:38 | |
*** zagy has joined #zope3-dev | 08:38 | |
*** bskahan has quit IRC | 08:45 | |
*** vitaly has quit IRC | 08:55 | |
*** d2m has joined #zope3-dev | 09:03 | |
*** hdima has joined #zope3-dev | 09:27 | |
*** cwells is now known as BLACK_SKULL | 09:33 | |
*** bskahan has joined #zope3-dev | 09:33 | |
*** BLACK_SKULL is now known as cwells | 09:35 | |
*** yota has joined #zope3-dev | 09:51 | |
*** SureshZ has quit IRC | 09:51 | |
*** SureshZ has joined #zope3-dev | 09:52 | |
*** bskahan has quit IRC | 10:02 | |
*** SureshZ has quit IRC | 10:13 | |
*** bskahan has joined #zope3-dev | 10:13 | |
*** sashav has joined #zope3-dev | 10:45 | |
*** bskahan has quit IRC | 10:55 | |
*** __gotcha_ is now known as __gotcha | 11:19 | |
*** MrTopf has joined #zope3-dev | 11:31 | |
* wiggy pets amazon | 11:41 | |
wiggy | ordered the zope3 book on tuesday and got it today | 11:41 |
---|---|---|
bob2 | stephen's or phillipp's? | 11:43 |
wiggy | philipps | 11:44 |
*** lunatik has joined #zope3-dev | 11:47 | |
*** projekt01 has joined #zope3-dev | 11:51 | |
*** The|uni has joined #zope3-dev | 12:05 | |
sashav | wiggy, from where? | 12:06 |
sashav | which amazon? | 12:06 |
wiggy | co.uk | 12:06 |
sashav | it was much cheaper then amazon.de | 12:08 |
*** TheOnly has joined #zope3-dev | 12:09 | |
*** JZ has joined #zope3-dev | 12:26 | |
*** tarek has joined #zope3-dev | 12:27 | |
bob2 | hrrrm | 12:36 |
bob2 | so, I have some tests | 12:36 |
bob2 | when unit testing, it'd be good to not send mail out | 12:36 |
bob2 | hm | 12:37 |
bob2 | I guess I should be using an adapter or utility, and override it in the test harness | 12:37 |
*** anguenot has quit IRC | 12:48 | |
*** lunatik has left #zope3-dev | 12:48 | |
*** JZ has quit IRC | 12:51 | |
srichter | bob2: use a dummy utility during testing | 13:06 |
srichter | note that there is a mailer utility coming with Zope 3; in it's test it uses a dummy utility | 13:06 |
srichter | good morning to everyone; it's bug day! | 13:08 |
srichter | (as it turns out my morning is incredible busy today ;-(, but I will be here in the afternoon chopping away bugs left and right ;-) | 13:09 |
projekt01 | srichter, hi tell me if you are back | 13:10 |
* wiggy fetches a zope3 trunk co | 13:22 | |
*** wiggy has quit IRC | 13:36 | |
*** MJ has joined #zope3-dev | 13:52 | |
*** anguenot has joined #zope3-dev | 13:52 | |
*** sashav has quit IRC | 13:58 | |
*** sashav_ has joined #zope3-dev | 14:04 | |
*** mgedmin has joined #zope3-dev | 14:21 | |
*** zagy has left #zope3-dev | 14:25 | |
*** zagy has joined #zope3-dev | 14:25 | |
*** lunati1 has joined #zope3-dev | 14:34 | |
*** MrTopf has quit IRC | 14:49 | |
*** alga has joined #zope3-dev | 14:53 | |
*** lunati1 is now known as lunatik | 15:05 | |
*** lunatik has left #zope3-dev | 15:05 | |
anguenot | hi everybody | 15:28 |
anguenot | checking the #307 | 15:28 |
anguenot | Just don't get how it's possible to register something that doesn't exist | 15:28 |
anguenot | template or class | 15:28 |
anguenot | since you get ZopeXMLConfigurationError exceptions in this case | 15:29 |
anguenot | Am I missing something in here ? | 15:29 |
srichter | checking... | 15:32 |
srichter | anguenot: I think the addMenuItem does not check (can it?) whether a given view exists for a particular object; but I don't know why it has the effect it does | 15:34 |
srichter | I guess the simplest would be to try it out and create an addMenuItem that refers to an incorrect view name | 15:35 |
anguenot | ok giving a try | 15:37 |
*** jwtest is now known as genconc | 15:38 | |
anguenot | srichter:You can specify a non existing view within the addMenuItem directive | 15:42 |
anguenot | but you can"t specify a non existing class | 15:43 |
anguenot | so can we just test the existence of the view within zope.app.publisher.browser.menumeta.py and raise an exception if not found ? | 15:54 |
anguenot | so can we just test the existence of the view within menumeta.py and raise an exception if not found ? | 15:55 |
alga | srichter: could you please point me to some low-hanging-fruit issue I could tackle? | 16:07 |
*** efge has joined #zope3-dev | 16:08 | |
*** benji_york has joined #zope3-dev | 16:12 | |
*** juka has joined #zope3-dev | 16:16 | |
alga | srichter: I'm looking at #344. It seems it is not relevant any more as you don't have to enter the interface when registering a component. | 16:22 |
*** MrTopf has joined #zope3-dev | 16:27 | |
*** garrett-smith has joined #zope3-dev | 16:33 | |
*** fdrake has joined #zope3-dev | 16:42 | |
*** juka has left #zope3-dev | 16:47 | |
garrett-smith | srichter: ping | 16:49 |
*** roym has joined #zope3-dev | 16:50 | |
garrett-smith | srichter: when you get a chance, could you look at http://www.zope.org/Collectors/Zope3-dev/344 | 16:50 |
garrett-smith | hmmm...never mind, looks like alga weighed in as I was posting here :-) | 16:51 |
*** sashav_ has quit IRC | 16:52 | |
roym | I would like to ask some advice of this group: I am trying to learn | 17:00 |
roym | Zope3 and have been reading the 2 books published; I have written a | 17:00 |
roym | reasonable sized product in Zope2 - yet I find the going hard. As a | 17:00 |
roym | learning tool, is is better to play with Five or work directly w/Z3. | 17:00 |
roym | What are your experiences? | 17:00 |
J1m | I would work w z3. | 17:00 |
J1m | I would also read through the tutorial, skipping the testing material on the first read. | 17:00 |
garrett-smith | Stephans book is a good place to start as well | 17:01 |
J1m | http://www.zope.org/Wikis/DevSite/Projects/ComponentArchitecture/ProgrammerTutorial/programmers_tutorial.pdf | 17:01 |
roym | yes - I have the books, and they are well written - I think the conceptual parts that | 17:01 |
garrett-smith | I haven't looked at Philipps closely, but it also looks very good | 17:02 |
roym | come w/experience are harder (zen!) | 17:02 |
J1m | I think the tutorial will help you get started quicker. The books can then build on that. | 17:02 |
garrett-smith | Jim, I'm going to add a UI for the PAU prefix | 17:03 |
roym | Would reading the interfaces first help navigate, or is it likely to overwhelm? | 17:03 |
garrett-smith | is the principal search issue still lurking? | 17:03 |
J1m | cool wrt prefix. | 17:03 |
anguenot | Can we discuss the #307 at some point ? | 17:04 |
J1m | not sure what issue you are refering to. | 17:04 |
garrett-smith | From your bug report: | 17:04 |
garrett-smith | 17:04 | |
garrett-smith | This bug is not very effective because the UI for adding a pluggable authentication utility doesn't let you specify a prefix for the utility itself. If you create one programmatically, you will find that searching for principals will be broken. | 17:04 |
garrett-smith | 17:04 | |
garrett-smith | There were many other places where having a prefix on the auth utility didn't work, which I have fixed. | 17:04 |
garrett-smith | it's not clear what broken and what's fixed | 17:05 |
J1m | aaaah | 17:05 |
J1m | oh yeah | 17:05 |
J1m | I'm on the phone at the moment | 17:05 |
J1m | ... | 17:05 |
garrett-smith | np -- ping me when you get a minute | 17:05 |
garrett-smith | roym: what pain points have you run into specifically? | 17:06 |
fdrake | benji_york: has a new name for the mechtest stuff been determined yet/ | 17:07 |
J1m | garrett-smith, are you refering to a collector issue #? | 17:12 |
garrett-smith | 414 | 17:12 |
benji_york | fdrake, yep it's going to be testbrowser | 17:13 |
J1m | This is still a mess | 17:13 |
J1m | A rather big mess | 17:13 |
fdrake | zope.testbrowser, right/ | 17:13 |
garrett-smith | :-( | 17:13 |
benji_york | fdrake: I'm moving it to zope.testbrowser right now | 17:13 |
J1m | I should have updated the collector issue when I last looked at this. :( | 17:13 |
benji_york | yep | 17:13 |
J1m | Give me a few minutes to try to refresh my memory. | 17:13 |
benji_york | why do you ask? | 17:14 |
fdrake | ok, cool; i just wanted the target name to refer to in a comment in the formparser package | 17:14 |
benji_york | ahh, ok | 17:14 |
fdrake | argh! zope.testing has been separated; gotta get another checkout | 17:17 |
benji_york | what do you mean "separated"? | 17:17 |
fdrake | it's linked via an external | 17:17 |
benji_york | are you working in a buildout? | 17:17 |
fdrake | a zope 3 checkout | 17:17 |
*** mkerrin has joined #zope3-dev | 17:17 | |
benji_york | oh, testbrowser is on a branch (but there it is zope.app.testing.testbrowser) | 17:18 |
benji_york | I'm working on moving it | 17:18 |
fdrake | right | 17:18 |
fdrake | formparser is a separate project now | 17:18 |
benji_york | oh, also the form story has evolved lately, I'm not sure how formparser is going to fit into testbrowser | 17:19 |
fdrake | it doesn't have to; formparser is still useful to just get a few things from a form | 17:19 |
alga | J1m: does it make sense to use Field() in a schema? I'm looking at zope.app.catalog.interfaces.CatalogIndex. | 17:22 |
J1m | sure, why not? | 17:22 |
alga | what's the sense of it? Field() is an abstract thing | 17:23 |
alga | how is it different from Attribute() then? | 17:23 |
alga | or Object()? | 17:23 |
J1m | It lets you specify contraints. | 17:23 |
J1m | It lets you say other things that Attribute doesn't. | 17:24 |
J1m | (e.g. required) | 17:24 |
benji_york | fdrake: right, I was just stating that I think it might be useful to integrate it with testbrowser somehow, but I haven't figured that out yet | 17:25 |
alga | but then a schema with such fields will not be renderable by the various ZCML-defined views | 17:25 |
alga | unless you explicitly list fields and skip the Field() one | 17:25 |
J1m | garrett-smith, I think there are a number of apis that don't quite handle pau prefixes correctly. | 17:25 |
J1m | We do need to fix this. | 17:25 |
fdrake | we'd talked about using something like the formparser API for browser controls with getControl() | 17:26 |
J1m | alga, 1: forms are not the only reason to use schemas | 17:26 |
benji_york | frdake, yep | 17:26 |
J1m | alga, 2: custom widgets can be used to provide form-based UIs to plain fields. | 17:26 |
fdrake | i noticed you'd done some work on testbrowser for controls since we talked about that, presumably because i didn't have time to implement something quickly enough :-) | 17:26 |
alga | J1m: thanks | 17:26 |
fdrake | haven't had time to look at what you did yet | 17:27 |
J1m | alga, if you have a question about why I used Filed in a particular case, I'd be pahhy to share my thoughts. | 17:27 |
fdrake | is anyone looking at #397 | 17:27 |
fdrake | ? | 17:27 |
J1m | garrett-smith, I don't remember the details. I'd say the first step is to update the tests to uses paus with prefixes and see what breaks. | 17:27 |
*** GaryPoster has joined #zope3-dev | 17:27 | |
mgedmin | I think alga is | 17:28 |
J1m | I would do this bt making the default prefix non blank. | 17:28 |
J1m | I'll try that ... | 17:28 |
*** GaryPoster has quit IRC | 17:28 | |
mgedmin | that's why all the questions about Fields in schemas that break autogenerated forms | 17:28 |
fdrake | the complaint is that shemadisplay includes fields with python names like __[a-zA-z0-9_]*__ | 17:28 |
*** GaryPoster has joined #zope3-dev | 17:28 | |
J1m | Is anyone working on 302? | 17:29 |
fdrake | does it make sense to filter those by default, or make everyone use fields='...' | 17:29 |
J1m | I have a suggestion to keep this channel sane. | 17:29 |
J1m | I sugest that when people want to discuss a particular issue, they create a separate channel. | 17:30 |
garrett-smith | J1m - I wonder if starting with some typical use scenarios with ftests would be the fastest way to flush out the issues | 17:30 |
J1m | garrett-smith, I just created #zope3-dev-414 :) | 17:30 |
* mgedmin wants a bug to try to fix | 17:31 | |
J1m | mgedmin, 302? | 17:31 |
anguenot | #zope3-dev-307 created | 17:31 |
mgedmin | #zope3-dev-302 created | 17:32 |
J1m | freake, can we borrow you on #zope3-dev-302? | 17:34 |
J1m | fdrake, can we borrow you on #zope3-dev-302? | 17:34 |
alga | How do I go about bugs I think have to be closed? | 17:35 |
GaryPoster | fdrake, do you want to chat about 397 someplace? | 17:37 |
GaryPoster | (my first inclination is that the 'fields' attribute, identified as the workaround, is in fact the correct usage, and that this should be closed as a WontFix or something) | 17:38 |
alga | We could also display the __parent__ | 17:41 |
*** hdima has quit IRC | 17:41 | |
anguenot | I might take some help for the #307 guys | 17:41 |
fdrake | GaryPoster, zope3-dev-397 | 17:42 |
*** SteveA has joined #zope3-dev | 17:48 | |
J1m | The|uni, ayt? | 17:51 |
The|uni | not for long | 17:52 |
J1m | mgedmin, is going to work on 302. | 17:53 |
*** alga has quit IRC | 18:01 | |
*** bskahan has joined #zope3-dev | 18:01 | |
*** alga has joined #zope3-dev | 18:02 | |
*** J1m is now known as J1m|bbl | 18:02 | |
alga | whoops. hit ctrl-alt-backspace accidentally | 18:02 |
*** wiggy has joined #zope3-dev | 18:04 | |
benji_york | I propose we declare 316 as not blocking 3.1; it isn't a problem on non-cygwin systems and there has been no confirmation that it *is* a problem on cygwin | 18:05 |
anguenot | +1 | 18:05 |
*** BjornT has joined #zope3-dev | 18:06 | |
benji_york | I'm looking at 296 | 18:08 |
anguenot | I started already this one | 18:08 |
anguenot | Just need to check non Text fields widgets now | 18:08 |
*** tvon has joined #zope3-dev | 18:11 | |
benji_york | oh, ok | 18:12 |
anguenot | bu you may want to check the other ones | 18:12 |
benji_york | the other interfaces? | 18:12 |
anguenot | the other fields I think | 18:12 |
benji_york | right | 18:13 |
anguenot | and their corresponding diaply display widgets | 18:13 |
anguenot | most of them do have tests | 18:13 |
anguenot | I did'n't review all of them | 18:13 |
*** bskahan has quit IRC | 18:15 | |
*** bskahan has joined #zope3-dev | 18:17 | |
*** bskahan has quit IRC | 18:22 | |
*** stub has joined #zope3-dev | 18:25 | |
*** SureshZ has joined #zope3-dev | 18:25 | |
*** suresh has joined #zope3-dev | 18:31 | |
*** MrTopf has quit IRC | 18:32 | |
*** J1m|bbl is now known as J1m | 18:34 | |
alga | could someone suggest something to work on? | 18:35 |
*** SureshZ has quit IRC | 18:39 | |
*** SureshZ has joined #zope3-dev | 18:43 | |
J1m | I suggest that 296 is a nice to have, not critical | 18:44 |
benji_york | ok, I'm going to move 316 to the TODOLATER.txt and change it from urgent to something less ( :) ) | 18:45 |
J1m | alga, do you know to look at TODO.txt? | 18:46 |
alga | yes, I have even removed one issue that was fixed a month ago | 18:47 |
*** jbb666 has joined #zope3-dev | 18:49 | |
J1m | cool | 18:49 |
J1m | :) | 18:49 |
jbb666 | hola... how goes the bug day ;) | 18:50 |
*** suresh has quit IRC | 18:50 | |
J1m | fdrake, can we borrow you at zope3-dev-307? | 18:51 |
benji_york | jbb666, pretty good, if you want to work on one check out the transcripts, some people are cooperating in bug-specific channels | 18:52 |
*** Aiste_ has quit IRC | 18:54 | |
*** Aiste has joined #zope3-dev | 18:55 | |
alga | What about 381? Advising the user to update their securitypolicy.zcml | 18:57 |
GaryPoster | If anyone is interested, I'm hanging out on #zope3-dev-372 and I'm going to try to tackle some or all of 372. | 18:57 |
alga | we could check that the config is sane on the startup, and complain if it is not | 18:58 |
alga | it would complain to the people like Steve, who use their own security policy | 18:59 |
alga | would it be acceptable? | 18:59 |
*** mp has quit IRC | 19:03 | |
*** suresh has joined #zope3-dev | 19:03 | |
GaryPoster | OK, alga and srichter are ok with the duck typing in the MissingInputError, at least for now, so I'm moving it to TODOLATER. | 19:06 |
GaryPoster | (sorry that was about http://www.zope.org/Collectors/Zope3-dev/372) | 19:06 |
*** mp has joined #zope3-dev | 19:07 | |
*** MJ has quit IRC | 19:07 | |
*** tvon has quit IRC | 19:07 | |
* mgedmin created #zope3-dev-327 because that issue is somewhat related to 302 | 19:11 | |
*** SureshZ has quit IRC | 19:12 | |
* alga created #zope3-dev-381 | 19:16 | |
*** suresh has left #zope3-dev | 19:17 | |
*** SureshZ has joined #zope3-dev | 19:18 | |
benji_york | I'm pushing 296 to TODOLATER because the remaining widgets are really missing features, not bugs | 19:19 |
benji_york | afk - lunch | 19:24 |
*** J1m is now known as J1m|lunch | 19:28 | |
*** mgedmin is now known as mg|lunch | 19:42 | |
*** mg|lunch has quit IRC | 19:45 | |
*** alga has quit IRC | 19:45 | |
fdrake | GaryPoster, on #397, do we still want to rename the fields to fieldName and fieldCallable, for style guide compliance? | 19:50 |
*** projekt01 has quit IRC | 19:56 | |
*** bradb has joined #zope3-dev | 19:58 | |
benji_york | back | 20:04 |
*** J1m|lunch is now known as J1m | 20:04 | |
J1m | back | 20:05 |
GaryPoster | back | 20:08 |
GaryPoster | fdrake: as far as I am concerned, yes. That will be for the 3.2 effort though, I think. | 20:09 |
benji_york | way-on-back | 20:10 |
fdrake | isn't that too late? were the field_* names released in 3.0? (i'll go check...) | 20:10 |
*** SureshZ has quit IRC | 20:11 | |
*** SureshZ has joined #zope3-dev | 20:12 | |
J1m | I'll take 384 | 20:13 |
fdrake | ah, i see; they're not in the interface at all now; it can wait | 20:14 |
fdrake | i just didn't want the interface to be silly | 20:14 |
fdrake | ok, i guess i'd better get some lunch now too | 20:15 |
benji_york | I'm working on evaluating XXXs | 20:17 |
GaryPoster | fdrake: cool, right, I wanted to expose them as something in the interface, and when we do that we should use the proper naming convention | 20:18 |
GaryPoster | I'm doing XXXs in zope.app.form | 20:18 |
GaryPoster | srichter AYT? | 20:26 |
anguenot | what's the best way to get Views registred for a given interface ? | 20:31 |
J1m | It depends on the view. | 20:31 |
J1m | Increasingly, I use the adapter directive. | 20:32 |
anguenot | I want all possibliy registred views for a given interface | 20:32 |
J1m | ah | 20:32 |
J1m | well, that's asking a lot. :) | 20:32 |
J1m | There's no api for that. | 20:32 |
anguenot | The only piece of code doing this curently is zope.app.apidoc.presentation.getViews() | 20:33 |
anguenot | :) | 20:33 |
anguenot | is it the way ? | 20:33 |
J1m | If you want all of the named views that can be found for an interface, then there *is* an api for that. | 20:33 |
anguenot | cool which one ? | 20:33 |
*** SureshZ has quit IRC | 20:33 | |
*** SureshZ has joined #zope3-dev | 20:34 | |
J1m | getAdapters | 20:34 |
J1m | component.getAdapters | 20:34 |
J1m | see zope.component.interfaces.IComponentArchitecture | 20:35 |
anguenot | it takes objects as argument ? | 20:35 |
J1m | ah, right | 20:36 |
J1m | hm | 20:36 |
anguenot | I can understand that by principle the getAdapterXXX() methods should be used but this is extremly confusing... | 20:36 |
J1m | huh? | 20:36 |
* J1m wonders why anguenot is asking this | 20:37 | |
anguenot | I mean we should provide at least a getViews (as in the early days) that would call a getAdapterXXX() just to make it clearer | 20:37 |
anguenot | It's my impression at this stage | 20:37 |
J1m | I don't agree | 20:38 |
J1m | First, normal code should not be doing this sort of thing. | 20:38 |
J1m | Only meta code | 20:38 |
J1m | No need to make things more magic/convenient for meta code. | 20:38 |
J1m | What are you doing? | 20:39 |
anguenot | ok forget about this one Jim. We'll discuss this a little bit later | 20:39 |
anguenot | juste my api :) | 20:39 |
anguenot | what should I use to get views registred for a given interface ? :) | 20:39 |
J1m | You can do site.adapters.lookupAll(required, provides) to get all of the factories that would be used to adapt required to provided. | 20:40 |
J1m | why do you want that? | 20:40 |
anguenot | for the #307 | 20:40 |
J1m | why do you need that for 307? | 20:40 |
J1m | You don't need all of the views. | 20:40 |
anguenot | because I need to check that the view provided within the directive 1) exists and 2) is registred on my class | 20:41 |
J1m | You just need to know if there is a view of a particular type and name. | 20:41 |
J1m | Right, you need a specific view. | 20:41 |
anguenot | :) | 20:41 |
J1m | No need to get all views. | 20:41 |
anguenot | was looking for a way to be sure I won't miss any | 20:42 |
J1m | You need to get the global site manager and get it's 'adapters' attribute. | 20:42 |
anguenot | right as in zope.app.apidoc.pressentation.getView then ? | 20:42 |
anguenot | getViews() | 20:42 |
J1m | no | 20:42 |
J1m | you don't have to work that hard. | 20:43 |
J1m | once to have the global site adapters method, call the lookup method on it. | 20:43 |
anguenot | ok | 20:43 |
J1m | The lookup method is defined in zope.interface.interfaces.IAdapterRegistry. | 20:43 |
anguenot | ok checking this. Thanks | 20:44 |
J1m | That will tell you if a factory is registered. | 20:44 |
J1m | You won't be able to tell if the factory returns None. | 20:44 |
J1m | But if you check that a factory is registered, I think that is good enough. | 20:44 |
*** mgedmin has joined #zope3-dev | 20:44 | |
*** alga has joined #zope3-dev | 20:45 | |
* genconc is away: gone home | 20:54 | |
GaryPoster | garrett-smith or anyone else who cares: trying to remove XXX comments in zope.app.form. The directives used to allow 'menu' but did nothing with it as far as I can tell. I'm about to rip menu out, therefore, including the tests for it. Ring bells with anyone? | 21:00 |
*** efge has quit IRC | 21:02 | |
GaryPoster | Ah, I was looking in the wrong place. Looks like it does something after all. | 21:04 |
GaryPoster | (Just has a dead chicken in the various factory arguments) | 21:04 |
*** roym has quit IRC | 21:06 | |
mgedmin | those huge functional doctest diffs are a pain | 21:08 |
J1m | yes | 21:08 |
J1m | indeed | 21:08 |
* J1m loves mech tests. | 21:08 | |
GaryPoster | If you're looking for sympathy, mgedmin, you got it. ;-) | 21:09 |
J1m | BTW, we've decided to say "mech tests" when talking about functional tests using testbrowser :) | 21:09 |
J1m | But never in writing :) | 21:10 |
benji_york | hmm, I think you just did | 21:10 |
J1m | irc doesn't count as writing | 21:10 |
benji_york | I *really* wish we had a better name :( | 21:10 |
alga | J1m, what do you think about #381? I posted a suggestion, don't know whether I should implement it | 21:11 |
*** MrTopf has joined #zope3-dev | 21:11 | |
SteveA | "browser tests" ? | 21:11 |
MrTopf | hi | 21:12 |
SteveA | in launchpad, we call "call http() and look at the result" tests "page tests" | 21:12 |
J1m | alga, where did you post a suggestion | 21:12 |
J1m | ? | 21:12 |
benji_york | SteveA, I don't think so, because they don't test the browser, that's what Selenium does | 21:12 |
alga | J1m: http://www.zope.org/Collectors/Zope3-dev/381 | 21:12 |
J1m | ha | 21:13 |
J1m | ah | 21:13 |
GaryPoster | eh | 21:13 |
GaryPoster | he | 21:13 |
benji_york | ga | 21:13 |
benji_york | ag | 21:13 |
mgedmin | wh? | 21:13 |
benji_york | ?hw | 21:13 |
* benji_york invites everyone to play | 21:14 | |
alga | yalp ot enoyreve setivni kroy_ijneb * | 21:14 |
benji_york | LOL | 21:15 |
GaryPoster | LOL | 21:15 |
mgedmin | he7d of auohja^a saf!^u! >|joh_!fuaq * | 21:15 |
benji_york | me thinks mgedmin doesn't get it :) | 21:16 |
GaryPoster | or likes encryption | 21:16 |
alga | flip the screen upside down :-) | 21:16 |
Aiste | :) | 21:16 |
GaryPoster | oh, very nice!! | 21:16 |
benji_york | I just committed the removal of 73 XXXs, the others are being worked on by other people | 21:17 |
benji_york | mgedmin, I intuit that you spend a great deal of time in IRC | 21:17 |
benji_york | :) | 21:17 |
J1m | alga, I think your solution to 381 looks good. | 21:17 |
alga | ok, so I'm going to implement it | 21:18 |
*** swampmonkey has joined #zope3-dev | 21:18 | |
benji_york | If anyone takes issue with the XXX removals let me know | 21:18 |
mgedmin | benji_york, apt-get install filters, if you have Debian | 21:18 |
*** mkerrin has quit IRC | 21:18 | |
benji_york | :) | 21:18 |
J1m | alga, cool | 21:18 |
bob2 | how many are left? | 21:18 |
alga | should I add to bootStrapSubscriber or create a new one? | 21:19 |
J1m | create a new one | 21:19 |
J1m | imo | 21:19 |
alga | ok | 21:20 |
*** stub has quit IRC | 21:35 | |
*** bradb has quit IRC | 21:35 | |
*** SteveA has quit IRC | 21:35 | |
*** BjornT has quit IRC | 21:35 | |
*** stub has joined #zope3-dev | 21:35 | |
*** SteveA has joined #zope3-dev | 21:42 | |
*** RaFromBRC has joined #zope3-dev | 21:44 | |
*** The|uni has quit IRC | 21:46 | |
*** anguenot has quit IRC | 21:55 | |
*** zagy has quit IRC | 22:03 | |
mgedmin | Zope 3 misspells "occurred" as "occured" in a few places | 22:13 |
J1m | Feel free to fix my typos. :/ | 22:17 |
J1m | anybody here responsible for zope.app.mail.mailer | 22:19 |
mgedmin | I think I touched some bits in there, a long time ago | 22:19 |
J1m | It is invoking the shell, via popen, with data potentially entered from the web. | 22:20 |
mgedmin | yes :( | 22:20 |
J1m | This is a serious security hole. | 22:20 |
mgedmin | I think I filed an issue to the collector regarding that | 22:20 |
J1m | OK, we are looking at it. | 22:20 |
mgedmin | and I checked the security checkbox, maybe that's why it's not visible | 22:20 |
J1m | yup | 22:21 |
J1m | benji_york, says svn blames alga for that code. :) | 22:21 |
mgedmin | oh, good :) | 22:21 |
mgedmin | python2.4's subprocess module would come in handy there | 22:21 |
J1m | we need to fix this or not include it in 3.1. | 22:21 |
J1m | yes. | 22:22 |
J1m | popen has an option to pass a sequence rather than a string to popen. | 22:22 |
mgedmin | in 2.3? really? | 22:22 |
J1m | I'm having trouble finding the documentation for that. | 22:22 |
J1m | not sure | 22:22 |
benji_york | I would remove it, or not provide a default command, so the user would have to decide how to handle it themselves | 22:22 |
J1m | Maybe that's why I can't find the documentation. | 22:22 |
mgedmin | <smptMailer> that goes to localhost:25 is sufficient for most Unix installations | 22:22 |
mgedmin | I do not think Windows machines have /usr/bin/sendmail either | 22:23 |
mgedmin | IIRC only MacOS X doesn't listen on localhost:25, but has /usr/bin/sendmail | 22:23 |
mgedmin | hey! | 22:24 |
mgedmin | pydoc popen2 | 22:24 |
mgedmin | "The parameter 'cmd' is the shell command to execute in a | 22:24 |
mgedmin | | sub-process. On UNIX, 'cmd' may be a sequence, in which case arguments | 22:24 |
mgedmin | | will be passed directly to the program without shell intervention (as | 22:24 |
mgedmin | | with os.spawnv())" | 22:24 |
mgedmin | the fix should be simple | 22:24 |
J1m | on unix | 22:25 |
mgedmin | instead of pipe = os.popen(...) we can do child_stdout, pipe = popen2.popen2(); child_stdout.close() | 22:25 |
mgedmin | on Windows people can use <smtpMailer> | 22:25 |
alga | right | 22:25 |
benji_york | well, it would be simple if we could reliably split the words the same way the shell would | 22:25 |
alga | on windows there is no command sendmail | 22:25 |
mgedmin | I do not think you can send emails by piping them to some standard system process | 22:25 |
mgedmin | benji_york, which shell? | 22:25 |
benji_york | exactly! | 22:26 |
J1m | mgedmin, are you talking about windows? | 22:26 |
benji_york | the object's constructor takes a string command, we would have to split it into a sequence, for popen. There are notorious complications doing that | 22:27 |
* mgedmin remembers that on Windows the implementation of execv(array_of_arguments) did the equivalent of system(" ".join(array_of_arguments)) and broke everything | 22:27 | |
alga | yup | 22:27 |
* mgedmin pauses | 22:27 | |
alga | CreateProcess() | 22:27 |
mgedmin | forget Windows oddities | 22:27 |
mgedmin | benji_york, you noticed a problem that I didn't think about | 22:27 |
mgedmin | popen2.popen2(cmd.split() + [unsafe_email_typed_by_a_user]) is still much better than the current security hole | 22:28 |
J1m | I suggest we should just disable the sendmail mailer on windows. | 22:28 |
benji_york | I say we either remove SendmailMailer all-together, or remove the default command, so a potential user would have to decide for themselves what to do | 22:28 |
srichter | hi, I am finally back | 22:28 |
mgedmin | I have no objections to removing SendmailMailer. | 22:29 |
SteveA | remove it | 22:29 |
alga | but but | 22:29 |
*** tvon has joined #zope3-dev | 22:29 | |
alga | it is a standard way of sending mail on unix | 22:29 |
SteveA | yagnish | 22:29 |
benji_york | SteveA, bless you | 22:29 |
J1m | yagnish? | 22:29 |
J1m | oh, god bless you | 22:30 |
SteveA | you aren't gonna need its security holes | 22:30 |
J1m | ah | 22:30 |
SteveA | alga: make it an add-on package | 22:30 |
J1m | +1 | 22:31 |
alga | I thought theere was an insult on the end | 22:31 |
SteveA | alga: with your name on it, if you're going to maintain it | 22:31 |
alga | which is appropriate I must admit | 22:31 |
Aiste | SteveA: you are kindly invited to reconfigure my instance of Ivija then :) | 22:31 |
Aiste | it uses sendmail | 22:31 |
J1m | Aiste, you can use the smtp mailer with sendmail. | 22:31 |
benji_york | Aiste, do you pass tainted addresses in? | 22:31 |
mgedmin | Aiste, you use an old Zope 3 snapshot, which will contain sendmailMailer forever | 22:32 |
Aiste | :) it's on my local machine and not accesible from the outside :) | 22:32 |
SteveA | Aiste: either use alga's add-on package, or, make the smtp mailer know about authenticated smtp, and use your usual external authenticated smtp server | 22:32 |
SteveA | you hope | 22:32 |
Aiste | I know | 22:32 |
SteveA | security is hard. we should err on the side of less functionality and more security. | 22:32 |
J1m | yes | 22:32 |
benji_york | +1 | 22:33 |
J1m | I assume this wasn't in 3.0. | 22:33 |
SteveA | especially where the functionality is equivalent | 22:33 |
* mgedmin gets another unobvious mongo diff from a fdoctest... | 22:33 | |
benji_york | I don't think it was in 3.0 | 22:33 |
SteveA | mgedmin: i have permission to contribute my differ thing. i now just need to do the paperwork | 22:34 |
SteveA | mgedmin: i have broad permission to contribute infrastructure back to zope3 | 22:34 |
SteveA | mgedmin: print me out a committer's agreement, and i'll sign it when i'm back in vilnius. | 22:34 |
J1m | BTW, someone could write a secure thing that uses exec on windows. | 22:34 |
mgedmin | SteveA, any chance of getting a preview before the paperwork is ready? | 22:35 |
SteveA | mgedmin: i think you still have access to RF | 22:35 |
J1m | OK, so for now we'll remove the sendmail mailer. | 22:35 |
GaryPoster | Yeah, that would be cool to know about | 22:35 |
benji_york | very cool, SteveA | 22:35 |
GaryPoster | I don't even know what RF is :-) | 22:36 |
* mgedmin neither | 22:36 | |
mgedmin | oh, rocket fuel | 22:36 |
GaryPoster | he he' | 22:36 |
benji_york | I'm removing SendmailMailer | 22:36 |
SteveA | mgedmin: i have some ideas to improve the diff / output side of doctest. we can talk about it in a week or so. i'd welcome your opinions. | 22:36 |
* mgedmin nods | 22:36 | |
SteveA | rocketfuel is the bazaar archive where the canonical Canonical internal development project code lives | 22:37 |
J1m | SteveA, you should include tim | 22:37 |
SteveA | ok | 22:37 |
GaryPoster | SteveA: ah, cool | 22:37 |
srichter | any issues left for me? :-) | 22:40 |
alga | sendmailMailer was enabled in ZopeX3 3.0.0, along with the hole | 22:40 |
mgedmin | WAAAAH!!!! it was a SINGLE TRAILING SPACE CHARACTER in the request form data | 22:40 |
mgedmin | -<BLANKLINE> | 22:41 |
mgedmin | + | 22:41 |
mgedmin | and fuzz | 22:41 |
GaryPoster | lol. yeah, that still needs some improvements. | 22:41 |
benji_york | alga, I say we fix the bug my removing it :) | 22:42 |
alga | ok, if you say so... | 22:42 |
mgedmin | (no it wasn't, it was something else) | 22:43 |
srichter | damn, the TODO.txt looks great! :-) | 22:44 |
srichter | Jim, what do you want to do about #384? | 22:50 |
srichter | I am not sure how to address part 1 with a descriptor trick, but I agree that we should deprecate the permission argument in the utility directive | 22:51 |
srichter | http://www.zope.org/Collectors/Collectors/Zope3-dev/384 | 22:51 |
J1m | I'm working on it | 22:52 |
srichter | ah, ok | 22:52 |
J1m | after I figure out what to do about the huge security hole we intriduced in 3.0. | 22:52 |
J1m | after I figure out what to do about the huge security hole we introduced in 3.0. | 22:52 |
*** SureshZ has quit IRC | 22:52 | |
*** SureshZ has joined #zope3-dev | 22:53 | |
*** BjornT has joined #zope3-dev | 22:54 | |
J1m | shame on me for not noticing mgedmin's bug report | 22:54 |
srichter | benji_york: did you remove all XXX from zope? | 22:56 |
mgedmin | TestRequest().locale is None | 22:56 |
mgedmin | what do I do if my method needs a date formatter? | 22:57 |
GaryPoster | srichter: I'm in zope.app.form doing the XXXX stuff | 22:57 |
srichter | GaryPoster: ok | 22:57 |
GaryPoster | or XXX :-) | 22:57 |
benji_york | I removed the ones I could figure out what do do with | 22:57 |
benji_york | (and no one else was working on) | 22:57 |
srichter | mgedmin: mmh, I think TestRequest should grow the root locale | 22:58 |
srichter | I thought it does this already | 22:58 |
* J1m wonders how to do a hotfix for zope 3. | 22:58 | |
srichter | support *-hotfix.zcml in package-includes? | 22:59 |
srichter | alga: can you not resove bugs? | 23:01 |
mgedmin | srichter, it works when I use placelesssetup.setUp | 23:02 |
srichter | alga: Should I close 381? | 23:02 |
srichter | mgedmin: mmh, strange | 23:02 |
J1m | alga, how to people use the sendmail mailer? | 23:02 |
J1m | Do they have to modify their zcml? | 23:02 |
mgedmin | J1m, yes | 23:02 |
mgedmin | they have to include a <mail:sendmailMailer name="..." /> directive, and also declare a mail delivery utility that uses that mailer | 23:03 |
J1m | Here's what I propose (after running it by Brian): | 23:06 |
J1m | - remove the sendmail mailer (from the trunk and the 3.0 branch). | 23:06 |
J1m | - Send a note to the dev, users, and announce list letting people know about this problem and that, if by any chance, someone is using this, they should not use it if addresses are types by end users and that we will be removing this feature, | 23:07 |
J1m | 'any objections? | 23:07 |
benji_york | +1 | 23:08 |
alga | +1 | 23:08 |
srichter | +1 | 23:08 |
mgedmin | +1 | 23:08 |
J1m | k | 23:08 |
srichter | garrett-smith: did you work on 414 today? | 23:12 |
*** anguenot has joined #zope3-dev | 23:12 | |
srichter | garrett-smith: can that be closed? | 23:12 |
srichter | anguenot: hi; did you finish 307? I saw you added an XXX comment somewhere | 23:12 |
anguenot | srichter:Hi | 23:12 |
anguenot | not yet finished | 23:13 |
anguenot | is it last one ? | 23:13 |
anguenot | :) | 23:13 |
mgedmin | 302 is almost done, but there is one buglet remaining | 23:13 |
anguenot | cool | 23:13 |
srichter | mgedmin: great | 23:13 |
srichter | anguenot: it is one of the last ones | 23:13 |
anguenot | just take some food and I'm back in :) | 23:14 |
srichter | Jim signed up for 384, so that covers everything | 23:14 |
anguenot | western europe time in here :) | 23:14 |
srichter | and if Phillip and I are not getting our books' code checked in time, we can do a quick 3.1.1 | 23:14 |
* srichter thinks that today was very productive; we should do this more often | 23:15 | |
anguenot | eheh cool :) | 23:15 |
J1m | anguenot, wanna meet me in #zope3-dev-307? | 23:16 |
srichter | wow, it deserves its own channel ;-) | 23:17 |
srichter | garrett-smith: does issue http://www.zope.org/Collectors/Zope3-dev/418 still exist? | 23:20 |
srichter | if so, it is a pretty serious security bug | 23:20 |
benji_york | I just removed SendmailMailer from the trunk and am testing the patch against the 3.0 branch | 23:20 |
benji_york | srichter 418 says it's resolved (by hdima) | 23:22 |
benji_york | (in revision 30886) | 23:22 |
srichter | duh! :-) | 23:23 |
benji_york | :) | 23:24 |
srichter | anguenot: I am getting a NotFoundError deprecation warning from src/optionstorage/browser/__init__.py when running ftests | 23:32 |
anguenot | srichter:checkin | 23:33 |
srichter | thanks | 23:35 |
anguenot | srichter: ok I'm deprecating this one. Wasn't expecting any import of zope.excecptions in here | 23:36 |
srichter | ok, thanks | 23:38 |
mgedmin | can somebody reproduce #327? | 23:39 |
mgedmin | I think it was fixed a while ago | 23:39 |
srichter | yeah, I am pretty sure hdima fixed that | 23:41 |
srichter | it is really a duplicate of another bug | 23:41 |
srichter | but I test it; hold on .. | 23:41 |
mgedmin | #302 is fixed! | 23:41 |
srichter | yipee! | 23:41 |
J1m | Yay! | 23:42 |
srichter | mgedmin: please remove it from TODO.txt and add it to CHANGES.txt | 23:42 |
mgedmin | (it took only 5 hours and 24 minutes... and I did everything with forms!) | 23:42 |
mgedmin | srichter, ack | 23:42 |
mgedmin | oh, TODO.txt says that #302 ought to be backported to 3.0.x | 23:43 |
* mgedmin doesn't want to do that... | 23:43 | |
srichter | yeah, let philiKON and the Zope 2 team worry about this; they are more people :-) | 23:43 |
anguenot | not tests for optionstorage.... | 23:44 |
anguenot | I thought it was a forbidden behavior ;) | 23:44 |
srichter | :-( | 23:44 |
srichter | it is; let's blame someone! :-) | 23:45 |
mgedmin | CHANGES.txt says that #327 was fixed | 23:45 |
J1m | What is optionstorage? | 23:45 |
anguenot | no copyright headers neither | 23:45 |
anguenot | yup | 23:45 |
srichter | mgedmin: ok, cool | 23:45 |
anguenot | Just deprecated a NotFoundError used at this level | 23:45 |
srichter | J1m: I thought optionstorage is a ZC thing? | 23:45 |
anguenot | is it used anywhere ? | 23:46 |
J1m | where is it? | 23:46 |
anguenot | src/optionstorage | 23:46 |
alga | src/zope/app/form/browser/schemadisplay.py has no tests either | 23:46 |
alga | for 3 years now or so | 23:46 |
srichter | :-( | 23:46 |
*** Aiste has quit IRC | 23:47 | |
srichter | mgedmin: I can confirm the fix | 23:47 |
anguenot | srichter: you were getting the deprecation message when launching the functional tests right ? | 23:47 |
srichter | yes | 23:48 |
alga | ok, | 23:48 |
alga | time to enjoy the last 10 minutes of the sysadmin appreciation day in our TZ | 23:49 |
srichter | :-) | 23:49 |
*** bradb has joined #zope3-dev | 23:49 | |
*** swampmonkey has left #zope3-dev | 23:51 | |
mgedmin | do I add new bug fixes at the top of the list in CHANGES.txt, or at the bottom? | 23:52 |
* mgedmin reached the hardest part of bugfixing -- bureaucracy^Wupdating the relevant txt files | 23:52 | |
srichter | ok, I have no gone through the new bugs that I had not looked at before and I did not find any critical new ones; so once TODO.txt is empty, we are really done and I'll cut RC1 | 23:52 |
srichter | mgedmin: I put new stuff always on the top | 23:53 |
mgedmin | ok | 23:53 |
benji_york | srichter, after Gary gets his form XXX fixes in, garrett-smith has one that he created that he's going to look at | 23:54 |
J1m | svn blames niemeyer for optionstorage | 23:54 |
srichter | oh, I think I know what it is | 23:55 |
mgedmin | good night everyone (it's 5 minutes to midnight here) | 23:55 |
*** mgedmin has quit IRC | 23:55 | |
srichter | it is a rewrite/improvement of the managable vocabularies I wrote for bugtracker | 23:55 |
GaryPoster | (I keep on trying to run tests, then folks check in changes, then I have to run the tests again, then I have to endure the ridicule of my co-workers for running a slow PowerBook :-P :-) ) | 23:56 |
srichter | maybe we should move that code to a sandbox? | 23:56 |
anguenot | Wait I'm just finishing the deprecation and the tests | 23:57 |
anguenot | test | 23:57 |
alga | thanks for the bug day! | 23:58 |
*** alga has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!