| bradallen | I guess I can tell users to use absolute URLs... | 00:02 |
|---|---|---|
| *** benji has quit IRC | 00:05 | |
| *** sprause has joined #zope3-dev | 00:06 | |
| *** povbot has quit IRC | 00:06 | |
| bradallen | This doesn't work: `DFW clean air plan <CleanAirPlan>`_ | 00:06 |
| bradallen | But this does: `DFW clean air plan <http://dfwairplan.timecastle.net:10090/DownwindersAtRisk/DfwAirPlan/introText>`_ | 00:08 |
| *** zmi_junkie has quit IRC | 00:18 | |
| sprause | bradallen: zwiki does simple text replace with CamelCase words -> html links. `DFW clean air plan <CleanAirPlan>`_ doesn't work, because reST already creates a link to "CleanAirPlan", then zwiki sees it and replaces it again | 00:23 |
| *** srichter has joined #zope3-dev | 00:23 | |
| *** ChanServ sets mode: +o srichter | 00:24 | |
| bradallen | Thanks! So either I need to stop using CamelCase on my wiki document names, | 00:27 |
| bradallen | or else see if I can take advantage of it. The problem is that I don't want the end result to look like a camelcase name. | 00:28 |
| bradallen | Hm...so zwiki has its own special syntax rules on top of reST | 00:31 |
| sprause | from what I see in zwiki/browser/wikipage.py it replaces camel case words and "[Wiki Page Here]" things with links | 00:32 |
| bradallen | Maybe I shouldn't bother with trying to use reST. | 00:35 |
| bradallen | I was just trying to find something easy for the end users. | 00:35 |
| bradallen | zwiki does plain text too | 00:35 |
| *** zbir` has joined #zope3-dev | 00:37 | |
| dman13 | yeah, CamelCase words is the normal syntax for a "wiki word" (zwiki didn't make it up) | 00:39 |
| dman13 | and they automatically refer to a page with the same name | 00:39 |
| dman13 | that's part of the efficiency and simplicity (for people who aren't accustomed to writing <a> tags) of wikis | 00:39 |
| dman13 | if you just want reST documents, then just make a reST document (if such a content type doesn't already exist) instead of using wiki pages :-) | 00:39 |
| *** marita has joined #zope3-dev | 00:42 | |
| bradallen | CamelCase links work great when I use plain text mode for zwiki instead of reST. | 00:42 |
| bradallen | I'd like to find out what other special syntax zwiki supports. | 00:43 |
| bradallen | I've been digging around at zwiki.org in the FAQ and other pages but have had trouble finding the right docs. | 00:43 |
| *** mkerrin has left #zope3-dev | 00:43 | |
| bradallen | At the moment I'm trying to figure out how to do something like [ text wording -> CamelCaseLink] | 00:44 |
| marita | srichter: If I have tal:content="item/id" i18n:translate="" in ZPT, shouldn't this translate my id if the string is in the po file? | 00:44 |
| marita | If I write the same string inside the tag, it gets translated. But item/id doesn't. | 00:45 |
| bradallen | [[DFW air plan -> DfwAirPlan]] causes a system error. | 00:45 |
| marita | Is that a bug or a feature? | 00:45 |
| sprause | bradallen: I think that the zwiki in zope 3 is a new/other wiki implementation and has nothing to do with the one from zwiki.org, but I'm not sure | 00:46 |
| bradallen | ok, I found http://zwiki.org/QuickReference | 00:46 |
| bradallen | sorry to keep pestering | 00:47 |
| sprause | marita: probably use i18n:translate="some_id" and translate "some_id"? | 00:47 |
| marita | sprause: No, that doesn't work either. In that case I have to remove the tal:content directive to get the PT compiled, and then it just displays the untranslated text between the tags :-( | 00:51 |
| dman13 | bradallen: zwiki.org is for the Zope2 ZWiki product not the zope3 zwiki package | 00:51 |
| dman13 | bradallen: some of the docs may be applicable, but some won't be | 00:51 |
| bradallen | so, no docs for the Z3 version? | 00:51 |
| bradallen | Maybe at least the wiki syntax will be similar | 00:52 |
| *** bradb has left #zope3-dev | 00:53 | |
| bradallen | well, this doesn't work [DFW air plan DfwCleanAirPlan] | 00:54 |
| srichter | marita: should work, yes | 00:54 |
| bradallen | nor does this: [DfwCleanAirPlan DFW clean air plan] | 00:54 |
| marita | srichter: But doesn't. At least not in Z3.1. | 00:55 |
| srichter | I doubt that | 00:55 |
| srichter | we use this sort of pattern everywhere in Zope 3 | 00:56 |
| marita | srichter: No, most of the strings are translated before they go into tal, if I get the code right. | 00:57 |
| srichter | take for example the container content view; the size is translated like in your example, if I remember correctly | 00:58 |
| srichter | are you sure your domain is set correctly? | 00:58 |
| marita | Yes. I can write the string that item/id returns inside the tags and remove the tal:content directive. Then it is translated. Does that make any difference for the translation engine? | 00:59 |
| *** sashav has quit IRC | 01:00 | |
| srichter | yes | 01:00 |
| srichter | each message has their own domain associated with it | 01:00 |
| *** J1m has quit IRC | 01:01 | |
| srichter | it will not use the domain specified in ZCML | 01:01 |
| srichter | it will not use the domain specified in TAL (I mean) | 01:02 |
| marita | Well, but if I specify the domain with i18n:domain right in the tag, that should work, yes? | 01:02 |
| srichter | nope | 01:02 |
| srichter | the message domain will always be used | 01:02 |
| srichter | that's the entire point of domains | 01:03 |
| marita | That's not useful. | 01:03 |
| sprause | bradallen: ah got it: you can add a ! as the very first character of the line to disable any zwiki linking. so "! some text `DFW clean air plan <FooBar>`_ more text" should work | 01:03 |
| marita | It should be possible (like in Zope2's implementation) to translate ANY string in the PT, regardless where it comes from. Otherwise the concept of "translation at the latest point" does not work. | 01:04 |
| marita | How should I translate item/id then? | 01:04 |
| *** jinty has left #zope3-dev | 01:05 | |
| bradallen | sprause: interesting...thanks for finding that. However, I'm thinking the WikiWord approach will be more friendly to the end user. I just need to find a way for them to supply alternative text to the article doesn't read like its full of WikiWords. I tried the [Wikipedia | http://www.wikipedia.org] syntax just to see if it would work, but it didn't. | 01:06 |
| marita | My impression is that tal:content is not translated at all ATM. | 01:08 |
| d2m | bradallen: zwiki on zope3 supports plaintext, STX (with embedded html) and reST formatted text -- linking in STX goes like so: "Wikipedia":http://www.wikipedia.org | 01:10 |
| bradallen | d2m: I'm trying to get that work but it's coming out garbled. | 01:13 |
| bradallen | input: A new regional "DFW clean air plan":DfwCleanAirPlan is in the works. | 01:13 |
| bradallen | output (as STX): A new regional DfwCleanAirPlan">DFW clean air plan is in the works. | 01:14 |
| bradallen | Maybe that syntax doesn't allow wikiwords. | 01:14 |
| marita | srichter: For the size, it's a message id that is generated BEFORE it is passed to the PT: size = _('${items} items'). | 01:15 |
| bradallen | I was just hoping to use a relative URL to wiki pages in my site. | 01:15 |
| d2m | bradallen: i'll check that... | 01:15 |
| marita | srichter: If that's the only way to do this I'll have to write my own "translateableId" method or so. That's not how things should work. | 01:16 |
| d2m | bradallen: you are right, this version does not support WikiWords als linktargets | 01:18 |
| bradallen | d2m: this is almost working: "DFW clean air plan":http:DfwCleanAirPlan | 01:19 |
| d2m | bradallen: OTOH the wikipage name does not need to be a wikiword | 01:19 |
| bradallen | I just want to use a relative url. | 01:20 |
| bradallen | here is what the link target resolved to: http://dfwairplan.timecastle.net:10090/DownwindersAtRisk/DfwAirPlan/wiki/FrontPage/DfwCleanAirPlan | 01:20 |
| bradallen | that was very close | 01:20 |
| bradallen | The only thing wrong was the FrontPage that got inserted into the URL | 01:20 |
| d2m | bradallen: "DFW clean air plan":../Dfwcleanairplan is perfectly working | 01:21 |
| bradallen | I will try it | 01:21 |
| d2m | bradallen: if you got a page named 'Dfwcleanairplan' | 01:21 |
| bradallen | d2m: it didn't work for me. The output looked like DfwCleanAirPlan">DFW clean air plan | 01:22 |
| d2m | bradallen: please look into the html source of the rendered page, you'll immediately see where the problem is | 01:23 |
| d2m | bradallen: STX itself knows nothing about wiki/zwiki/wikiwords | 01:24 |
| bradallen | ziki is inserting another a href | 01:25 |
| bradallen | on top of the STX a href | 01:25 |
| marita | srichter: | 01:25 |
| marita | foo | 01:25 |
| marita | works. But can it get any uglier? | 01:25 |
| d2m | bradallen: correct, zwiki renders wikiwords into links | 01:25 |
| d2m | bradallen: if you want to use descriptive link titles do not use wikiwords for pageids | 01:26 |
| bradallen | d2m: I may change my naming convention and use underscore separated words | 01:26 |
| d2m | bradallen: relative links in STX need to have the format "Link Title":../pageid | 01:28 |
| bradallen | d2m: Yes, it's working now that I got rid of the wikiword page name. Sweet relief. | 01:29 |
| d2m | bradallen: in this version of zwiki | 01:29 |
| *** niemeyer has quit IRC | 01:29 | |
| bradallen | d2m: Thanks for your help, d2m. I'm supposed to have an end user meeting later tonight and I wanted to hame something to show. | 01:30 |
| d2m | bradallen: np, #zwiki is another channel for general wiki support | 01:31 |
| bradallen | d2m: noted. Thanks. | 01:33 |
| marita | srichter: My problem was Collector 455: http://www.zope.org/Collectors/Zope3-dev/455 | 01:41 |
| marita | Seems to be fixed in svn | 01:42 |
| *** marita has left #zope3-dev | 01:46 | |
| *** lifeless has joined #zope3-dev | 02:02 | |
| *** sprause has quit IRC | 02:15 | |
| *** yota has quit IRC | 03:02 | |
| *** stub has joined #zope3-dev | 04:24 | |
| *** sashav has joined #zope3-dev | 06:10 | |
| *** natea has joined #zope3-dev | 07:10 | |
| *** Theuni has joined #zope3-dev | 08:09 | |
| *** eins has joined #zope3-dev | 08:16 | |
| *** dobee has joined #zope3-dev | 08:32 | |
| *** stub has quit IRC | 08:56 | |
| *** hdima has joined #zope3-dev | 09:29 | |
| *** stub has joined #zope3-dev | 09:48 | |
| *** romanofski has joined #zope3-dev | 09:53 | |
| romanofski | moin | 09:53 |
| *** _agroszer has joined #zope3-dev | 09:53 | |
| *** zagy has joined #zope3-dev | 09:59 | |
| *** Theuni changes topic to "zope3-dev | Bug day today | Zope 3.1.0final released! | Help translating Zope 3.1 into your language! | logs available at http://zope3.pov.lt/irclogs/" | 10:05 | |
| *** hazmat has joined #zope3-dev | 10:09 | |
| *** MJ has quit IRC | 10:11 | |
| *** Aiste has quit IRC | 10:12 | |
| *** sashav has quit IRC | 10:19 | |
| eins | hi romanofski | 10:42 |
| *** sashav has joined #zope3-dev | 10:44 | |
| romanofski | hey eins :) | 10:47 |
| *** tarek has joined #zope3-dev | 10:51 | |
| *** SteveA has quit IRC | 11:09 | |
| *** Aiste has joined #zope3-dev | 11:25 | |
| *** drzoltron_ has joined #zope3-dev | 11:28 | |
| *** MJ has joined #zope3-dev | 11:35 | |
| *** MJ has joined #zope3-dev | 11:38 | |
| *** MJ has joined #zope3-dev | 11:43 | |
| *** jinty has joined #zope3-dev | 11:51 | |
| *** andres__ has joined #zope3-dev | 12:03 | |
| *** _agroszer has quit IRC | 12:05 | |
| *** andres has quit IRC | 12:10 | |
| *** andres__ is now known as andres | 12:10 | |
| *** natea has quit IRC | 12:14 | |
| *** MJ has quit IRC | 12:19 | |
| *** MJ has joined #zope3-dev | 12:38 | |
| *** mgedmin has joined #zope3-dev | 12:50 | |
| *** niemeyer has joined #zope3-dev | 12:55 | |
| *** drzoltron_ has quit IRC | 13:06 | |
| *** MrTopf has joined #zope3-dev | 13:48 | |
| *** MJ has quit IRC | 13:54 | |
| *** MrTopf has quit IRC | 13:56 | |
| *** MrTopf has joined #zope3-dev | 13:57 | |
| * Theuni tries to start his zope3 bug daz | 14:00 | |
| * Theuni tries to start his zope3 bug day | 14:01 | |
| Theuni | anybody awake already so I can bug him about stuff? | 14:05 |
| Theuni | Example: Bug 430. srichter's last comment is somehow ambigous. He said "it is not serious" but set the level to critical. | 14:06 |
| Theuni | Additionally the file mentioned "donothing.sh" isn't in the repository anymore it seems | 14:06 |
| andres | a question regarding securityproxies. | 14:10 |
| Theuni | an answer about securityproxies. | 14:10 |
| andres | Is it correct, that an instance of SQLObject failes isinstanceof(obj, SQLObject) after obj has been security proxied? | 14:11 |
| *** MJ has joined #zope3-dev | 14:12 | |
| Theuni | I'm just starting with zope 3 again, but IIRC proxies should not make isinstance() fail | 14:12 |
| Theuni | mr pieters! | 14:12 |
| andres | Theuni, the problem is, that they do. | 14:14 |
| BjornT | andres, Theuni: it does fail. (it'd be nice if it didn't, though) | 14:14 |
| Theuni | BjornT: ok ... wasn't sure anyway | 14:14 |
| Theuni | So it's the official intended behaviour right now? | 14:14 |
| BjornT | that i don't know | 14:15 |
| Theuni | hm | 14:15 |
| *** ignas has joined #zope3-dev | 14:15 | |
| srichter | Theuni: feel free to demote any bugs | 14:16 |
| srichter | Theuni: a critical bug does not necessarily mean it is critical; I usually just want people to look at it before the release and get another opinion | 14:16 |
| srichter | andres: yes, so use zapi.isinstance | 14:17 |
| Theuni | srichter: i see. so you'd agree on bug 430? | 14:19 |
| srichter | I agree on 420 | 14:20 |
| *** vlado has joined #zope3-dev | 14:20 | |
| Theuni | k | 14:20 |
| srichter | I think 430 is fixed | 14:20 |
| Theuni | you agree to move 420 to feature request as well? | 14:21 |
| srichter | yeah | 14:21 |
| mgedmin | Theuni, there's zope.proxy.isinstance, IIRC | 14:21 |
| mgedmin | which strips away the proxy | 14:21 |
| srichter | no, it's in zapi, I think | 14:21 |
| *** _agroszer has joined #zope3-dev | 14:22 | |
| * Theuni made 420 a feature request and non-critical. | 14:22 | |
| Theuni | mgedmin, srichter: aha ... | 14:22 |
| Theuni | good to know | 14:22 |
| andres | srichter, the problem is, that thats foreign code not using zope. | 14:24 |
| srichter | well then make sure the object you pass to the foreign code is not security proxied | 14:24 |
| srichter | it's a disadvantage of proxies that we can do nothing about | 14:25 |
| andres | srichter, ok, i hope i can finde a way. | 14:28 |
| * Theuni works on 443 | 14:31 | |
| *** MiUlEr has quit IRC | 14:38 | |
| *** faassen has joined #zope3-dev | 14:45 | |
| *** yota has joined #zope3-dev | 14:56 | |
| *** jhauser has joined #zope3-dev | 14:57 | |
| *** efrerich has joined #zope3-dev | 14:59 | |
| *** _fermigier has quit IRC | 15:03 | |
| *** _fermigier has joined #zope3-dev | 15:04 | |
| *** tlotze has joined #zope3-dev | 15:05 | |
| *** mkerrin has joined #zope3-dev | 15:06 | |
| Theuni | srichter: regarding 443. I wonder why the Bytes-Class does a super() for _toFieldValue | 15:09 |
| Theuni | a byte input widget most certainly doesn't want to treat it's input as text. | 15:09 |
| andres | How long do you plan to work on the bugs today? | 15:10 |
| Theuni | I'm going to be around until 4:30pm CET | 15:10 |
| Theuni | eventually i will come back later then | 15:10 |
| Theuni | gotta exercise in between | 15:10 |
| Theuni | at least 2.5 more hours for me | 15:10 |
| * Theuni scratches his head on hte Bytes thingy anyway | 15:11 | |
| *** zbir` has quit IRC | 15:12 | |
| Theuni | aha ... so on text/* it treats the input like ascii | 15:14 |
| Theuni | but it shouldn't treat it like html | 15:14 |
| *** MJ has quit IRC | 15:21 | |
| *** efge has joined #zope3-dev | 15:36 | |
| Theuni | (phew | 15:37 |
| Theuni | srichter: ayt? | 15:37 |
| * Theuni feels very lonely right now | 15:39 | |
| *** MJ has joined #zope3-dev | 15:39 | |
| Theuni | Why is an ASCIIAreaWidget expected to convert line endings? | 15:39 |
| Theuni | I'd expect an ASCII widget to _not_ change anything on the content at all | 15:39 |
| * mgedmin hugs Theuni and runs away | 15:42 | |
| Theuni | :( | 15:43 |
| *** xenru has joined #zope3-dev | 15:43 | |
| Theuni | Y M C A | 15:43 |
| * Theuni jumps around | 15:43 | |
| * tlotze hides | 15:44 | |
| * Theuni checks another bug until someone tells him he's doing the right hting | 15:47 | |
| *** MJ has quit IRC | 15:49 | |
| mgedmin | oh, it's a bug day today | 15:52 |
| Theuni | ... | 15:57 |
| Theuni | at least for me :) | 15:57 |
| *** zbir` has joined #zope3-dev | 15:58 | |
| mgedmin | I'd be happy to fix http://www.zope.org/Collectors/Zope3-dev/497 :-) | 16:01 |
| *** MJ has joined #zope3-dev | 16:02 | |
| Theuni | can somebody explain to me why data that goes _into_ the text widgets is xml-unescaped? | 16:03 |
| Theuni | that makes no sense to me | 16:03 |
| * Theuni doesn't feel touched by that bug | 16:04 | |
| *** dobee has quit IRC | 16:05 | |
| *** MJ has quit IRC | 16:06 | |
| *** jinty has quit IRC | 16:06 | |
| efge | Theuni: hm that feels very wrong | 16:07 |
| Theuni | what feels wrong? | 16:08 |
| Theuni | do you mean the current way, or not unescaping it? | 16:08 |
| efge | xml-unescaping before displaying a widget | 16:08 |
| efge | it should be escaped, on the contrary | 16:08 |
| Theuni | wait | 16:08 |
| Theuni | bad description of me | 16:08 |
| Theuni | _toFormValue calls escape. thats fine. | 16:09 |
| Theuni | _toFieldValue calls unescape. That's bad. | 16:09 |
| efge | ah. yes it is. | 16:09 |
| Theuni | if you remember algebra, this call creates a defect on the mapping which ends up in the known bugs. | 16:09 |
| Theuni | so, anybody objects me removing the unescape calls? | 16:09 |
| efge | Theuni: I'm sure some buggy tests have to be fixed too | 16:10 |
| Theuni | of course | 16:10 |
| *** MJ has joined #zope3-dev | 16:10 | |
| Theuni | they're expecting the wrong thing now ... but i can update them of course | 16:10 |
| efge | k | 16:10 |
| Theuni | i just wanted to know if my idea what's wrong is correct. | 16:10 |
| * Theuni is happy | 16:10 | |
| jhauser | does this fix a bug? | 16:10 |
| Theuni | it fixes two bugs | 16:11 |
| Theuni | 443 and 468 | 16:11 |
| Theuni | and they are both marked critical | 16:11 |
| Theuni | hah! | 16:11 |
| *** yota has quit IRC | 16:11 | |
| *** stub has quit IRC | 16:11 | |
| jhauser | ok what will people have done up to now, to circumvent this? | 16:11 |
| Theuni | nothing | 16:11 |
| Theuni | they can't | 16:11 |
| Theuni | they just can't use the stuff | 16:11 |
| Theuni | that's the beauty of defect mappings | 16:12 |
| jhauser | fine, I aks only because I do not overseee such changes | 16:12 |
| *** MJ has quit IRC | 16:13 | |
| Theuni | hmm | 16:15 |
| Theuni | right | 16:15 |
| *** MJ has joined #zope3-dev | 16:17 | |
| *** MacYET has joined #zope3-dev | 16:18 | |
| *** romanofski has quit IRC | 16:19 | |
| *** yota has joined #zope3-dev | 16:21 | |
| *** stub has joined #zope3-dev | 16:26 | |
| *** MJ has quit IRC | 16:29 | |
| Theuni | finally. fixed two bugs ... | 16:37 |
| *** _agroszer has quit IRC | 16:40 | |
| *** _agroszer has joined #zope3-dev | 16:40 | |
| *** dobee has joined #zope3-dev | 16:41 | |
| *** __mac__ has quit IRC | 16:41 | |
| *** GaryPoster has joined #zope3-dev | 16:46 | |
| *** zagy has quit IRC | 16:46 | |
| *** MJ has joined #zope3-dev | 16:47 | |
| *** jinty has joined #zope3-dev | 16:48 | |
| *** mgedmin has quit IRC | 16:51 | |
| *** TresEquis has joined #zope3-dev | 16:53 | |
| *** jinty has quit IRC | 16:54 | |
| TresEquis | srichter: why did you bump #474 to critical? A newly-fussy compiler warning shouldn't be a release blocker | 16:59 |
| MacYET | you can ignore those warnings | 17:00 |
| Theuni | hooray ... i was afraid to move that down | 17:01 |
| Theuni | TresEquis: srichter told me that he just bumped up a couple of things and we should put them down if we want | 17:01 |
| Theuni | he wanted us to look at them | 17:01 |
| *** MJ has quit IRC | 17:01 | |
| * Theuni currently looks at 446 | 17:01 | |
| Theuni | hmm | 17:03 |
| *** eins has quit IRC | 17:04 | |
| Theuni | Hmm. I don't exactly see where headers are encoded differently than ascii ... | 17:08 |
| Theuni | I mean, i wonder why addHeader has a bit different encoding semantic thatn setHeader | 17:09 |
| Theuni | but setHeader makes it str() ... | 17:09 |
| *** jfmoxley has joined #zope3-dev | 17:11 | |
| *** hdima has quit IRC | 17:12 | |
| *** MacYET has left #zope3-dev | 17:14 | |
| *** J1m has joined #zope3-dev | 17:18 | |
| jfmoxley | i've used zapi.getParent in a few places in my code, but now in a new place i'm getting... TypeError("Not enough context information to get parent", obj)... which i dont understand because i've registered the containment with the parent container | 17:19 |
| *** MJ has joined #zope3-dev | 17:20 | |
| jfmoxley | any ideas? | 17:20 |
| *** _anguenot has joined #zope3-dev | 17:20 | |
| andres | jfmoxley, i once got that error, because i set __parent__ but not __name__. | 17:24 |
| jfmoxley | andres: thanks. but shouldn't the container.constraints.containers() | 17:26 |
| jfmoxley | in the child | 17:26 |
| *** jhauser has quit IRC | 17:26 | |
| andres | jfmoxley, no idea, i dont know your code. | 17:26 |
| jfmoxley | and container.constraints.contains() in the parent take care of everything? | 17:26 |
| jfmoxley | andres: ok thanks | 17:26 |
| *** MJ has quit IRC | 17:27 | |
| *** jhauser has joined #zope3-dev | 17:29 | |
| jfmoxley | you know what, this is in my python test suite... maybe zope needs to start up in order to arrange the parent-child relationships | 17:29 |
| * Theuni cleans up the german translation a _bit_ | 17:29 | |
| _agroszer | Theuni: ping | 17:38 |
| Theuni | blubb | 17:38 |
| _agroszer | regarding Issue #451 | 17:38 |
| _agroszer | I think Dominik fixed it already | 17:38 |
| TresEquis | I've downgraded 474 to "low" | 17:38 |
| Theuni | aha! | 17:38 |
| Theuni | TresEquis: excellent | 17:39 |
| _agroszer | still I have to check the results | 17:39 |
| Theuni | _agroszer: can you check that definitively and close the bug or tell me what to do? | 17:39 |
| _agroszer | ok, I'll check | 17:39 |
| *** TresEquis changes topic to "Bug day today, critical #s: 430,441,444,446,451,465,466 | Zope 3.1.0final released! | Help translating Zope 3.1 into your language! | logs available at http://zope3.pov.lt/irclogs/" | 17:41 | |
| *** MJ has joined #zope3-dev | 17:45 | |
| *** jukart has joined #zope3-dev | 17:46 | |
| TresEquis | w.r.t #441: I don't think it should be critical either | 17:49 |
| TresEquis | It is a weird corner case, with a workaround | 17:49 |
| TresEquis | we can certainly do a beta without a fix | 17:49 |
| *** MJ has quit IRC | 17:50 | |
| *** TresEquis changes topic to "Bug day today, critical #s: 430,444,446,451,465,466 | Zope 3.1.0final released! | Help translating Zope 3.1 into your language! | logs available at http://zope3.pov.lt/irclogs/" | 17:51 | |
| Theuni | i just noticed there also are a couple of "urgent" bugs around | 17:53 |
| Theuni | i don't think 296 is urgent | 17:55 |
| Theuni | it was urgent for 3.1 already and wasn't resolved then. doesn't sound very urgent. | 17:55 |
| *** bradb has joined #zope3-dev | 17:56 | |
| * TresEquis notes that there was *nothing* urgent about 3.1 | 17:57 | |
| *** bradallen has quit IRC | 17:58 | |
| Theuni | :) | 17:58 |
| *** mgedmin has joined #zope3-dev | 17:58 | |
| Theuni | so you agree on that or was that a general remark? :) | 17:58 |
| Theuni | man | 17:59 |
| Theuni | those german translations provide more confusion than translation ... | 17:59 |
| Theuni | This object isnt actually used, except if it's registered, and it is active. | 18:00 |
| Theuni | and the translation has some slight syntactical problems because the german translation says that it is active but won't be used until registered ... | 18:00 |
| J1m | Do we claim to support DAV? | 18:01 |
| Theuni | did we in 3.1? | 18:02 |
| J1m | I don't know. | 18:03 |
| Theuni | would it make a difference? | 18:03 |
| J1m | It would determine whether 369 neded to be fixed. | 18:04 |
| J1m | I'm not really sure what the current status is. | 18:04 |
| Theuni | change.txt says this for 3.0 milestone2: - Partial WebDAV support | 18:04 |
| J1m | This may even have been fixed. | 18:04 |
| J1m | I guess it depends on what you mean by "partial". :) | 18:05 |
| Theuni | 369 is recorded in the history to hve been fixed in 3.1.0 | 18:05 |
| Theuni | eventually someone didn't change the collector issue | 18:06 |
| J1m | ah cool. Then I'll clode it. | 18:06 |
| J1m | close it | 18:06 |
| J1m | :) | 18:06 |
| J1m | done | 18:07 |
| *** MJ has joined #zope3-dev | 18:09 | |
| J1m | Hm, srichter says 431 was for 3.0 not trunk. | 18:09 |
| J1m | I'm getting Gary to try make check on trunk. | 18:09 |
| J1m | If nothing bad happens, I'll close it. :) | 18:09 |
| Theuni | great | 18:10 |
| Theuni | hmm. svn praise for the changelog is slow | 18:10 |
| *** jukart has left #zope3-dev | 18:10 | |
| J1m | 466 should be easy. | 18:11 |
| J1m | Is anyone working on it? | 18:11 |
| * J1m about to start on 444. | 18:11 | |
| Theuni | sounds easy | 18:12 |
| Theuni | but i'm not sure i can handle it | 18:12 |
| Theuni | actually | 18:12 |
| Theuni | i'm not sure i know what to do | 18:12 |
| Theuni | do you agree to add a intid utility? | 18:12 |
| J1m | no | 18:12 |
| Theuni | aha | 18:12 |
| Theuni | so then i'm not sure what will be easy :) | 18:12 |
| J1m | Just change reindex to filter out objects not in the same site. | 18:13 |
| Theuni | hmm | 18:13 |
| Theuni | i'll try | 18:13 |
| *** MJ has quit IRC | 18:13 | |
| J1m | Hint, use zope.app.location.inside. | 18:14 |
| Theuni | ! | 18:14 |
| Theuni | thanks | 18:14 |
| J1m | Now, the tricky thing is how to handle non-locations. | 18:14 |
| J1m | I'm not sure we have any. | 18:14 |
| J1m | wait | 18:15 |
| J1m | maybe a better option is to fix this with documentation for now. | 18:15 |
| *** bradb has left #zope3-dev | 18:15 | |
| Theuni | o-k | 18:15 |
| J1m | Maybe mention this as a limitation. And mention the work around. | 18:15 |
| Theuni | Ok. | 18:15 |
| J1m | Then, for some later release, we could add something else. | 18:16 |
| J1m | Like, mabe something like Gary's extent catalog. | 18:16 |
| J1m | maybe | 18:16 |
| J1m | Yup, I think dodumenting the issue is best for now. | 18:16 |
| J1m | documenting | 18:16 |
| J1m | lower risk and quicker. | 18:17 |
| Theuni | Ok. I'll do that, I'll keep the bug open and lower the priority | 18:17 |
| J1m | I would change it to an issue and lower the priority. | 18:17 |
| Theuni | ok | 18:18 |
| Theuni | do you want that to be documented in the catalog README.txt only or should I add a short note in the UI as well? | 18:20 |
| J1m | You're call. :) | 18:20 |
| * Theuni goes to the box with the big red letters | 18:20 | |
| J1m | srichter, ayt? | 18:22 |
| J1m | For 446, I think we should ask Steve to verify that the bug still exists. | 18:23 |
| J1m | It's very possible that it was fixed by the major refactoring we did for wsgi. | 18:24 |
| Theuni | right. he isn't here right now and i hope he reacts on the collector mail, but that might not happen. | 18:24 |
| J1m | Maybe mgedmin or Aiste can ping him. :) | 18:25 |
| Aiste | J1m: hi, how urgent is this thing for Steve? | 18:27 |
| J1m | It would be nice to get this today, but if not, then in the next week or so. | 18:28 |
| Aiste | ok, I'll tell him that | 18:28 |
| J1m | I think we should not let this hold up the beta release, but, if there is still an issue, we'll want to address it before the final release. | 18:28 |
| Aiste | he's pretty busy now though | 18:28 |
| J1m | Fair enough. | 18:28 |
| J1m | Is anyone here a mac developer? | 18:28 |
| TresEquis | Aiste,J1m: really comes down to how urgently Steve wants if fixed before a 3.2 beta | 18:29 |
| TresEquis | we need a "target release" metadata field for the issues | 18:30 |
| *** MJ has joined #zope3-dev | 18:31 | |
| J1m | This version of the Collector doesn't seem to allow custom fields. | 18:32 |
| * Theuni pets his bugzilla | 18:33 | |
| J1m | Currently, we express target release through importance. Urgent means next release. Anything else means a later release. :) | 18:33 |
| WebMaven | hazmat: ayt? | 18:37 |
| *** MrTopf has quit IRC | 18:40 | |
| J1m | zope.server.http.tests.test_httpserver.Tests.testManyClients fails on Mac OS. | 18:40 |
| J1m | See 500 | 18:41 |
| J1m | I don't really know what the point of this test is. | 18:41 |
| *** stub has quit IRC | 18:42 | |
| efge | J1m: on Mac OS X when I run the test and that tests fails, there are more than 256 files open (seen using lsof)! Mac's default limit is 256 files open max | 18:44 |
| *** mkerrin has left #zope3-dev | 18:45 | |
| *** xenru|clone has joined #zope3-dev | 18:45 | |
| *** _agroszer is now known as crystalBall | 18:47 | |
| crystalBall | Theuni: #451 is not quite 100% | 18:47 |
| Theuni | crystalBall: ok, can you give me more information about the exception? | 18:48 |
| crystalBall | the problem is that the different widgets have different __init__ signatures | 18:49 |
| crystalBall | I mean widget types | 18:49 |
| crystalBall | just a sec | 18:49 |
| Theuni | I added a new css class "bug" to highlight bug information. Does anybody object on that? | 18:49 |
| Theuni | It's pretty much like a message but with different semantics and a different margin. | 18:50 |
| Theuni | I changed the rotterdam/zope3_tablelayout.css for that. | 18:50 |
| crystalBall | I started a thread "[Zope3-dev] RFC: CustomWidgetFactory and widgets having different __init__ signature" | 18:50 |
| Theuni | i'll try to watch that | 18:50 |
| Theuni | Anyway, how severe is the problem? | 18:50 |
| * crystalBall digging in the mailbox | 18:51 | |
| J1m | efge, that's interesting. | 18:51 |
| J1m | efge, That test is ostensibly only opening 50 connections. | 18:51 |
| J1m | efge, if you run just that test, by itself, does it pass? | 18:51 |
| efge | J1m: trying now... | 18:52 |
| efge | yes it does | 18:52 |
| efge | all zope.server at once too | 18:52 |
| * crystalBall found it, forwards... | 18:52 | |
| efge | hm lemme take that back... retrying | 18:52 |
| efge | J1m: yes, ./test.py -s zope.server passes all 73 tests | 18:53 |
| J1m | sigh | 18:54 |
| J1m | so, some other tests are leaking file descriptors. | 18:54 |
| J1m | and causing this one to fail. | 18:54 |
| J1m | But I still fail to see the point of this test. | 18:55 |
| Theuni | Do we have a central "known issues" place for releases? | 18:55 |
| crystalBall | Theuni: should have landed in your inbox | 18:55 |
| Theuni | (except the collector) | 18:55 |
| J1m | Theuni, good question. | 18:55 |
| Theuni | crystalBall: ack | 18:55 |
| Theuni | J1m: i'm not implying we urgently need one, but i would add the documented bug there if it exists. | 18:56 |
| J1m | srichter, ayt? | 18:56 |
| efge | J1m: the leaked fds appear to be descriptors for the / root directory according to lsof | 18:56 |
| J1m | what documented bug? | 18:56 |
| Theuni | 466 | 18:56 |
| Theuni | the one i took for documenting it | 18:57 |
| J1m | Theuni, I don't consider that to be a bug. :) | 18:57 |
| J1m | I consider that to be an issue. | 18:57 |
| J1m | anyway | 18:57 |
| J1m | I think the collector should be enough. | 18:58 |
| J1m | Trying to manage some document would be too hard imo. | 18:58 |
| J1m | efge, that is weird. | 18:58 |
| Theuni | ack | 18:58 |
| J1m | efge, would you try adding a gc.collect() to the top of that test. | 18:59 |
| efge | k | 18:59 |
| J1m | efge, that is just a stab in the dark. | 18:59 |
| J1m | If that doesn't work, I suggest we should: | 19:00 |
| J1m | - disable the test or | 19:00 |
| J1m | - try giving that test it's own layer. | 19:00 |
| J1m | Hm, never mind that. | 19:01 |
| J1m | well, that would be a hack. | 19:01 |
| *** xenru has quit IRC | 19:01 | |
| J1m | If it is in a layer and if we arrange that the layer runs after the functional tests, it will run as a subprocess and thus probably pass. :) | 19:02 |
| crystalBall | Theuni: any ideas about it? | 19:02 |
| Theuni | crystalBall: nope, sorry. well ... i mean ... one would have to make all signatures be the same, right? | 19:02 |
| crystalBall | Theuni, either that or mark them with something and build a big if structure | 19:03 |
| crystalBall | if the different parameters can be guessed from the context | 19:03 |
| crystalBall | wait a sec | 19:03 |
| crystalBall | how does the adapter machinery do the same, I mean instaciating the widgets? | 19:04 |
| * Theuni shrugs | 19:05 | |
| J1m | Does anyone know of a way to find out how many file-descriptors a Python process is using? | 19:06 |
| jhauser | lsof |grep python | 19:06 |
| J1m | jhauser, from Python | 19:06 |
| jhauser | ah :-) | 19:07 |
| Theuni | jhauser: lsof -p PID would be better | 19:07 |
| TresEquis | os.system('lsof | grep python') ;) | 19:07 |
| Theuni | /proc/ could be helpful as well .. :) | 19:08 |
| GaryPoster | crystalBall: multiple adaptations. It's necessary to get the different sort of lookups we need, for instance for Choice fields (of what source?), List (of what value type?) fields, and so on. | 19:08 |
| crystalBall | Theuni, several people say that the widget framework needs some refactoring | 19:08 |
| efge | J1m: the leaks appear to come from zope.app.form.browser | 19:08 |
| J1m | Oh? | 19:08 |
| Theuni | crystalBall: those people might be right. i don't know. i'm just working with duct tape right now ... | 19:09 |
| crystalBall | Theuni, well this is not the time for refactoring | 19:09 |
| *** Theuni changes topic to "Bug day today, critical #s: 430,444,446,451,465 | Zope 3.1.0final released! | Help translating Zope 3.1 into your language! | logs available at http://zope3.pov.lt/irclogs/" | 19:09 | |
| crystalBall | I'll say make the #451 not critical | 19:10 |
| GaryPoster | crystalBall: definitely. I've started a new one and need time to return to it. I've gotten permission to spend just a bit of time on it in December, and hopefully will have it as an alternate choice ready in 2006. Getting by is the thing to do now. | 19:10 |
| *** MJ has quit IRC | 19:10 | |
| GaryPoster | crystalBall: 'definitely': needs refactoring (or redoing IMO) | 19:10 |
| J1m | efge? | 19:11 |
| efge | yes? | 19:11 |
| crystalBall | ok, then Theuni, change the topic again, kill #451 | 19:11 |
| J1m | efge, what makes you think that zope.app.form.browser is the source of the problem? | 19:12 |
| efge | J1m: these are not the only tests leaking though | 19:12 |
| efge | J1m: I do lsof in one window while tests run with -vv in another | 19:12 |
| efge | I see big jumps in the number of open files sometimes | 19:12 |
| J1m | efge, I assume that gc.collect didn't make any difference. | 19:12 |
| efge | J1m: I'm still not there | 19:12 |
| *** jinty has joined #zope3-dev | 19:12 | |
| J1m | ah, ok | 19:12 |
| J1m | if it doesn't help, I have another crazy thing to try. | 19:13 |
| Theuni | crystalBall: ok | 19:13 |
| crystalBall | GaryPoster: can you assign the issue to yourself, that will be solved by the refactoring, please? | 19:13 |
| efge | J1m: actually I can't reproduce the test failure at the moment, I'll lower my max open files a bit | 19:14 |
| J1m | hm, interesting | 19:14 |
| *** Theuni changes topic to "Bug day today, critical or urgent #s: 296,381,430,431,444,446,448,465,473,484 | Zope 3.1.0final released! | Help translating Zope 3.1 into your language! | logs available at http://zope3.pov.lt/irclogs/" | 19:15 | |
| * crystalBall is also not needed anymore, as #451 is half-way solved | 19:15 | |
| *** crystalBall is now known as agroszer | 19:15 | |
| * mgedmin is interested in the hunt for file descriptor leaks, but is quite busy right now | 19:15 | |
| Theuni | sorry for letting the list of issues grow, but we overlooked the things marked urgent first | 19:15 |
| * TresEquis would look for calls to 'open' without an immediately-following 'try:...finally:' with close | 19:16 | |
| TresEquis | including tempfile stuff, particularly | 19:16 |
| GaryPoster | agroszer: I'm going to be offering a new package--a la zope.formlib vs. zope.app.form--and see if it gains traction. I have integration/migration plans, but it's more of a redo than a refactor. | 19:16 |
| J1m | TresEquis, that's why I suggested trying gc.collect. | 19:16 |
| TresEquis | but if the file reported as open by lsof is '/', then I would look for unreaped child processes | 19:17 |
| agroszer | GaryPoster: I see, looks like nobody used the zcml browser:widget and I can live with it currently | 19:18 |
| Theuni | anybody object downgrading #448 to medium? | 19:19 |
| J1m | TresEquis, why is that? | 19:20 |
| *** natea has joined #zope3-dev | 19:20 | |
| Theuni | Hmm. Can somebody tell me the order of medium,critical and urgent? | 19:21 |
| TresEquis | just speculating, but I could imagine that the processes are getting 'chdir'ed to '/', and then hanging around | 19:21 |
| Theuni | i wonder if urgent is higher than critical ... | 19:21 |
| J1m | Theuni, we should remove urgent | 19:21 |
| TresEquis | Theuni: I would class critical as *more* important that urgent | 19:21 |
| J1m | In fact, I will. | 19:21 |
| J1m | "urgent" is something that we're not really using. | 19:21 |
| Theuni | Great. I was just so confused right now | 19:22 |
| J1m | (It could be argued that we should. But let's not for now.) | 19:22 |
| Theuni | so everything urgent goes to medium? | 19:22 |
| J1m | I say forst to critical, and then we reevaluate. | 19:24 |
| Theuni | ok | 19:24 |
| Theuni | shall i do that? | 19:24 |
| *** BjornT has quit IRC | 19:26 | |
| efge | J1m: gc.collect() doesn't change the number of open files | 19:28 |
| Theuni | is "reject" the correct answer for issues that actually work? | 19:30 |
| WebMaven | Theuni: You mean, where the reported problem doesn't actually exist? | 19:30 |
| WebMaven | Theuni: Or, do you mena that the reported behaviour is actually expected? | 19:31 |
| Theuni | WebMaven: first | 19:32 |
| Theuni | bugzillas equivalent for "WORKSFORME" | 19:33 |
| Theuni | i love the process control | 19:33 |
| Theuni | it looks like it's still the stub we implemented 3 years ago | 19:33 |
| Theuni | it says "you restarted the server" without doing anything | 19:33 |
| WebMaven | Theuni, what are the status options? | 19:36 |
| agroszer | Theuni: it was working before twisted | 19:36 |
| Theuni | WebMaven: Comment Accept Resolve Reject Defer Restrict Wontfix Assign | 19:36 |
| Theuni | agroszer: hmm ... it looks like it's not completely stub ... :) | 19:36 |
| *** BjornT has joined #zope3-dev | 19:37 | |
| WebMaven | Reject looks correct. | 19:37 |
| Theuni | restart says: # TODO: Graceful restart does not work yet. | 19:37 |
| Theuni | shutdown says: # TODO: Graceful shutdown does not work yet. | 19:37 |
| Theuni | WebMaven: ok | 19:37 |
| agroszer | it was maybe not graceful, but worked :-) | 19:38 |
| Theuni | hehe | 19:38 |
| agroszer | but I think twisted is clever, because if I (on win32) want close the command window, it waits until the requests get processed | 19:38 |
| Theuni | what's the difference between zope.app.server and zope.app.twisted? | 19:41 |
| Theuni | they both provide a non-working servercontrol module | 19:41 |
| agroszer | we should ask srichter | 19:42 |
| agroszer | or who did the twisted integration? | 19:42 |
| Theuni | dunno | 19:43 |
| yota | twisted integration ? stephan i think | 19:44 |
| *** jinty has quit IRC | 19:46 | |
| efge | this drops in the debugger for me: ./test.py -D -u -s zope.app.container -m test_constraints | 19:46 |
| efge | can someone confirm? | 19:46 |
| J1m | efge, yes | 19:49 |
| J1m | weird | 19:49 |
| efge | J1m: I'm just fixing that one now | 19:50 |
| Theuni | from what i can tell i would have to trigger a twisted system event for shutdown ... | 19:50 |
| Theuni | can anybody confirm that? | 19:50 |
| J1m | efge, what are you fixing? | 19:53 |
| efge | J1m: the problem of the teardown in test_constraints.py | 19:53 |
| J1m | It'd off that the tearDown failure isn't reported by the normal unittest test running code. | 19:53 |
| J1m | It's odd that the tearDown failure isn't reported by the normal unittest test running code. | 19:54 |
| agroszer | Theuni: I don't know twisted, but +1 | 19:54 |
| Theuni | agroszer: it looks like it works by simply firing the correct events in twisted | 19:55 |
| Theuni | at least the shutdown | 19:56 |
| agroszer | would be good to know how it handles the kill process request | 19:57 |
| J1m | Oh weird. | 19:57 |
| J1m | So the tearDown only fails when running with -D. | 19:58 |
| J1m | efge? | 19:58 |
| efge | J1m: I'm now running tests with -vv and a log between each test of the number of open files, to see what tests leak | 19:58 |
| *** natea has quit IRC | 19:58 | |
| J1m | efge, doesn the test not fail with gc.collect? | 19:58 |
| J1m | efge, does the test not fail with gc.collect? | 19:58 |
| efge | J1m: it keeps failing | 19:58 |
| J1m | ok, please try the following: | 19:59 |
| J1m | add a time.sleep(300) to the top of that test. | 19:59 |
| *** natea has joined #zope3-dev | 19:59 | |
| Theuni | agroszer: the shutdown looks right. the restart would need an exit code of 1 to signal zdaemon a restart ... that's a bit harder probably ... | 20:01 |
| *** zbir` is now known as zbir | 20:01 | |
| J1m | efge, what is the problem of the teardown in test_constraints.py? | 20:02 |
| efge | J1m: the setUp calls zope.testing.module.setUp with a name parameter, but not the tearDown | 20:03 |
| J1m | ok | 20:03 |
| J1m | There is some sort of problem in the test infrastructure. | 20:03 |
| J1m | Because the tearDown should not have failed. | 20:04 |
| J1m | In fact, it shouldn't be necessary to pass the name in the tearDown. | 20:04 |
| J1m | The tearDown only fails if -D is used. | 20:04 |
| efge | J1m: this has problems too: ./test.py -D -u -s zope.app.generations | 20:04 |
| J1m | I think it is a test infrastructure bug. | 20:05 |
| J1m | I'll investigate. | 20:05 |
| efge | ok | 20:05 |
| J1m | (already am. :) | 20:05 |
| Theuni | graceful restart: I'll have to add a module global variable to store the exit code for the process in zope/app/twisted/main. Anyone against that? | 20:06 |
| efge | J1m: actually I'm testing with -D because that's the only case I found in the testrunner where I could add a line in the for loop between each test, I didn't find in non-D mode where you loop over tests | 20:06 |
| efge | (i'm adding a line to log open files) | 20:06 |
| J1m | Yeah, it would be nice to add some sort of hook for that. | 20:06 |
| Theuni | J1m: I assume you meant me? | 20:07 |
| J1m | Theuni, huh? | 20:07 |
| Theuni | ok ... never mind ... i wasn't sure who you meant ... | 20:07 |
| J1m | I was talking to efge. :) | 20:08 |
| Theuni | that was the other option :) | 20:08 |
| J1m | efge, are you trying time.sleep()? | 20:09 |
| efge | J1m: no, I'm doing other measures. I can't see what time.sleep() would gain also :) | 20:09 |
| J1m | Why didn't you ask for an explanation? | 20:10 |
| efge | J1m: have a look at http://zope3.pastebin.com/446329 and http://zope3.pastebin.com/446331 these are the number of open files before each test | 20:10 |
| efge | J1m: I would have, I was just busy on something else :) | 20:10 |
| J1m | Tim has the theory that we might be being bitten by sockets in the TIME_WAIT state. | 20:10 |
| efge | (the traces aren't complete) | 20:10 |
| efge | J1m: but the leaks aren't sockets, but directory fds | 20:11 |
| J1m | The idea for the sleep was to give time for sockets to timr out. | 20:11 |
| J1m | I think it is worth ruling out. | 20:11 |
| efge | ok will do | 20:12 |
| TresEquis | directory fds pretty much have to be the cwd of a process | 20:12 |
| TresEquis | no other directories are normally held open for any length of time | 20:12 |
| TresEquis | but in that case the 256 fd limit shouldn't be an issue, because each one would be in a separate PID | 20:13 |
| Theuni | agroszer: looks like i got it working | 20:13 |
| agroszer | Theuni: congrats, that was issue #485 | 20:15 |
| Theuni | i know | 20:17 |
| Theuni | i was digging through medium stuff because the critical stuff exceeds my knowledge | 20:17 |
| Theuni | actually i even got the timed restart and shutdown working | 20:17 |
| Theuni | i _love_ twisted for that | 20:17 |
| * TresEquis wishes he were less worried about the "stepchild" status of the HTTP server within the twisted project | 20:18 | |
| * Theuni hands over some beer to TresEquis | 20:18 | |
| Theuni | better now? | 20:18 |
| TresEquis | Beer is not a palliative :p | 20:19 |
| Theuni | hmm | 20:20 |
| Theuni | can somebody tell me if the pattern that connects zodbcontrol.pt and zodbcontrol.py:pack in zope/app/applicationcontrol/ is still valid? | 20:22 |
| Theuni | (using something like tal:define="status view/pack" .... and in the view "if 'PACK' in self.request" ... ) | 20:23 |
| J1m | efge, how are you invoking lsof? | 20:27 |
| J1m | what options? | 20:27 |
| efge | lsof -p followed by the process name | 20:29 |
| J1m | Hm. | 20:29 |
| J1m | If you do: | 20:30 |
| J1m | p4 test.py -szope.app.file -tFileAdd -N10000 | 20:30 |
| J1m | do you see leakage? | 20:30 |
| efge | J1m: I'll try | 20:31 |
| efge | J1m: meanwhile, I've tracked at least one of the leaks to zope.publisher.browser.TestRequest's invocation from zope.app.form.browser.tests.test_browserwidget in setUpContent | 20:32 |
| *** andres has quit IRC | 20:33 | |
| efge | J1m: no the 10000 loop doesn't leak | 20:33 |
| J1m | Does it leak if you run it for the test you just mentioned? | 20:33 |
| *** gumpa has joined #zope3-dev | 20:36 | |
| *** faassen has quit IRC | 20:38 | |
| *** vlado has quit IRC | 20:39 | |
| efge | J1m: hard to ascertain, ./test.py -vv -u -s zope.app.form.browser -N 2 produces test failures :( | 20:41 |
| *** andres has joined #zope3-dev | 20:41 | |
| J1m | Try: p4 test.py -szope.app.form.browser.tests -m test_browserwidget -N10000 | 20:42 |
| efge | simpler to check: ./test.py -vv -u -s zope.app.form.browser -m test_passw -N 2 produces tests failures | 20:42 |
| efge | J1m: test_browserwidget looped doesn't leak | 20:42 |
| efge | I'm not sure I'm mesuring real leaks, the behaviour I observe is not totally consistent... even though I gc.collect() before each mesure | 20:49 |
| J1m | how many fds do you have open at entry to testManyClients? | 20:49 |
| efge | J1m: when I run the whole suite? around 200 | 20:50 |
| J1m | yes, ok | 20:50 |
| J1m | I wanna see if I can reproduce that symptom | 20:50 |
| efge | looping zope.app.form.browser defintely shows leaks increasing | 20:51 |
| *** d2m has quit IRC | 20:51 | |
| efge | even though after one loop some doctests are failing | 20:53 |
| efge | but I seem to have a ceiling at 184 fds | 20:56 |
| Theuni | *phew. we have the real shutdown and restart buttons back. and we have the countdown now. | 20:58 |
| *** gumpa_ has joined #zope3-dev | 21:01 | |
| *** natea is now known as natea|away | 21:02 | |
| J1m | efge, I think I see what's happening | 21:02 |
| J1m | sort of. | 21:02 |
| J1m | Tres was right. | 21:02 |
| J1m | But I'm a bit puzzled. | 21:02 |
| efge | ok? | 21:02 |
| J1m | In zope.publisher.http, a TemporaryFile is created. | 21:03 |
| J1m | Files created for taht are being left open. | 21:03 |
| J1m | for that | 21:03 |
| J1m | I'm investigating to see why. | 21:03 |
| J1m | I'm seeing a similar ceiling | 21:03 |
| efge | J1m: is that the TemporaryFile due to FileStorage ? | 21:04 |
| J1m | No | 21:04 |
| efge | I saw it but thought it would be destroyed | 21:04 |
| J1m | It's for a cacheStream | 21:04 |
| efge | sorry I meant FieldStorage | 21:04 |
| J1m | Whatever that is. | 21:05 |
| J1m | No, it's opened by http. | 21:05 |
| *** TresEquis has quit IRC | 21:10 | |
| *** MJ has joined #zope3-dev | 21:17 | |
| *** natea|away has quit IRC | 21:27 | |
| *** natea has joined #zope3-dev | 21:31 | |
| *** natea has quit IRC | 21:33 | |
| *** MJ has quit IRC | 21:34 | |
| *** MJ has joined #zope3-dev | 21:37 | |
| *** tlotze has quit IRC | 21:41 | |
| *** d2m has joined #zope3-dev | 22:07 | |
| *** natea has joined #zope3-dev | 22:15 | |
| *** agroszer has quit IRC | 22:25 | |
| *** Aiste has quit IRC | 22:30 | |
| *** efge has quit IRC | 22:30 | |
| *** efrerich_ has joined #zope3-dev | 22:35 | |
| *** _anguenot has quit IRC | 22:37 | |
| *** SteveA has joined #zope3-dev | 22:47 | |
| SteveA | J1m: hi. i just heard it was a bug day today. if i get to hear about it a bit earlier, i can get some launchpad hackers to help out. | 22:48 |
| J1m | ah | 22:48 |
| J1m | I didn't organize it. :) | 22:48 |
| SteveA | i have a note about the http headers issue. | 22:49 |
| J1m | cool | 22:49 |
| * Theuni listens | 22:50 | |
| SteveA | i mean, i have a note that i should get the Zope 3 HEAD and see if it is still a serious issue | 22:51 |
| Theuni | heh | 22:52 |
| SteveA | the way things were when i filed the bug, if you had a Big5 encoded page, for example, the headers would have been mangled | 22:52 |
| Theuni | hmm ... | 22:52 |
| *** efrerich has quit IRC | 22:52 | |
| *** Aiste has joined #zope3-dev | 22:53 | |
| Theuni | i think i just understood what you meant with the report | 22:56 |
| *** mgedmin has quit IRC | 22:58 | |
| Theuni | hmm. i'm pretty sure i'm unable to create a big5 encoded file as my editing environment destroys everything ... | 23:12 |
| Theuni | hmpf | 23:12 |
| Theuni | J1m: i was looking at issue 185 and can reproduce that in a unit test | 23:15 |
| Theuni | the question is: should zope.index.keyword care about removing proxies or not? | 23:15 |
| J1m | no, it should not. | 23:16 |
| Theuni | Hmm. | 23:17 |
| Theuni | So do you have an idea how to handle that? | 23:17 |
| J1m | yes | 23:17 |
| J1m | Fist, the intent is to catch people passing strings. | 23:18 |
| J1m | first | 23:18 |
| *** ignas has quit IRC | 23:18 | |
| J1m | so, it should do: | 23:18 |
| J1m | if isinstance(seq, basestring): | 23:19 |
| J1m | raise .... | 23:19 |
| J1m | That's really all that's needed. | 23:19 |
| J1m | It doesn't really require a tuple or list. | 23:19 |
| Theuni | aha! | 23:19 |
| Theuni | so it will break with a different exception anyway if i pass in an instance of foo, right? | 23:20 |
| J1m | unless foo is an irritable of strings. | 23:21 |
| Theuni | i'm not sure what irritable means in this context | 23:21 |
| J1m | It means you can irritate it. | 23:21 |
| * Theuni scratches his head | 23:22 | |
| J1m | You know, getting the values one at a time. ;) | 23:22 |
| * Theuni looks a bit dumb | 23:22 | |
| * J1m enjoys pulling Theuni's leg with a play on words. | 23:22 | |
| * Theuni plays with his tongue | 23:22 | |
| Theuni | lalala | 23:22 |
| J1m | The boring way to say it is iterable. | 23:22 |
| Theuni | ok | 23:22 |
| Theuni | got me | 23:23 |
| Theuni | i really didn't get taht | 23:23 |
| Theuni | that | 23:23 |
| J1m | sorry | 23:23 |
| J1m | It wasn't really fair. | 23:23 |
| Theuni | i was staring at my dictionary | 23:23 |
| Theuni | and it only gave me irritable bowel syndrome | 23:23 |
| Theuni | no problem | 23:23 |
| Theuni | this day is way too good to get annoyed of anything | 23:24 |
| * J1m tries not to pictures a for loop over a bowel. | 23:24 | |
| Theuni | so i'll leave the unit test for proxied objects in there and change the condition to avoid string instances | 23:24 |
| Theuni | and add a test for strings of course | 23:25 |
| J1m | we don't really want the test to depend on zope.proxy. | 23:25 |
| Theuni | ... | 23:25 |
| Theuni | (coding style: are oneline-blocks really allowed? like "if not x: pass" ?) | 23:25 |
| J1m | You just want to make sure it doesn't accept a string but does accept an iterable of strings. | 23:25 |
| J1m | no | 23:26 |
| *** JoaoJoao has joined #zope3-dev | 23:26 | |
| * Theuni cleans them up | 23:26 | |
| J1m | You can fix that too. :) | 23:26 |
| Theuni | i got my editor to mark those bold and with red background | 23:26 |
| JoaoJoao | hello | 23:26 |
| Theuni | they are a pain in my eyes now | 23:26 |
| J1m | I found out why we are "leaking" temporary files. | 23:26 |
| Theuni | i saw that discussion | 23:26 |
| J1m | Yeah, but I ran it down. | 23:27 |
| Theuni | i'm not sure i know whether you found the source or not | 23:27 |
| Theuni | so who is it? | 23:27 |
| J1m | I'm not sure how to fix it though. | 23:27 |
| J1m | nearly everyone. ;) | 23:27 |
| * Theuni doesn't leak temporary files | 23:27 | |
| J1m | It's common practice in old-style unit tests to do things like: | 23:27 |
| J1m | self.request = TestRequest | 23:27 |
| J1m | in setUp methods. | 23:28 |
| Theuni | aha | 23:28 |
| J1m | These are never cleaned up in tearDown methods. | 23:28 |
| J1m | I bet you have done that. | 23:28 |
| Theuni | i may have written code that does. but i never leaked a temporary file ... | 23:28 |
| J1m | or similarly, self.view = MyView(foo, request) | 23:28 |
| * Theuni puts $5 into the box for bad word play | 23:29 | |
| Theuni | so now we'll need a bazillion of monkeys to update the tests? | 23:29 |
| J1m | Only when you have an iterable bowl. | 23:29 |
| J1m | Only when you have an iterable bowel. | 23:29 |
| J1m | I don't know. | 23:29 |
| Theuni | i think all the food i put in me iterates over my bowel | 23:30 |
| Theuni | actually i hope it iterates *through* my bowel | 23:30 |
| Theuni | i mean, if it is a consistent style then we might get away with a lazy thing that catches 99% of those, right? | 23:31 |
| J1m | The test runner could save the test's __dict__ before running it and restore it afterwords. | 23:31 |
| J1m | sort of a savepoint and restore. | 23:31 |
| Theuni | thought about that too | 23:32 |
| J1m | Seems a tad invasive though. | 23:32 |
| Theuni | not sure about any complications | 23:32 |
| J1m | It really is a lot like a rollback. | 23:32 |
| J1m | A test could bother to defeat it. | 23:32 |
| Theuni | the other way would be to filter __dict__ for a couple of well known keywords. but that isn't invasive enough i'm afraid. | 23:33 |
| Theuni | why should it try to defeat it? | 23:33 |
| J1m | But I don't think we have to worry about that. | 23:33 |
| J1m | It shouldn't. | 23:33 |
| Theuni | so i'd go for rollback | 23:33 |
| J1m | That's why I don't think we have to worry about it. | 23:33 |
| Theuni | that index code looks already like zope 2 code ... *bah | 23:33 |
| J1m | Yeah, me too. | 23:33 |
| J1m | I think it was a port of z2 code. | 23:34 |
| Theuni | hmm | 23:34 |
| Theuni | now that's funny | 23:34 |
| Theuni | it throws a string into a list already | 23:34 |
| Theuni | so actually i only have to remove the test for non-tuple/lists | 23:35 |
| J1m | No, I think you need to test that a string isn't passed. | 23:35 |
| Theuni | that would change current behaviour | 23:35 |
| Theuni | do we want that? | 23:35 |
| J1m | The intent of that was to avoid that common mistake. | 23:35 |
| Theuni | ok | 23:36 |
| J1m | It would make it more permissive. | 23:36 |
| Theuni | i'm fine with that ... i just don't want to be blamed ... | 23:36 |
| J1m | But I think that's OK. | 23:36 |
| Theuni | do you want that rule to apply to the search method as well? | 23:40 |
| J1m | yes | 23:41 |
| J1m | there, there is already a test for lists. | 23:41 |
| J1m | so I think you can just remove the list/tuple test. | 23:41 |
| Theuni | hmm the actual question was about beeing able to search for '' instead of [''] | 23:42 |
| *** ChanServ sets mode: +o hazmat | 23:43 | |
| *** BjornT has quit IRC | 23:44 | |
| Theuni | J1m: I interpret it the way that you should not be able to search for '', but have to pass [''] explicitly. right? | 23:49 |
| *** BjornT has joined #zope3-dev | 23:50 | |
| J1m | look at the exusting search method | 23:53 |
| J1m | if isinstance(query, StringTypes): query = [query] | 23:54 |
| Theuni | exusting is not an english word i'm afraid | 23:54 |
| Theuni | you mean existing? | 23:54 |
| J1m | existing | 23:54 |
| Theuni | ah right | 23:54 |
| * Theuni was afraid of another word play | 23:54 | |
| Theuni | my question only is: do you want it to stay that way or not? | 23:55 |
| J1m | I don't have a strong enough opinion to change it. | 23:55 |
| Theuni | i'm sorry if i missed an answer earlier ... | 23:55 |
| Theuni | Hmm. Darn. | 23:55 |
| * Theuni changes that stuff back | 23:55 | |
| Theuni | lets see how many unit tests outside of zope.index.keyword break | 23:55 |
| Theuni | none | 23:56 |
| Theuni | actually the interface already specified that the query _should_ be a list/tuple of stirngs | 23:56 |
| Theuni | strings | 23:56 |
| Theuni | it doesn't mention what else is accepted | 23:56 |
| Theuni | so formally it would be good to make the interface more clear. on the other hand we likely don't want to annoy people by breaking code. | 23:57 |
| Theuni | what about deprecating it? | 23:57 |
| J1m | I suggest that the interface should say that either a string or an iterable of values is accepted. | 23:58 |
| Theuni | Ok. | 23:58 |
| *** sashav_ has joined #zope3-dev | 23:59 | |
| *** sashav has quit IRC | 23:59 | |
| *** sashav_ is now known as sashav | 23:59 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!