*** zbir has quit IRC | 00:03 | |
*** sashav has quit IRC | 00:04 | |
*** sashav has joined #zope3-dev | 00:04 | |
*** whit_ has joined #zope3-dev | 00:07 | |
*** whit_ has quit IRC | 00:09 | |
*** whit_ has joined #zope3-dev | 00:14 | |
*** tarek has quit IRC | 00:15 | |
*** jinty has quit IRC | 00:18 | |
*** ChrisW has joined #zope3-dev | 00:19 | |
ChrisW | j1m: ping? | 00:21 |
---|---|---|
*** natea has joined #zope3-dev | 00:21 | |
j1m | Yes? | 00:21 |
ChrisW | (or anyone else with zodb foo, for that matter) | 00:21 |
ChrisW | I'm trying to work on http://www.zope.org/Collectors/Zope/2062 | 00:21 |
ChrisW | (not zope 3, I know, so please point me to a better channel if there is one...) | 00:21 |
*** benji has quit IRC | 00:22 | |
ChrisW | got down to around line 149 in History.py, which is roughly http://zope3.pastebin.com/683804 | 00:22 |
ChrisW | the base.__setstate__(state) works | 00:23 |
ChrisW | but some tiem after that the changes get lost :-S | 00:23 |
ChrisW | this appears to be wondering into deep ZODB fu, was wondering if you had any pointers | 00:23 |
ChrisW | and, more trickilly, how to write tests for this... | 00:23 |
j1m | I don't have time to help with this. | 00:23 |
ChrisW | no worries, any pointers (including to people) greatfully received | 00:24 |
*** whit_ has quit IRC | 00:26 | |
*** whit has joined #zope3-dev | 00:27 | |
*** sashav has quit IRC | 00:30 | |
*** sashav has joined #zope3-dev | 00:30 | |
*** dobee has quit IRC | 00:37 | |
*** natea has quit IRC | 00:41 | |
*** zbir` is now known as zbir | 00:42 | |
*** natea has joined #zope3-dev | 00:43 | |
*** efrerich has quit IRC | 00:47 | |
*** sashav has quit IRC | 00:55 | |
*** s1 has joined #zope3-dev | 01:19 | |
*** zbir has quit IRC | 01:19 | |
*** s1 is now known as sm | 01:19 | |
*** whit has quit IRC | 01:22 | |
*** jinty has joined #zope3-dev | 01:23 | |
*** whit has joined #zope3-dev | 01:28 | |
*** ChanServ sets mode: +o tav | 01:30 | |
*** whit has quit IRC | 01:32 | |
*** natea has quit IRC | 01:36 | |
*** ChrisW has left #zope3-dev | 01:47 | |
*** natea has joined #zope3-dev | 01:49 | |
*** SiggyF has quit IRC | 02:00 | |
*** sm has quit IRC | 02:01 | |
*** jinty has quit IRC | 02:04 | |
*** jhklm4 has joined #zope3-dev | 02:08 | |
*** sm has joined #zope3-dev | 02:09 | |
*** whit has joined #zope3-dev | 02:25 | |
*** rockyburt is now known as rockyburt|away | 02:29 | |
*** whit has quit IRC | 02:29 | |
*** zbir has joined #zope3-dev | 02:31 | |
*** jhklm4 has quit IRC | 02:45 | |
*** natea has quit IRC | 03:00 | |
*** roym has quit IRC | 03:30 | |
*** Londo_ has quit IRC | 03:43 | |
*** rockyburt|away has quit IRC | 03:44 | |
*** seang has quit IRC | 03:46 | |
*** natea has joined #zope3-dev | 04:15 | |
*** natea has quit IRC | 04:34 | |
*** stub has joined #zope3-dev | 04:39 | |
*** RaFromBRC has quit IRC | 05:11 | |
*** niemeyer has quit IRC | 06:25 | |
*** tristil has joined #zope3-dev | 06:45 | |
*** dobee has joined #zope3-dev | 07:12 | |
*** stub has quit IRC | 07:22 | |
*** sashav has joined #zope3-dev | 07:56 | |
*** tristil has quit IRC | 08:04 | |
*** sashav has quit IRC | 08:12 | |
*** stub has joined #zope3-dev | 08:13 | |
*** eins has joined #zope3-dev | 08:14 | |
eins | hi | 08:14 |
*** mexiKON has joined #zope3-dev | 08:41 | |
*** zopePloneConsult has joined #zope3-dev | 08:41 | |
*** philiKON has quit IRC | 08:49 | |
*** stub has quit IRC | 08:53 | |
*** hdima has joined #zope3-dev | 08:59 | |
*** sm has quit IRC | 09:13 | |
*** d2m has quit IRC | 09:17 | |
*** d2m has joined #zope3-dev | 09:30 | |
*** zagy has joined #zope3-dev | 09:41 | |
*** stub has joined #zope3-dev | 09:43 | |
*** povbot has joined #zope3-dev | 14:49 | |
srichter | no, that's the way to do it | 14:49 |
*** natea has joined #zope3-dev | 14:51 | |
regebro | Hmmm. I guess I should do this in my default IBrowserPublisher.browserDefault method.... Yeah, that should work. | 14:53 |
srichter | mmh, SelectedManagementView.html does not seem to work correctly anymore :-( | 14:56 |
faassen | hm, NotFoundError is gone? | 14:59 |
faassen | or is that one back now? | 14:59 |
faassen | I wonder where NotFoundError went. | 15:00 |
*** andres_ has quit IRC | 15:00 | |
faassen | hm, there is a deprecation warning in Zope 3.2 | 15:01 |
faassen | but somehow that never fired. | 15:01 |
faassen | it says I should use standard exceptions instead, but which one? | 15:02 |
regebro | faassen: TraversalError, no? | 15:02 |
srichter | faassen: Jim answered this question above | 15:02 |
srichter | he claimed it should be LookupError | 15:03 |
srichter | though the notfound views are registered on TraversalError | 15:03 |
srichter | I had the same problem with my app here | 15:03 |
faassen | hm, problems in optionstorage. | 15:03 |
faassen | schooltool apparently uses this. | 15:04 |
faassen | and this still uses NotFoundError. | 15:04 |
faassen | it claims the following: | 15:04 |
faassen | class StorageNameNotFoundError(NotFoundError): | 15:04 |
faassen | # BBB: Can be Remove in 3.3 | 15:04 |
faassen | pass | 15:04 |
faassen | but then it uses StorageNameNotFoundError above. | 15:04 |
faassen | I mean, below. | 15:04 |
srichter | mmh, unfortunately, the deprecated module did not work too well | 15:05 |
faassen | no. | 15:05 |
faassen | so.. | 15:05 |
faassen | Should I replace this with a lookup error or something? | 15:05 |
faassen | I don't even know what optionstorage is supposed to do. :) | 15:06 |
srichter | option storages are basically manageble vocabularies | 15:06 |
srichter | they allow you to manage the terms in the ZODB | 15:06 |
srichter | also supports i18n | 15:06 |
faassen | the gradebook uses them. :) | 15:07 |
srichter | unfortunately they do not have tests, but it was easier to use them than to rewrite the code and test it | 15:07 |
srichter | right | 15:07 |
faassen | I just wonder what uses StorageNameNotFoundError.. | 15:07 |
srichter | I dunno | 15:08 |
srichter | I would try to remove it and see what happens | 15:08 |
faassen | well, something raises it. :) | 15:08 |
faassen | I'd need to raise something instead. | 15:08 |
faassen | nothing appears to be using it. | 15:09 |
faassen | but I'd need to replace that exception with some other. | 15:09 |
srichter | I think a LookupError will be fine | 15:09 |
faassen | ok, I shall try that. | 15:09 |
srichter | so just inherit from LookupError | 15:09 |
faassen | hm, stuff is raising LookupError but it's never imported. | 15:10 |
faassen | what's up with that? | 15:10 |
faassen | oh, python builtin. | 15:10 |
faassen | ok. | 15:10 |
efge | yeah little know builtin | 15:10 |
faassen | okay, this is a bit of wild west coding, just taking out the exception altogether. :) | 15:11 |
*** b_52Centos is now known as b_52Centos_miam | 15:19 | |
*** ignas_ has quit IRC | 15:19 | |
*** ignas has joined #zope3-dev | 15:19 | |
*** MacYET has joined #zope3-dev | 15:20 | |
*** ignas has quit IRC | 15:20 | |
*** ignas has joined #zope3-dev | 15:20 | |
*** mgedmin_ has joined #zope3-dev | 15:21 | |
*** mgedmin_ has quit IRC | 15:22 | |
faassen | hm, AdapterRegistration doesn't have a value attribute anymore. | 15:23 |
srichter | that's a bug it seems | 15:23 |
srichter | maybe it has been replaced by another attribute | 15:23 |
srichter | it is called factory now | 15:24 |
faassen | that attribute? | 15:24 |
srichter | yes | 15:24 |
srichter | "value" used to be the adapter factory (as far as I remember); the interface now says it is called "factory" | 15:24 |
faassen | hm. | 15:24 |
MacYET | morning | 15:25 |
faassen | so what do we do? add an attribute value and put in a deprecation warning? | 15:25 |
faassen | hey MacYET | 15:25 |
srichter | faassen: yes, that's what I would do | 15:25 |
MacYET | srichter: you're the release slave for 3.3? | 15:25 |
faassen | there is apparently also a component attribute. | 15:25 |
srichter | MacYET: probably so ;-) | 15:25 |
faassen | that got remapped to factory. | 15:25 |
faassen | srichter: so how does that work? | 15:25 |
MacYET | fine | 15:25 |
faassen | srichter: I mean, if component and value were the same thing before, what I would do is right. | 15:25 |
*** jukart has joined #zope3-dev | 15:26 | |
jukart | dobee, ayt? | 15:27 |
srichter | faassen: all you really need is a property called "value" that raises a deprecation warning when accessed | 15:27 |
faassen | yes. | 15:27 |
faassen | I know, but since there is already an attribute component. | 15:27 |
faassen | that does just that. | 15:27 |
srichter | I think zope.depcrecation has a helper function | 15:27 |
faassen | I'm trying to figure out whether I'm doing the right thing. | 15:27 |
faassen | yeah, I can copy and paste literally from 'component' | 15:27 |
faassen | but I am trying to figure out where that attribute came from. | 15:27 |
faassen | it didn'te xist on AdapterRegistration in zope 3.2 | 15:28 |
faassen | so I wonder whether that was a mistake. | 15:28 |
srichter | really? | 15:28 |
srichter | strange | 15:28 |
srichter | it should have | 15:28 |
faassen | I suspect so, as there's a component attribute on UtilityRegistration. | 15:28 |
srichter | MacYET: do you have suggestions for the release schedule | 15:28 |
faassen | in 3.2 | 15:28 |
srichter | right | 15:28 |
srichter | it is still there in the trunk | 15:29 |
dobee | jukart: jep | 15:29 |
MacYET | basically depends on how long lennart needs for testing | 15:29 |
MacYET | regebro: ping | 15:29 |
faassen | srichter: I suspect that this deprecation warning is a bug, the one for component. | 15:29 |
faassen | srichter: but since it's not doing any harm I'll leave it in for now. | 15:29 |
srichter | ok | 15:30 |
regebro | MacYET: Hi! | 15:30 |
MacYET | talking of the evil :) | 15:30 |
faassen | evil, huh? | 15:30 |
MacYET | what is our strategy for merging the two branches? | 15:30 |
regebro | Well... 1. Deprecate five:traversable and five:defaultViewable (I'm doing that now). | 15:31 |
regebro | 2. Test with CPS. | 15:31 |
faassen | hm, doctest signature of AdapterRegistration also changed. | 15:32 |
regebro | 3. Merge. :) | 15:32 |
MacYET | can you check it with plohn as well? | 15:32 |
srichter | faassen: yeah, those type of changes we just have to live with | 15:32 |
faassen | srichter: ok.. | 15:32 |
regebro | MacYET: I'll try. | 15:33 |
regebro | I have Plone 2.5 checked out, I assume thats the version to test with. | 15:33 |
MacYET | i know, a pita for CPS guys :) | 15:33 |
regebro | If it works with CPS and not with Plone, I'll see that as a Plone bug. :P | 15:34 |
regebro | Hihi | 15:34 |
MacYET | plohne is always the guilty | 15:34 |
regebro | Anyway, Plone 2.5s recommended Zope version is still 2.8, so it will be some time before they get into the 2.10 train. | 15:34 |
MacYET | sricher: for the release: either 2.or3. or after 9th ? | 15:34 |
MacYET | you'll never know which train they take | 15:35 |
srichter | MacYET: I think beta 1 on May 2? | 15:35 |
MacYET | no problem for me | 15:35 |
MacYET | regebro: fine with u? | 15:35 |
srichter | MacYET: actually, I am in transit on that day, so for me it would have to be May 3 | 15:35 |
MacYET | 2-3 is fine | 15:35 |
regebro | Sure. | 15:36 |
MacYET | i'll be on the linuxtag on 4th... | 15:36 |
srichter | MacYET: then beta 2 after the 9th sounds good | 15:36 |
srichter | ok | 15:36 |
srichter | I think we should aim for RC 1 around the 20th? | 15:36 |
MacYET | moment | 15:36 |
MacYET | and final 1.6 | 15:37 |
regebro | Sounds good. | 15:38 |
*** niemeyer has joined #zope3-dev | 15:38 | |
MacYET | ok | 15:39 |
MacYET | srichter: shall i post the schedule? | 15:39 |
srichter | yeah, that would be great! | 15:39 |
MacYET | will do | 15:39 |
*** _sussi has joined #zope3-dev | 15:44 | |
*** andres has joined #zope3-dev | 16:00 | |
*** alecm has joined #zope3-dev | 16:01 | |
*** zbir has quit IRC | 16:03 | |
*** rockyburt has quit IRC | 16:03 | |
*** stub has quit IRC | 16:04 | |
*** b_52Centos_miam is now known as b_52Centos | 16:09 | |
*** MJ has joined #zope3-dev | 16:10 | |
*** zbir has joined #zope3-dev | 16:12 | |
*** tav has joined #zope3-dev | 16:13 | |
*** rockyburt has joined #zope3-dev | 16:21 | |
*** zbir has quit IRC | 16:22 | |
efge | beta? has the schedule moved a month earlier? I thought we had feature freeze may 1st, beta june 1st, and release july 1st. | 16:24 |
efge | you guys want to do a beta at the same time as the feature freeze? | 16:25 |
j1m | hey dudes | 16:26 |
faassen | hey j1m | 16:26 |
j1m | efge, that is theoretically the idea of the feature freeze. | 16:26 |
j1m | anything checked into the trunk should be ready for beta, or at least, the author should think it is. | 16:27 |
efge | i see | 16:27 |
j1m | Given how late I merged my branch, I think we may need to slip the freeze. | 16:27 |
faassen | what features will get in later then? | 16:28 |
j1m | I dunno, but I had the ipression that other work was blocked by the merge. | 16:28 |
faassen | possibly Five work, I haven't kept track of that. | 16:28 |
j1m | faassen, right, I'm assuming mainly Five work | 16:28 |
j1m | I don't have anything, so it's up to others to speak up. | 16:28 |
j1m | But I'm aware that the late date of the merge may have put others in a bad spot. | 16:29 |
j1m | mexiKON, ayt? | 16:29 |
mexiKON | yep | 16:29 |
mexiKON | just got home | 16:29 |
*** benji has joined #zope3-dev | 16:29 | |
mexiKON | what's up? | 16:29 |
MacYET | back | 16:30 |
*** BjornT has quit IRC | 16:30 | |
srichter | j1m: I committed a test and a fix to the site deletion problem; please have a look to make sure it is correct | 16:31 |
faassen | could there be any reason why setHeader on response somehow changed after the merge? | 16:31 |
j1m | mexiKON, efge are you aware of any Five issues with a May 1 feature freez? | 16:31 |
j1m | srichter, k | 16:31 |
mexiKON | there's the philikon-local-components branch of Zope 2 and Five | 16:31 |
j1m | brb | 16:31 |
mexiKON | they deal with the jim-adapter branch | 16:31 |
mexiKON | they need to be merged if zope 2.10 wants to use zope 3.3 | 16:31 |
faassen | because at first glance it looks like setHeader is not doing anything. | 16:32 |
mexiKON | they're not 100% done yet | 16:32 |
mexiKON | i won't have time to fix them before may 1st | 16:32 |
efge | j1m: yes my issues were w.r.t the branches that will make up zope 2.10, which have to be tested with zope 3.3 | 16:33 |
mexiKON | right. there's the ajung-zpt-integration branch and regebro's branches | 16:34 |
mexiKON | and my philikon-local-components branch | 16:34 |
*** MJ has quit IRC | 16:34 | |
j1m | back | 16:35 |
j1m | so, we (royal we ;) need to sort that out before we can finalize the release schedule. | 16:36 |
MacYET | :-) | 16:37 |
faassen | what do regebro's branches do? | 16:37 |
j1m | IMO, if y'all have something important that you are sure you could finish if you had an extra week, I'd be OK with slipping a week. | 16:37 |
*** zbir has joined #zope3-dev | 16:37 | |
j1m | If not, then we just won't have it (whatever it is) in this release. | 16:38 |
mexiKON | faassen, see his psoting to zope-dev | 16:38 |
MacYET | faasen: refactoring of the traversal stuff + zpublisher/twisted integration | 16:38 |
mexiKON | j1m, 1 extra week is all i shall need | 16:38 |
regebro | fa | 16:38 |
regebro | faassen: Using IPublishTRaversable during Zope2 traversal + hopefully browserDefault stuff. | 16:39 |
regebro | and put a WSGI interface in ZPublisher. | 16:39 |
faassen | twisted integration in Zope 2 will land in Zope 2.10? | 16:39 |
faassen | presumably not as the default. :) | 16:40 |
regebro | I'm not gonna have time to do that. | 16:40 |
j1m | My main input is to point out that the special circumstances of the late merge might justify a freeze delay. But if we agree to the delay, we need to be committed to making up the time. Out target should still be an early June release. | 16:40 |
mexiKON | +1 | 16:40 |
regebro | I though deprecating the five:defaultViewable statement would be easy.... | 16:40 |
mexiKON | regebro, it doesn't have to be all in this reelease | 16:41 |
MacYET | mexiKON: define all | 16:41 |
mexiKON | all of the traversal refactoring... having an alternative to __bobo_traverse__ in form of IPublishTraverse adapters is quite an accomplishment already | 16:42 |
MacYET | then the rest for 2.11 | 16:43 |
MacYET | ? | 16:43 |
mexiKON | i would gues sso | 16:43 |
*** alecm has quit IRC | 16:43 | |
j1m | be conservative folks | 16:44 |
*** jinty has joined #zope3-dev | 16:44 | |
j1m | don't overpromise | 16:44 |
MacYET | especially don't touch the build process this time :) | 16:44 |
j1m | If you aren't *sure* that you can get something in in a releaseable state, then don't try. | 16:44 |
j1m | MacYET, I was hoping that we could get zpkg out of the build process this time. :) But I don't think we got far enough. | 16:45 |
MacYET | didn't we introdruce zpkg in 2.9? | 16:45 |
mexiKON | yes | 16:46 |
faassen | j1m: I wish we got an alternative to acquisition for Zope 2 security checks, location based security would've been nice. | 16:46 |
j1m | mexiKON, how much stuff remains in zope.app that is needed by Five? | 16:46 |
j1m | faassen, yup | 16:46 |
mexiKON | j1m, i haven't done the metrics yet. i rahter spent time on fixing Five to work with the jim-adapter branch in the first place | 16:46 |
faassen | j1m: plenty if zope.app.form is still in use, which it is. | 16:46 |
mexiKON | j1m, i'll post some statistics after the freeze | 16:46 |
mexiKON | right | 16:47 |
mexiKON | zope.app.form wasn't the target of PackageGeddon2. as it was faassen's playground anyways (re: zope.widget ;)) | 16:47 |
j1m | mexiKON, it was an error on my part to do the zope.app shrunkage work on the jim-adapter branch. Oh well. | 16:47 |
*** tav has quit IRC | 16:47 | |
mexiKON | i don't think there was a right or wrong solution :) both ways would have been problematic, one way or the other | 16:48 |
*** stainsby has joined #zope3-dev | 16:48 | |
mexiKON | anyways, it's finally in the trunk now | 16:48 |
j1m | except that I noticed that there wasn't as much overlap as I expected. | 16:48 |
j1m | yup | 16:48 |
j1m | Is there a Zope 2.10 wiki page? | 16:49 |
faassen | mexiKON: zope.widget I'm not going to tackle, as Gary said they had all kinds of advanced plans for a rewrite. | 16:49 |
faassen | mexiKON: so it won't happen. | 16:49 |
mexiKON | i'm not touching zope.app.form :) | 16:49 |
j1m | what's the big deal with zope.app.form? | 16:49 |
j1m | should be easy to just move it outta zope.app. | 16:50 |
faassen | zope.app.form.browser defines tons of widgetgs. | 16:50 |
j1m | I would think. | 16:50 |
faassen | yes, but I proposed doing it. | 16:50 |
faassen | at least moving out the widgets. | 16:50 |
faassen | into zope.widget | 16:50 |
MacYET | j1m: yes, but it's outdated | 16:50 |
faassen | but then Gary said we have plans for zope.widget, rewrite complete, etc. | 16:50 |
mexiKON | MacYET, not entirely | 16:50 |
faassen | so then I stopped with that. | 16:50 |
mexiKON | MacYET, the widgets we still need | 16:50 |
MacYET | widgets? | 16:50 |
mexiKON | zope.app.form.browser defines all the widgets we currently have in z3 | 16:51 |
j1m | I'd rather like to help get zope 2 to *not* include zope.app. | 16:51 |
mexiKON | j1m, we won't get it all done in this release | 16:51 |
MacYET | nope | 16:51 |
j1m | I'd be willing to tackle zope.app.form, if only by moving it to zope.form. | 16:51 |
mexiKON | j1m, let's try to fix everything up so that we can make the release and worry about this for zope 2.11 | 16:51 |
MacYET | zope.app won't hurt much | 16:51 |
faassen | I don't think it's realistic to tackle all the zope.app move this release. | 16:51 |
j1m | k | 16:52 |
mexiKON | j1m, as you said, let's be conservative :) | 16:52 |
faassen | yeah. :) | 16:52 |
j1m | I just didn't know what else was left in zope.app that z2 needed. | 16:52 |
* faassen does the Use Your Own Words Against You move with mexiKON | 16:52 | |
mexiKON | faassen, ahem :) | 16:52 |
faassen | hey, you were in China for years to learn kung fu, right? | 16:52 |
mexiKON | i meant this strictly release-process-oriented :) | 16:52 |
j1m | a straight move of packages wo persistent objects should be easy, as long as we don't try to refactor at the same time. | 16:53 |
mexiKON | faassen, yes, i'm a triple master in gong fu | 16:53 |
mexiKON | faassen, haya! | 16:53 |
* faassen is deadified by mexiKON's skillz. | 16:53 | |
mexiKON | j1m, the devil is in the details | 16:53 |
faassen | anyway, yeah, that's true j1m | 16:53 |
mexiKON | j1m, ZPublisher and five import some things from zope.app.publication.... | 16:53 |
faassen | but I think we should just not worry too much about making five not rely on zope.app yet this round. | 16:53 |
mexiKON | it's like pulling lots of strings | 16:53 |
j1m | mexiKON, it would good to get a rough idea of what else beside zope.app.form is needed. | 16:54 |
mexiKON | if it's that urgent, i can compile a list later | 16:54 |
j1m | I'm confident that I could knock off zope.app.form this weekend. | 16:54 |
mexiKON | what about only moving the widgets out to zope.widget? | 16:54 |
j1m | do you have any intuition for how long the list is? | 16:54 |
mexiKON | the rest of zope.app.form can die for all i care | 16:54 |
* regebro is a quadruple master of fudge ju. | 16:55 | |
j1m | mexiKON, that would be harder and riskier. | 16:55 |
mexiKON | true | 16:55 |
j1m | fwiw, for zope.app.form, I would: | 16:55 |
j1m | - Move it to zope.form | 16:55 |
j1m | - Leave an alias *without* deprecation warnings. | 16:55 |
mexiKON | aha | 16:55 |
mexiKON | what good would that do? | 16:56 |
faassen | j1m: you'd still keep the widgets in zope.app.form.browser, right? | 16:56 |
j1m | This way, we would not make people change their code until we are ready to have them change it to something more permanent | 16:56 |
j1m | yes | 16:56 |
mexiKON | aaah | 16:56 |
mexiKON | ok | 16:56 |
j1m | But then five would have one big thing that is no longer in zope.app. | 16:56 |
mexiKON | well, five does use the widgets... | 16:57 |
faassen | and it also uses other bits and pieces I think. | 16:57 |
faassen | for addform and editform. | 16:57 |
* mexiKON compiles a list | 16:57 | |
j1m | If there wasn't much left in zope.app that was needed, then we could stop using zope.app in z3. | 16:57 |
j1m | assuming that we could move the other things out easily. | 16:57 |
mexiKON | biggest piece left in five is probably zope.app.container | 16:57 |
mexiKON | zope.app.component also because of ISIte | 16:57 |
* MacYET heads for the airport, bye | 16:58 | |
mexiKON | zope.app.publisher.browser because of view metaconfiguration stuff | 16:58 |
*** MacYET has left #zope3-dev | 16:58 | |
mexiKON | the latter is actually in my proposal | 16:58 |
mexiKON | i just hadn't had the tiem to move it | 16:58 |
mexiKON | it also uses zope.app.testing for placelesssetup, but i'm convinced that 95% of the tests that use it don't really need it | 16:59 |
j1m | OK, so, something for y'all to think about. My offer stands to do zope.app.form. | 16:59 |
mexiKON | i appreciate the offer, but it wouldn't get us *that* much closer to knocking zope.app in z2 | 16:59 |
j1m | k | 17:00 |
j1m | then let's drop it. | 17:00 |
*** zopePloneConsult has left #zope3-dev | 17:05 | |
*** Aiste has quit IRC | 17:08 | |
mexiKON | faassen, saw my reply regarding IVocabularyFactory? | 17:08 |
mexiKON | bbl. jogging | 17:10 |
faassen | mexiKON: oh, no, I will check. | 17:11 |
faassen | I realized that it didn't exist in Zope 3.2. | 17:11 |
mexiKON | i'll be back in 1 hour | 17:11 |
mexiKON | or so | 17:11 |
faassen | after that. | 17:11 |
faassen | however, schooltool was using it so I figured it couldn't hurt. :) | 17:11 |
faassen | it's a pretty harmless warning. | 17:12 |
*** eins has quit IRC | 17:14 | |
*** hdima has quit IRC | 17:15 | |
*** jukart has left #zope3-dev | 17:17 | |
*** sm has joined #zope3-dev | 17:18 | |
*** BjornT has joined #zope3-dev | 17:18 | |
*** stainsby has left #zope3-dev | 17:20 | |
j1m | It would be good for someone to make a 2.10 release page and try to gather what needs to be done. | 17:33 |
j1m | If anyone is going to work on collector entries, they should assign them to themselves first. | 17:34 |
j1m | so we don't duplicate efforts. | 17:35 |
*** vlado has joined #zope3-dev | 17:36 | |
*** andres_ has joined #zope3-dev | 17:41 | |
faassen | j1m: by the way, I'd prefer zope.app to ship with Zope 2.10 no matter whether we can make five not depend on anything in it anymore. | 17:43 |
j1m | why? | 17:44 |
faassen | j1m: as we tend to have a lot of synergy of people using new bits of Zope 3 and that slowly migrates into Five. | 17:44 |
faassen | j1m: and you'd block this. | 17:44 |
faassen | j1m: in the history of five we've had lots of new Zope 3 features exposed during Zope 2.x releases. | 17:44 |
faassen | j1m: most recently for instance formlib (though granted this was in zope already, not zope.app) | 17:44 |
faassen | I mean, between Zope 2.x rleeases. | 17:45 |
faassen | just in normal development on top of Zope 2.8 or Zope 2.9. | 17:45 |
*** sashav has quit IRC | 17:46 | |
j1m | There's no reason someone couldn't still to this in development mode. | 17:46 |
j1m | But I'm not going to argue the point. | 17:46 |
faassen | people are often motivated by short-term gains. | 17:46 |
j1m | It doesn't effect me. | 17:46 |
faassen | i.e. do it within the Zope 2.x release cycle. | 17:46 |
regebro | CPSMailAccess for example uses zope.app.cache and zope.app.I.don't.know.what. :) | 17:46 |
faassen | right. | 17:46 |
faassen | that's another risk, you risk breaking Five-based applications that expose more of Zope 3 than Five does by itself. | 17:47 |
srichter | I agree that Zope 2 should zhip with all of Zope 3 | 17:47 |
srichter | until we are sure that really only Zope 3 app server speciifc stuff is in there, which is not much | 17:48 |
srichter | maybe the skins, server package, twisted package and appsetup package | 17:48 |
*** gumpa has joined #zope3-dev | 17:50 | |
faassen | j1m: we had a thread some time ago on zope-dev I think, where I tried to make the case. :) | 17:50 |
*** andres has quit IRC | 17:58 | |
*** jukart has joined #zope3-dev | 18:00 | |
regebro | I'm trying to provide an adapter for "*" in python (it's a test). | 18:01 |
regebro | Anybody know how to do that? | 18:01 |
jukart | maybe just adapt to Interface | 18:01 |
regebro | Good idea, lets try. | 18:02 |
*** vlado has quit IRC | 18:03 | |
regebro | Yeah, that worked, thanks jukart. | 18:03 |
jukart | np | 18:06 |
*** Aiste has joined #zope3-dev | 18:15 | |
*** alga has quit IRC | 18:18 | |
*** Aiste has quit IRC | 18:20 | |
*** whit has joined #zope3-dev | 18:40 | |
*** whit has quit IRC | 18:44 | |
*** srichter has quit IRC | 18:55 | |
*** zbir` has joined #zope3-dev | 19:11 | |
*** zbir has quit IRC | 19:19 | |
*** zagy has quit IRC | 19:22 | |
regebro | Sigh. | 19:24 |
regebro | How are you supposed to figure out what the error is, when you have a functional doc test that fails? | 19:24 |
regebro | All you GET is internal server error... | 19:25 |
mexiKON | that's why testbrowser tests are a pain to debug | 19:25 |
regebro | I'm grasping blindly... | 19:26 |
mexiKON | regebro, my way of trouble shooting these things has been so far to add the same HTTP call as a traiditional http(...) call | 19:27 |
BjornT | regebro: you'll get a traceback instead if you set browser.handleErrors to False | 19:27 |
mexiKON | then you'll get the traceback | 19:27 |
mexiKON | BjornT, ahh | 19:27 |
* mexiKON should've read the testbrowser docs :) | 19:28 | |
mexiKON | why isn't that on by default? | 19:28 |
mexiKON | j1m, iv'e compiled a list of remaining tasks for zope 2.10. see my posting to zope-dev. | 19:29 |
regebro | Oh THANK YOU! | 19:29 |
regebro | What a relief. :) | 19:30 |
* mexiKON has a coiuple of tests to try that on himself | 19:30 | |
regebro | Oh, yeah, right, Five monkeypatches Expression.restrictedtraverse.... That's why I couldn't put a set_trace() there... | 19:31 |
*** _sussi has quit IRC | 19:31 | |
*** _sussi has joined #zope3-dev | 19:32 | |
mexiKON | waaa | 19:32 |
mexiKON | it does? | 19:32 |
mexiKON | that might be the reason why ajung's branch is failing too | 19:33 |
mexiKON | faassen, still there? | 19:33 |
*** _sussi has quit IRC | 19:34 | |
faassen | mexiKON: yes, here. | 19:35 |
mexiKON | faassen, the alias you made for IVocabularyFactory doesn't say when it'll disappear. how about we say that it'll disappear in z 3.3 final | 19:36 |
mexiKON | should give schooltool etc. enough time to adjust | 19:36 |
faassen | mexiKON: ok, sure. | 19:36 |
faassen | mexiKON: schooltool is done already. :) | 19:36 |
mexiKON | :) | 19:37 |
faassen | mexiKON: so I guess it can be taken out again. :) | 19:37 |
* mexiKON takes it out then | 19:37 | |
mexiKON | ok done | 19:38 |
*** mexiKON is now known as philiKON | 19:38 | |
*** seang has joined #zope3-dev | 19:38 | |
*** _sussi has joined #zope3-dev | 19:39 | |
*** sashav has joined #zope3-dev | 19:43 | |
*** jinty has left #zope3-dev | 19:46 | |
*** jinty has quit IRC | 19:46 | |
j1m | Hm, I just got a chance to look at the colector and there aren't any outstanding issues. | 20:00 |
j1m | Cool. :) | 20:00 |
*** zagy has joined #zope3-dev | 20:03 | |
*** zagy has quit IRC | 20:21 | |
*** _sussi has quit IRC | 20:21 | |
*** RaFromBRC has joined #zope3-dev | 20:23 | |
*** tarek has joined #zope3-dev | 20:29 | |
j1m | faassen, where did you get a value attr on adapter registrations? | 20:40 |
faassen | j1m: there is this package schooltool.devmode that Stephan wrote | 20:42 |
*** niemeyer has quit IRC | 20:42 | |
faassen | j1m: and it was accessing that. | 20:42 |
j1m | That's weird, since adapter registrations didn't have a value attr before the merge. | 20:42 |
faassen | class AdapterRegistration(object): """Registration for a simple adapter.""" def __init__(self, required, provided, name, value, doc=''): (self.required, self.provided, self.name, self.value, self.doc ) = required, provided, name, value, doc | 20:43 |
faassen | in Zope 3.2 | 20:43 |
faassen | self.doc also was gone, replaced with self.info | 20:43 |
j1m | Yeah, good catch | 20:44 |
faassen | anyway, that code has a self.value | 20:44 |
philiKON | j1m, i remember that apidoc was using .value, .doc on adapter registrations | 20:44 |
faassen | right. | 20:44 |
faassen | this is apidoc like code. | 20:44 |
faassen | I think. | 20:44 |
faassen | anyway, after that the tests ran again. :) | 20:44 |
faassen | I have no idea what the code actually does. | 20:44 |
j1m | what file did the code above come from? | 20:44 |
faassen | I just spent most of the day chasing breakages and most of all fixing lots of deprecation warnings in schooltool. | 20:45 |
faassen | Zope3/branches/3.2/src/zope/component/site.py | 20:45 |
faassen | so zope.component.site | 20:45 |
faassen | anyway, going home now. | 20:46 |
faassen | see you! | 20:46 |
*** niemeyer has joined #zope3-dev | 20:46 | |
*** faassen has quit IRC | 20:46 | |
j1m | Oh yeah | 20:46 |
j1m | weird | 20:46 |
*** admp has joined #zope3-dev | 20:48 | |
ignas | j1m: did someone add caching mechanism to multi adapter queries ? | 20:53 |
*** andres_ is now known as andres | 20:56 | |
philiKON | ignas, no. the speedup in the adapter lookup is mostly due to a different strategy of looking them up | 21:00 |
ignas | philiKON: well - I have just had a wonderful experience in a functional test that was registering a new view through provideAdapter | 21:01 |
ignas | philiKON: and when one queries the url - gets one object, then registers a more specific view - gets the same old view one it looks like something is geting cached | 21:02 |
ignas | s/view one/view | 21:02 |
philiKON | define more specific | 21:02 |
*** tarek has quit IRC | 21:02 | |
ignas | i'll try | 21:03 |
ignas | in a functional test i have a ISchoolToolApplication as root | 21:03 |
ignas | if i do "POST /" register view, do some requests "POST /" - it works as expected | 21:04 |
ignas | second POST goes to the new view | 21:04 |
ignas | but if i do | 21:04 |
ignas | some requests, "POST /", register view, "POST /" | 21:04 |
ignas | the post goes to the old view | 21:05 |
j1m | ignas, yes, all adapter queries are cached | 21:05 |
philiKON | j1m, hah. didn't know that | 21:05 |
j1m | multi-adapter queries are more cached than they used to be. | 21:05 |
philiKON | ignas, by the way, it is debatable whether functional tests should register new things as they go along | 21:05 |
ignas | philiKON: i know | 21:06 |
philiKON | ignas, it's better to register everything in an ftesting.zcml file beforehadn | 21:06 |
j1m | registering a new view should cause the cache to be invalidated. | 21:06 |
ignas | ztapi.provideAdapter((ISchoolToolApplication, IHTTPRequest), Interface, BadView, 'POST') | 21:06 |
ignas | maybe the registration is wrong in some way? | 21:06 |
j1m | This is so far out of context I have no idea | 21:07 |
philiKON | seems to look ok | 21:07 |
philiKON | i recommend using zope.component.provideAdapter, by the way | 21:07 |
philiKON | the ztapi arrangement of arguments is quite incomprehensible | 21:07 |
j1m | plus, we'd like to deprecate ztapi at some point. | 21:08 |
j1m | Can you show both registrations? | 21:09 |
ignas | there is only one | 21:09 |
j1m | That isn't consistent with what you said above. | 21:09 |
ignas | the original view is a normal view registered in the application zcml | 21:09 |
j1m | You said you registered a new view. | 21:10 |
j1m | OK, how was it registered? | 21:10 |
ignas | J1m: http://pastebin.com/685412 | 21:13 |
ignas | the registation is for POST though | 21:13 |
ignas | and the first POST was to check for Method Not Alowed error | 21:13 |
ignas | the *new registration* i mean | 21:13 |
j1m | I have no idea what you're talking about. | 21:14 |
ignas | :/ | 21:14 |
ignas | well, now that i know that it's cache that is causing the failure i can fix it | 21:15 |
ignas | the test | 21:15 |
j1m | so are you saying that after the registration, you are still getting a method-not-allowed error? | 21:15 |
ignas | j1m: yes | 21:15 |
j1m | I'm not at all convinced that this is a caching problem. | 21:16 |
ignas | j1m: if i am removing all the queries before the one that is testing for method-not-allowed - the test passes | 21:16 |
ignas | publication.callObject(request, obj) gets the right view, and calls the POST method | 21:17 |
j1m | It would be very nice to get a test that demonstrates this. | 21:23 |
j1m | Obviously without the ST code. | 21:23 |
j1m | I can't seem to reproduce this. | 21:24 |
ignas | J1m: i'll try | 21:25 |
*** zbir` is now known as zbir | 21:25 | |
j1m | what is the site structure? | 21:26 |
j1m | Is this in the root site? | 21:26 |
j1m | A subsite of the root site? | 21:26 |
mgedmin | in schooltool there's only one site -- the schooltool application object, which replaces the zope 3 root folder | 21:28 |
j1m | Is it persistent? | 21:28 |
mgedmin | yes | 21:28 |
mgedmin | class SchoolToolApplication(Persistent, sample.SampleContainer, | 21:29 |
mgedmin | SiteManagerContainer): | 21:29 |
*** admp has quit IRC | 21:29 | |
mgedmin | hm, I don't recall seeing this before: | 21:29 |
mgedmin | def __init__(self): | 21:29 |
mgedmin | super(SchoolToolApplication, self).__init__() | 21:29 |
mgedmin | notify(ApplicationInitializationEvent(self)) | 21:29 |
j1m | I assume that in your test, you create a new site. | 21:30 |
mgedmin | I suppose ApplicationInitializationEvent takes care to initialize the site | 21:30 |
mgedmin | or at least it used to | 21:30 |
j1m | Could the test be loading the site from a database? | 21:30 |
j1m | for example, does the test run in a different transacton from the one that created the site? | 21:31 |
mgedmin | that is very possible | 21:31 |
mgedmin | wait, no | 21:31 |
mgedmin | I'm suddenly confused | 21:31 |
mgedmin | it's a functional test | 21:31 |
*** Aiste has joined #zope3-dev | 21:31 | |
mgedmin | IIRC ftests share the root folder and access it from many transactions | 21:31 |
mgedmin | and roll back any changes done between tests | 21:31 |
mgedmin | by manipulating ZODB storages | 21:32 |
mgedmin | so I guess the test does run in a different transaction from the one that created the site, yes | 21:32 |
j1m | So the root folder is created during functional test setup and then reread for each test. | 21:32 |
j1m | ? | 21:33 |
ignas | yes | 21:34 |
ignas | i think so | 21:34 |
*** srichter has joined #zope3-dev | 21:34 | |
j1m | ah, ok, I think I see the bug. | 21:35 |
j1m | I'll look into it. | 21:35 |
j1m | I'd rather you not "fix" your test. | 21:35 |
j1m | but wait for me to fix z3. | 21:35 |
mgedmin | well, the test is not very nice either: it fiddles with the component architecture and doesn't clean up after itself | 21:36 |
mgedmin | it should instead register the extra view it needs from the appropriate foo-ftesting.zcml package include | 21:37 |
j1m | Yes. That's true. | 21:37 |
j1m | I saw lots of tests like this. | 21:37 |
j1m | In the z3 sources. | 21:37 |
j1m | The new component-registry architecture should make it much easier to manage test-specific setup in the future. | 21:38 |
*** jukart has left #zope3-dev | 21:40 | |
*** sashav has quit IRC | 21:43 | |
*** sashav has joined #zope3-dev | 21:43 | |
*** andres has quit IRC | 21:50 | |
*** admp has joined #zope3-dev | 21:58 | |
*** MJ has joined #zope3-dev | 22:00 | |
*** ignas has quit IRC | 22:04 | |
*** admp has quit IRC | 22:07 | |
*** admp has joined #zope3-dev | 22:07 | |
*** admp has quit IRC | 22:08 | |
*** Egon has joined #zope3-dev | 22:10 | |
*** ChanServ sets mode: +o srichter | 22:18 | |
*** mkerrin has quit IRC | 22:19 | |
*** dobee has quit IRC | 22:20 | |
*** kamalgill has joined #zope3-dev | 22:25 | |
*** alecm has joined #zope3-dev | 22:26 | |
*** efrerich has quit IRC | 22:28 | |
*** mgedmin has quit IRC | 22:36 | |
*** alga has joined #zope3-dev | 22:38 | |
*** alga has quit IRC | 22:38 | |
*** roym has joined #zope3-dev | 22:41 | |
*** rockyburt is now known as rockyburt|hockey | 22:52 | |
*** Egon is now known as efrerich | 23:12 | |
*** sashav has quit IRC | 23:28 | |
*** sashav has joined #zope3-dev | 23:28 | |
*** dobee has joined #zope3-dev | 23:30 | |
*** MJ has quit IRC | 23:31 | |
*** alecm has quit IRC | 23:33 | |
*** regebro has quit IRC | 23:40 | |
*** zbir has quit IRC | 23:48 | |
*** benji has quit IRC | 23:52 | |
*** sashav has quit IRC | 23:56 | |
*** efrerich has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!